| Message ID | 6523722.tcSzR9xRoc@comanche (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mike, On 13.8.2013 23:29, Mike Pagano wrote: > Gracefully exit if the default config files are not present. (.config and > .config.old) Two minor nitpicks about the changelog: The subject line would be more to the point if it mentioned the name of the utility you are fixing. Otherwise, people might get the impression that you are fixing a tool from scripts/kconnfig, like 'make oldconfig' or 'make menuconfig'. Just change it to diffconfig: Gracefully exit if the default config files are not present > Diffconfig is a utility script for comparing kernel configuration files. This is superfluous information. Just describe the change you made and that's it. > - a = readconfig(file(configa_filename)) > - b = readconfig(file(configb_filename)) > + try: > + a = readconfig(file(configa_filename)) > + b = readconfig(file(configb_filename)) > + except IOError,(errno, strerror): > + print "I/O error(%s: %s)\n" % (errno, strerror) > + usage() The second block is missing one column of indentation. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/diffconfig b/scripts/diffconfig index b91f3e3..33c696f 100755 --- a/scripts/diffconfig +++ b/scripts/diffconfig @@ -94,8 +94,12 @@ def main(): configa_filename = sys.argv[1] configb_filename = sys.argv[2] - a = readconfig(file(configa_filename)) - b = readconfig(file(configb_filename)) + try: + a = readconfig(file(configa_filename)) + b = readconfig(file(configb_filename)) + except IOError,(errno, strerror): + print "I/O error(%s: %s)\n" % (errno, strerror) + usage() # print items in a but not b (accumulate, sort and print) old = []
Gracefully exit if the default config files are not present. (.config and .config.old) Diffconfig is a utility script for comparing kernel configuration files. Signed-off-by: Mike Pagano <mpagano@gentoo.org> --- scripts/diffconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)