| Message ID | 1376991021-12160-7-git-send-email-Sudeep.KarkadaNagesha@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday, August 20, 2013 10:30:08 AM Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Acked-by: Rob Herring <rob.herring@calxeda.com> > Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> Hi Greg, I this one fine with you? Rafael > --- > drivers/base/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 4c358bc..4cf0717 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -14,6 +14,7 @@ > #include <linux/slab.h> > #include <linux/percpu.h> > #include <linux/acpi.h> > +#include <linux/of.h> > > #include "base.h" > > @@ -289,6 +290,7 @@ int register_cpu(struct cpu *cpu, int num) > cpu->dev.release = cpu_device_release; > cpu->dev.offline_disabled = !cpu->hotpluggable; > cpu->dev.offline = !cpu_online(num); > + cpu->dev.of_node = of_get_cpu_node(num, NULL); > #ifdef CONFIG_ARCH_HAS_CPU_AUTOPROBE > cpu->dev.bus->uevent = arch_cpu_uevent; > #endif >
On Tue, Aug 20, 2013 at 10:30:08AM +0100, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> > > CPUs are also registered as devices but the of_node in these cpu > devices are not initialized. Currently different drivers requiring > to access cpu device node are parsing the nodes themselves and > initialising the of_node in cpu device. > > The of_node in all the cpu devices needs to be initialized properly > and at one place. The best place to update this is CPU subsystem > driver when registering the cpu devices. > > The OF/DT core library now provides of_get_cpu_node to retrieve a cpu > device node for a given logical index by abstracting the architecture > specific details. > > This patch uses of_get_cpu_node to assign of_node when registering the > cpu devices. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Acked-by: Rob Herring <rob.herring@calxeda.com> > Signed-off-by: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 4c358bc..4cf0717 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -14,6 +14,7 @@ #include <linux/slab.h> #include <linux/percpu.h> #include <linux/acpi.h> +#include <linux/of.h> #include "base.h" @@ -289,6 +290,7 @@ int register_cpu(struct cpu *cpu, int num) cpu->dev.release = cpu_device_release; cpu->dev.offline_disabled = !cpu->hotpluggable; cpu->dev.offline = !cpu_online(num); + cpu->dev.of_node = of_get_cpu_node(num, NULL); #ifdef CONFIG_ARCH_HAS_CPU_AUTOPROBE cpu->dev.bus->uevent = arch_cpu_uevent; #endif