diff mbox

[1/3] mmc: sdhci-bcm-kona: Remove unneeded version.h inclusion

Message ID 1373263914-18050-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat July 8, 2013, 6:11 a.m. UTC
version.h header inclusion is not necessary as detected by
versioncheck.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/sdhci-bcm-kona.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Sachin Kamat July 19, 2013, 11:10 a.m. UTC | #1
On 8 July 2013 11:41, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> version.h header inclusion is not necessary as detected by
> versioncheck.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 87175f9..bca6d55 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -24,7 +24,6 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/of_gpio.h>
> -#include <linux/version.h>
>  #include <linux/mmc/slot-gpio.h>
>
>  #include "sdhci-pltfm.h"
> --
> 1.7.9.5
>

Ping on this series.
Christian Daudt July 19, 2013, 8:31 p.m. UTC | #2
On 13-07-07 11:11 PM, Sachin Kamat wrote:
> version.h header inclusion is not necessary as detected by
> versioncheck.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>   drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 87175f9..bca6d55 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -24,7 +24,6 @@
>   #include <linux/of.h>
>   #include <linux/of_device.h>
>   #include <linux/of_gpio.h>
> -#include <linux/version.h>
>   #include <linux/mmc/slot-gpio.h>
>   
>   #include "sdhci-pltfm.h"
Acked-by: Christian Daudt <csd@broadcom.com>

  thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat Aug. 2, 2013, 8:50 a.m. UTC | #3
On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>
>> version.h header inclusion is not necessary as detected by
>> versioncheck.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>   drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>> b/drivers/mmc/host/sdhci-bcm-kona.c
>> index 87175f9..bca6d55 100644
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -24,7 +24,6 @@
>>   #include <linux/of.h>
>>   #include <linux/of_device.h>
>>   #include <linux/of_gpio.h>
>> -#include <linux/version.h>
>>   #include <linux/mmc/slot-gpio.h>
>>     #include "sdhci-pltfm.h"
>
> Acked-by: Christian Daudt <csd@broadcom.com>
>
>  thanks,
>    csd
>
>
Chris,

Can you please check this series?
Sachin Kamat Aug. 22, 2013, 6:07 a.m. UTC | #4
On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>
>> version.h header inclusion is not necessary as detected by
>> versioncheck.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>   drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>> b/drivers/mmc/host/sdhci-bcm-kona.c
>> index 87175f9..bca6d55 100644
>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>> @@ -24,7 +24,6 @@
>>   #include <linux/of.h>
>>   #include <linux/of_device.h>
>>   #include <linux/of_gpio.h>
>> -#include <linux/version.h>
>>   #include <linux/mmc/slot-gpio.h>
>>     #include "sdhci-pltfm.h"
>
> Acked-by: Christian Daudt <csd@broadcom.com>
>
>  thanks,
>    csd
>
>

Ping Chris..
Christian Daudt Aug. 22, 2013, 5:46 p.m. UTC | #5
On 13-08-21 11:07 PM, Sachin Kamat wrote:
> On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>> version.h header inclusion is not necessary as detected by
>>> versioncheck.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>>    drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>>    1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>> index 87175f9..bca6d55 100644
>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>> @@ -24,7 +24,6 @@
>>>    #include <linux/of.h>
>>>    #include <linux/of_device.h>
>>>    #include <linux/of_gpio.h>
>>> -#include <linux/version.h>
>>>    #include <linux/mmc/slot-gpio.h>
>>>      #include "sdhci-pltfm.h"
>> Acked-by: Christian Daudt <csd@broadcom.com>
>>
>>   thanks,
>>     csd
>>
>>
> Ping Chris..
>
>
Hi Sachin,
  I can pull this one into bcm tree, as I already have other patches for 
that file in there. I'm also pulling in patch 3. Patch 2 was already 
covered by this commit which is already in my pull request to armsoc so 
I'll drop it:
Author: Markus Mayer <markus.mayer@linaro.org>
Date:   Wed Aug 7 15:39:59 2013 -0700

     mmc: sdhci-bcm-kona: make linker-section warning go away

     This change makes the following build warning go away:
     [...]
       LINK    vmlinux
       LD      vmlinux.o
       MODPOST vmlinux.o
     WARNING: modpost: Found 2 section mismatch(es).
     To see full details build your kernel with:
     'make CONFIG_DEBUG_SECTION_MISMATCH=y'

     Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
     Reviewed-by: Christian Daudt <csd@broadcom.com>
     Reviewed-by: Matt Porter <matt.porter@linaro.org>



  thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sachin Kamat Aug. 23, 2013, 8:44 a.m. UTC | #6
Hi Christian,

On 22 August 2013 23:16, Christian Daudt <csd@broadcom.com> wrote:
> On 13-08-21 11:07 PM, Sachin Kamat wrote:
>>
>> On 20 July 2013 02:01, Christian Daudt <csd@broadcom.com> wrote:
>>>
>>> On 13-07-07 11:11 PM, Sachin Kamat wrote:
>>>>
>>>> version.h header inclusion is not necessary as detected by
>>>> versioncheck.
>>>>
>>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>>> ---
>>>>    drivers/mmc/host/sdhci-bcm-kona.c |    1 -
>>>>    1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> index 87175f9..bca6d55 100644
>>>> --- a/drivers/mmc/host/sdhci-bcm-kona.c
>>>> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
>>>> @@ -24,7 +24,6 @@
>>>>    #include <linux/of.h>
>>>>    #include <linux/of_device.h>
>>>>    #include <linux/of_gpio.h>
>>>> -#include <linux/version.h>
>>>>    #include <linux/mmc/slot-gpio.h>
>>>>      #include "sdhci-pltfm.h"
>>>
>>> Acked-by: Christian Daudt <csd@broadcom.com>
>>>
>>>   thanks,
>>>     csd
>>>
>>>
>> Ping Chris..
>>
>>
> Hi Sachin,
>  I can pull this one into bcm tree, as I already have other patches for that
> file in there. I'm also pulling in patch 3.

Sounds good. Please go ahead. Thanks.


Patch 2 was already covered by
> this commit which is already in my pull request to armsoc so I'll drop it:
> Author: Markus Mayer <markus.mayer@linaro.org>
> Date:   Wed Aug 7 15:39:59 2013 -0700
>
>     mmc: sdhci-bcm-kona: make linker-section warning go away
>
>     This change makes the following build warning go away:
>     [...]
>       LINK    vmlinux
>       LD      vmlinux.o
>       MODPOST vmlinux.o
>     WARNING: modpost: Found 2 section mismatch(es).
>     To see full details build your kernel with:
>     'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>
>     Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
>     Reviewed-by: Christian Daudt <csd@broadcom.com>
>     Reviewed-by: Matt Porter <matt.porter@linaro.org>
>
>
>
>  thanks,
>    csd
>
>
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 87175f9..bca6d55 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -24,7 +24,6 @@ 
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
-#include <linux/version.h>
 #include <linux/mmc/slot-gpio.h>
 
 #include "sdhci-pltfm.h"