| Message ID | 1373548145-3833-1-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote: > omap_hsmmc.c depends on <linux/sizes.h> being > included indirectly by another header. Once we > enable COMPILE_TEST for this driver, we might > compile under architectures which won't include > <linux/sizes.h> for us. In fact, one such case > is x86. > > In order to prevent compile breakages, let's > explicitly include <linux/sizes.h> > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > > This should be applied before http://marc.info/?l=linux-omap&m=137347241524118&w=2 > in order to maintain bisectability. Thanks Felipe Acked-by: Balaji T K <balajitk@ti.com> > > cheers > > drivers/mmc/host/omap_hsmmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 1865321..c937ffc 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -21,6 +21,7 @@ > #include <linux/debugfs.h> > #include <linux/dmaengine.h> > #include <linux/seq_file.h> > +#include <linux/sizes.h> > #include <linux/interrupt.h> > #include <linux/delay.h> > #include <linux/dma-mapping.h> > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Fri, Aug 16 2013, Balaji T K wrote: > On Thursday 11 July 2013 06:39 PM, Felipe Balbi wrote: >> omap_hsmmc.c depends on <linux/sizes.h> being >> included indirectly by another header. Once we >> enable COMPILE_TEST for this driver, we might >> compile under architectures which won't include >> <linux/sizes.h> for us. In fact, one such case >> is x86. >> >> In order to prevent compile breakages, let's >> explicitly include <linux/sizes.h> >> >> Signed-off-by: Felipe Balbi <balbi@ti.com> >> --- >> >> This should be applied before >> http://marc.info/?l=linux-omap&m=137347241524118&w=2 >> in order to maintain bisectability. > Thanks Felipe > > Acked-by: Balaji T K <balajitk@ti.com> Thanks, pushed to mmc-next for 3.12. - Chris.
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 1865321..c937ffc 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -21,6 +21,7 @@ #include <linux/debugfs.h> #include <linux/dmaengine.h> #include <linux/seq_file.h> +#include <linux/sizes.h> #include <linux/interrupt.h> #include <linux/delay.h> #include <linux/dma-mapping.h>
omap_hsmmc.c depends on <linux/sizes.h> being included indirectly by another header. Once we enable COMPILE_TEST for this driver, we might compile under architectures which won't include <linux/sizes.h> for us. In fact, one such case is x86. In order to prevent compile breakages, let's explicitly include <linux/sizes.h> Signed-off-by: Felipe Balbi <balbi@ti.com> --- This should be applied before http://marc.info/?l=linux-omap&m=137347241524118&w=2 in order to maintain bisectability. cheers drivers/mmc/host/omap_hsmmc.c | 1 + 1 file changed, 1 insertion(+)