| Message ID | 1377180132-4933-3-git-send-email-Jason@zx2c4.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Headers | show |
On Thu, Aug 22, 2013 at 04:02:12PM +0200, Jason A. Donenfeld wrote: > Thinkpads with a micmute LED do not have a capslock LED. The micmute LED > is currently not used by any piece of Linux kernel land or user land. It > seems reasonable to hook it up to caps lock, at least by default, so > users can have some degree of functionality. I think there's a risk of user confusion here, in that it's now possible for the mic mute light to be lit despite the internal microphone still being active. That seems like surprising behaviour.
On Thu, Aug 22, 2013 at 5:39 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > I think there's a risk of user confusion here, in that it's now possible > for the mic mute light to be lit despite the internal microphone still > being active. That seems like surprising behaviour. Yeah, that is a legitimate concern. Patches 1/3 [1] and 2/3 [2] clearly make sense, as they're generic and don't really suggest any new behavior. But setting this behavior here as the default could indeed be a bit unexpected. I think it's fair to reject this patch (3/3), but accept the first two. Tweakers who have the same early boot caps-lock LED needs as me can simply put this in their initramfs after 1/3 and 2/3 are applied: # echo caps-lock > /sys/devices/platform/thinkpad_acpi/leds/tpacpi\:\:micmute/trigger Jason [1] https://lkml.org/lkml/2013/8/22/310 [2] https://lkml.org/lkml/2013/8/22/313 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 22 Aug 2013, Jason A. Donenfeld wrote: > Thinkpads with a micmute LED do not have a capslock LED. The micmute LED > is currently not used by any piece of Linux kernel land or user land. It > seems reasonable to hook it up to caps lock, at least by default, so > users can have some degree of functionality. NACK. This we won't do. It is a LED misuse, and it will get in the way when we finally put that LED to its proper use.
On Fri, Aug 23, 2013 at 8:18 PM, Henrique de Moraes Holschuh <hmh@hmh.eng.br> wrote: > NACK. This we won't do. It is a LED misuse, and it will get in the way > when we finally put that LED to its proper use. Agreed. Please see my response to mjg. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 33b23cb..708fdb8 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -5235,6 +5235,10 @@ static int __init tpacpi_init_led(unsigned int led) tpacpi_leds[led].led_classdev.name = tpacpi_led_names[led]; + /* Special case wiring micmute to caps-lock by default. */ + if (led == 14) + tpacpi_leds[led].led_classdev.default_trigger = "caps-lock"; + INIT_WORK(&tpacpi_leds[led].work, led_set_status_worker); rc = led_classdev_register(&tpacpi_pdev->dev,
Thinkpads with a micmute LED do not have a capslock LED. The micmute LED is currently not used by any piece of Linux kernel land or user land. It seems reasonable to hook it up to caps lock, at least by default, so users can have some degree of functionality. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> --- drivers/platform/x86/thinkpad_acpi.c | 4 ++++ 1 file changed, 4 insertions(+)