| Message ID | 1375777984-6267-2-git-send-email-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
Hi On Tue, 6 Aug 2013, Lokesh Vutla wrote: > Add RNG hwmod data for AM33xx SoC. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> I tried to queue this one, but it caused AM33xx boots to hang. Thought it might be related to the patch ordering -- seems to me that the clock change patch needed to come before this patch -- but if I recall correctly, both BeagleBone and BeagleBone-LT still hung. Also, this patch created a sparse warning. Could you take another look at this patch? Maybe try basing off of this tag: git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending.git tags/for-v3.12/omap-prcm-hwmod Fix the sparse problem, and see if the patch boots for you? thanks - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Paul, On Thursday 29 August 2013 12:18 AM, Paul Walmsley wrote: > Hi > > On Tue, 6 Aug 2013, Lokesh Vutla wrote: > >> Add RNG hwmod data for AM33xx SoC. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > I tried to queue this one, but it caused AM33xx boots to hang. > Thought it might be related to the patch ordering -- seems to me that > the clock change patch needed to come before this patch -- but if I > recall correctly, both BeagleBone and BeagleBone-LT still hung. This is because register address space is not passed in hwmod_data as it is passed from dt. So we need to include 3/3 patch in this series to boot. Ill fix this sparse warning and post a v2. PS: Probe for this driver will be failed even after this. Support for this version of rng ip is already posted and pushed into cryptodev-2.6 tree. Thanks and regards, Lokesh > > Also, this patch created a sparse warning. > > Could you take another look at this patch? Maybe try basing off of this > tag: > > git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending.git tags/for-v3.12/omap-prcm-hwmod > > Fix the sparse problem, and see if the patch boots for you? > > thanks > > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi On Thu, 29 Aug 2013, Lokesh Vutla wrote: > On Thursday 29 August 2013 12:18 AM, Paul Walmsley wrote: > > Hi > > > > On Tue, 6 Aug 2013, Lokesh Vutla wrote: > > > >> Add RNG hwmod data for AM33xx SoC. > >> > >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > > > > I tried to queue this one, but it caused AM33xx boots to hang. > > Thought it might be related to the patch ordering -- seems to me that > > the clock change patch needed to come before this patch -- but if I > > recall correctly, both BeagleBone and BeagleBone-LT still hung. > This is because register address space is not passed in hwmod_data as it > is passed from dt. So we need to include 3/3 patch in this series to boot. So this patch has a dependency on a DT data patch? If so then please upstream that through Benoit, and put in the patch description on this patch that there's a dependency on that patch. If you post those together in a series, please make sure that the DT patch comes first so it doesn't break 'git bisect'. I've already queued the clock change patch for upstream. > PS: Probe for this driver will be failed even after this. Support for > this version of rng ip is already posted and pushed into cryptodev-2.6 > tree. I don't quite understand, could you please rephrase? - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Paul, On Thursday 29 August 2013 05:00 PM, Paul Walmsley wrote: > Hi > > On Thu, 29 Aug 2013, Lokesh Vutla wrote: > >> On Thursday 29 August 2013 12:18 AM, Paul Walmsley wrote: >>> Hi >>> >>> On Tue, 6 Aug 2013, Lokesh Vutla wrote: >>> >>>> Add RNG hwmod data for AM33xx SoC. >>>> >>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >>> >>> I tried to queue this one, but it caused AM33xx boots to hang. >>> Thought it might be related to the patch ordering -- seems to me that >>> the clock change patch needed to come before this patch -- but if I >>> recall correctly, both BeagleBone and BeagleBone-LT still hung. >> This is because register address space is not passed in hwmod_data as it >> is passed from dt. So we need to include 3/3 patch in this series to boot. > > So this patch has a dependency on a DT data patch? If so then please > upstream that through Benoit, and put in the patch description on this > patch that there's a dependency on that patch. If you post those together > in a series, please make sure that the DT patch comes first so it doesn't > break 'git bisect'. Ok, Ill repost these two patches and make sure that DT patch comes first so that 'git bisect' will not break.. > > I've already queued the clock change patch for upstream. > >> PS: Probe for this driver will be failed even after this. Support for >> this version of rng ip is already posted and pushed into cryptodev-2.6 >> tree. > > I don't quite understand, could you please rephrase? I just meant that with these patches RNG IP as such is not functional without the driver changes. Thanks and Regards, Lokesh > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index 28bbd56..6ff70aa 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -2455,6 +2455,40 @@ static struct omap_hwmod_ocp_if am33xx_l3_main__aes0 = { .user = OCP_USER_MPU | OCP_USER_SDMA, }; +/* rng */ +static struct omap_hwmod_class_sysconfig am33xx_rng_sysc = { + .rev_offs = 0x1fe0, + .sysc_offs = 0x1fe4, + .sysc_flags = SYSC_HAS_AUTOIDLE | SYSC_HAS_SIDLEMODE, + .idlemodes = SIDLE_FORCE | SIDLE_NO | SIDLE_SMART, + .sysc_fields = &omap_hwmod_sysc_type1, +}; + +static struct omap_hwmod_class am33xx_rng_hwmod_class = { + .name = "rng", + .sysc = &am33xx_rng_sysc, +}; + +static struct omap_hwmod am33xx_rng_hwmod = { + .name = "rng", + .class = &am33xx_rng_hwmod_class, + .clkdm_name = "l4ls_clkdm", + .main_clk = "rng_fck", + .prcm = { + .omap4 = { + .clkctrl_offs = AM33XX_CM_PER_RNG_CLKCTRL_OFFSET, + .modulemode = MODULEMODE_SWCTRL, + }, + }, +}; + +struct omap_hwmod_ocp_if am33xx_l4_per__rng = { + .master = &am33xx_l4_ls_hwmod, + .slave = &am33xx_rng_hwmod, + .clk = "rng_fck", + .user = OCP_USER_MPU, +}; + static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = { &am33xx_l3_main__emif, &am33xx_mpu__l3_main, @@ -2533,6 +2567,7 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = { &am33xx_cpgmac0__mdio, &am33xx_l3_main__sha0, &am33xx_l3_main__aes0, + &am33xx_l4_per__rng, NULL, };
Add RNG hwmod data for AM33xx SoC. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 35 ++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)