| Message ID | 1377885140-3529-1-git-send-email-mugunthanvnm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Aug 30, 2013, at 12:52 PM, Mugunthan V N wrote: > DT node's unit address should be its own register offset address to make it a > unique across the system. This patch corrects the incorrect USB entries with > correct register offset for unit address. > > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Cc: Felipe Balbi <balbi@ti.com> > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index f9c5da9..e9b6775 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -346,7 +346,7 @@ > ti,hwmods = "usb_otg_hs"; > status = "disabled"; > > - ctrl_mod: control@44e10000 { > + ctrl_mod: control@44e10620 { > compatible = "ti,am335x-usb-ctrl-module"; > reg = <0x44e10620 0x10 > 0x44e10648 0x4>; > @@ -449,7 +449,7 @@ > "tx14", "tx15"; > }; > > - cppi41dma: dma-controller@07402000 { > + cppi41dma: dma-controller@47402000 { Why isn't the unit address 47400000 ? > compatible = "ti,am3359-cppi41"; > reg = <0x47400000 0x1000 > 0x47402000 0x1000 > -- > 1.8.4 - k
On Saturday 31 August 2013 12:40 AM, Kumar Gala wrote: > On Aug 30, 2013, at 12:52 PM, Mugunthan V N wrote: > >> > DT node's unit address should be its own register offset address to make it a >> > unique across the system. This patch corrects the incorrect USB entries with >> > correct register offset for unit address. >> > >> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >> > Cc: Felipe Balbi <balbi@ti.com> >> > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> >> > --- >> > arch/arm/boot/dts/am33xx.dtsi | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> > index f9c5da9..e9b6775 100644 >> > --- a/arch/arm/boot/dts/am33xx.dtsi >> > +++ b/arch/arm/boot/dts/am33xx.dtsi >> > @@ -346,7 +346,7 @@ >> > ti,hwmods = "usb_otg_hs"; >> > status = "disabled"; >> > >> > - ctrl_mod: control@44e10000 { >> > + ctrl_mod: control@44e10620 { >> > compatible = "ti,am335x-usb-ctrl-module"; >> > reg = <0x44e10620 0x10 >> > 0x44e10648 0x4>; >> > @@ -449,7 +449,7 @@ >> > "tx14", "tx15"; >> > }; >> > >> > - cppi41dma: dma-controller@07402000 { >> > + cppi41dma: dma-controller@47402000 { > Why isn't the unit address 47400000 ? > The above address is a shared address between CPPI dma and USB sub system. It has to be shared because CPPI DMA has to access Glue layer of the USB sub system for accessing IRQ registers. So 47400000 is already used in USB SS so if it cannot be used for CPPI DT node. Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 08/30/2013 09:52 PM, Mugunthan V N wrote: > DT node's unit address should be its own register offset address to make it a > unique across the system. This patch corrects the incorrect USB entries with > correct register offset for unit address. > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Cc: Felipe Balbi <balbi@ti.com> > Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index f9c5da9..e9b6775 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi [...] > @@ -449,7 +449,7 @@ > "tx14", "tx15"; > }; > > - cppi41dma: dma-controller@07402000 { > + cppi41dma: dma-controller@47402000 { Not @47400000? Look at the first entry in the "reg" prop. > compatible = "ti,am3359-cppi41"; > reg = <0x47400000 0x1000 > 0x47402000 0x1000 WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Saturday 31 August 2013 11:12 PM, Sergei Shtylyov wrote: > Hello. > > On 08/30/2013 09:52 PM, Mugunthan V N wrote: > >> DT node's unit address should be its own register offset address to >> make it a >> unique across the system. This patch corrects the incorrect USB >> entries with >> correct register offset for unit address. > >> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >> Cc: Felipe Balbi <balbi@ti.com> >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> >> --- >> arch/arm/boot/dts/am33xx.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> diff --git a/arch/arm/boot/dts/am33xx.dtsi >> b/arch/arm/boot/dts/am33xx.dtsi >> index f9c5da9..e9b6775 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi > [...] >> @@ -449,7 +449,7 @@ >> "tx14", "tx15"; >> }; >> >> - cppi41dma: dma-controller@07402000 { >> + cppi41dma: dma-controller@47402000 { > > Not @47400000? Look at the first entry in the "reg" prop. 47400000 is already used in USB SS. See below from am33xx.dtsi file 340 usb: usb@47400000 { 341 compatible = "ti,am33xx-usb"; 342 reg = <0x47400000 0x1000>; 343 ranges; Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index f9c5da9..e9b6775 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -346,7 +346,7 @@ ti,hwmods = "usb_otg_hs"; status = "disabled"; - ctrl_mod: control@44e10000 { + ctrl_mod: control@44e10620 { compatible = "ti,am335x-usb-ctrl-module"; reg = <0x44e10620 0x10 0x44e10648 0x4>; @@ -449,7 +449,7 @@ "tx14", "tx15"; }; - cppi41dma: dma-controller@07402000 { + cppi41dma: dma-controller@47402000 { compatible = "ti,am3359-cppi41"; reg = <0x47400000 0x1000 0x47402000 0x1000
DT node's unit address should be its own register offset address to make it a unique across the system. This patch corrects the incorrect USB entries with correct register offset for unit address. Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: Felipe Balbi <balbi@ti.com> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)