| Message ID | 1378982427-5802-2-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mark, On Thursday 12 of September 2013 11:40:26 Mark Brown wrote: > From: Mark Brown <broonie@linaro.org> > > Rather than requiring each board to explicitly disable the SPI > controllers it is not using instead require boards to enable those that > they are using. This is less work overall since normally at most one of > the controllers is in use and avoids issues caused by inappropriate > pinmuxing. > > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 ++-------- > arch/arm/boot/dts/exynos5250.dtsi | 3 +++ > 2 files changed, 5 insertions(+), 8 deletions(-) I wonder if exynos5250-arndale shouldn't be also considered in this patch. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 12, 2013 at 01:56:44PM +0200, Tomasz Figa wrote:
> I wonder if exynos5250-arndale shouldn't be also considered in this patch.
There are no SPI devices on that board (at least not ones that are
currently instantiated by the DT).
On Thursday 12 of September 2013 14:50:28 Mark Brown wrote: > On Thu, Sep 12, 2013 at 01:56:44PM +0200, Tomasz Figa wrote: > > I wonder if exynos5250-arndale shouldn't be also considered in this > > patch. > There are no SPI devices on that board (at least not ones that are > currently instantiated by the DT). I can see a bunch of nodes simply adding status = "disabled" in dts of arndale. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 12, 2013 at 05:51:58PM +0200, Tomasz Figa wrote: > On Thursday 12 of September 2013 14:50:28 Mark Brown wrote: > > There are no SPI devices on that board (at least not ones that are > > currently instantiated by the DT). > I can see a bunch of nodes simply adding status = "disabled" in dts of > arndale. Meh, gone now.
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index f86d567..67d3c43 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -184,11 +184,9 @@ status = "disabled"; }; - spi_0: spi@12d20000 { - status = "disabled"; - }; - spi_1: spi@12d30000 { + status = "okay"; + w25q80bw@0 { #address-cells = <1>; #size-cells = <1>; @@ -214,10 +212,6 @@ }; }; - spi_2: spi@12d40000 { - status = "disabled"; - }; - hdmi { hpd-gpio = <&gpx3 7 0>; }; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index c863113..a886ee4 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -344,6 +344,7 @@ spi_0: spi@12d20000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d20000 0x100>; interrupts = <0 66 0>; dmas = <&pdma0 5 @@ -359,6 +360,7 @@ spi_1: spi@12d30000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d30000 0x100>; interrupts = <0 67 0>; dmas = <&pdma1 5 @@ -374,6 +376,7 @@ spi_2: spi@12d40000 { compatible = "samsung,exynos4210-spi"; + status = "disabled"; reg = <0x12d40000 0x100>; interrupts = <0 68 0>; dmas = <&pdma0 7