| Message ID | 1379596148-32520-1-git-send-email-maddy@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 19, 2013 at 06:39:08PM +0530, Madhavan Srinivasan wrote: (Git folks, please read on.) > Commit 3b29aa5ba204c created a symlink file in include/dt-bindings. > Even though commit diff is fine, symlink is invalid. > ls -lb shows a newline character at the end of the filename. > > lrwxrwxrwx 1 maddy maddy 35 Sep 19 18:11 dt-bindings -> > ../../../../../include/dt-bindings\n > > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> > --- > arch/mips/boot/dts/include/dt-bindings | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/include/dt-bindings b/arch/mips/boot/dts/include/dt-bindings > index 68ae388..08c00e4 120000 > --- a/arch/mips/boot/dts/include/dt-bindings > +++ b/arch/mips/boot/dts/include/dt-bindings > @@ -1 +1 @@ > -../../../../../include/dt-bindings > +../../../../../include/dt-bindings > \ No newline at end of file > -- > 1.7.10.4 I applied your patch - but now git-show shows it as an empty commit and ls -lb arch/mips/boot/dts/include/dt-bindings still shows the \n at the end of the link target. Things are looking ok now that I manually fixed the link and commited the result. I hope git-push and git-pull are going to handle this correct. So, I wonder if this is a git bug. The original patch that introduced the symlink with the \n is kernel commit 3b29aa5ba204c62b3ec8f9f5b1ebd6e5d74f75d3 and is archived in patchwork at http://patchwork.linux-mips.org/patch/5745/ The patch file contains a \n at the end - but one would expect that from a patch file that has been transfered via email, so I'm not sure how this is supposed to work with emailed patches?!? Anyway, I'm not too fond of sylinks in the tree or in patches and I'm wondering if we could get rid of them for something more bullet proof. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 09/19/2013 05:09 PM, Madhavan Srinivasan wrote: > Commit 3b29aa5ba204c created a symlink file in include/dt-bindings. Please also specify that commit's summary line in parens. > Even though commit diff is fine, symlink is invalid. > ls -lb shows a newline character at the end of the filename. Don't indent the changelog please. > lrwxrwxrwx 1 maddy maddy 35 Sep 19 18:11 dt-bindings -> > ../../../../../include/dt-bindings\n > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Ralf Baechle <ralf@linux-mips.org> writes: >> diff --git a/arch/mips/boot/dts/include/dt-bindings b/arch/mips/boot/dts/include/dt-bindings >> index 68ae388..08c00e4 120000 >> --- a/arch/mips/boot/dts/include/dt-bindings >> +++ b/arch/mips/boot/dts/include/dt-bindings >> @@ -1 +1 @@ >> -../../../../../include/dt-bindings >> +../../../../../include/dt-bindings >> \ No newline at end of file >> -- >> 1.7.10.4 > > I applied your patch - but now git-show shows it as an empty commit and > > ls -lb arch/mips/boot/dts/include/dt-bindings > > still shows the \n at the end of the link target. > ... > So, I wonder if this is a git bug. Sounds as if "git am" is losing the important bit of information that new content ends with an incomplete line. However, it does not reproduce for me. $ rm -fr /var/tmp/x && mkdir /var/tmp/x && cd /var/tmp/x $ git init $ ln -s 'a ' b $ git add b $ git commit -m initial $ ln -f -s a b $ git add b $ git commit -m fix $ git format-patch -1 $ git checkout HEAD^ $ git am 0001-* $ git diff HEAD^ HEAD diff --git a/b b/b index 7898192..2e65efe 120000 --- a/b +++ b/b @@ -1 +1 @@ -a +a \ No newline at end of file I see the same with v1.7.10 (which may not match your version; v1.7.10.4 is what was used by the patch submitter to prepare the patch, and you did not say how you are applying the patches in your message) and with more recent Git. There is no such breakage. I briefly suspected that you might be passing "--whitespace=fix" to "am" and that may be incorrectly "fixing" the incomplete line, but that is not the case. I get the same result if I add the option to "am" in the above transcript. How are you applying the patch? What is your Git version? -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/mips/boot/dts/include/dt-bindings b/arch/mips/boot/dts/include/dt-bindings index 68ae388..08c00e4 120000 --- a/arch/mips/boot/dts/include/dt-bindings +++ b/arch/mips/boot/dts/include/dt-bindings @@ -1 +1 @@ -../../../../../include/dt-bindings +../../../../../include/dt-bindings
Commit 3b29aa5ba204c created a symlink file in include/dt-bindings. Even though commit diff is fine, symlink is invalid. ls -lb shows a newline character at the end of the filename. lrwxrwxrwx 1 maddy maddy 35 Sep 19 18:11 dt-bindings -> ../../../../../include/dt-bindings\n Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> --- arch/mips/boot/dts/include/dt-bindings | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) \ No newline at end of file