| Message ID | 1378907462-19247-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Sep 11, 2013 at 3:51 PM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up > gpio-ranges documentation") deprecated the #gpio-range-cells property. > Replace its usage with a hardcoded value in the gpio-rcar driver. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Simon please take the whole set into the SH tree. Yours, Linus Walleij
On Fri, Sep 20, 2013 at 08:36:57PM +0200, Linus Walleij wrote: > On Wed, Sep 11, 2013 at 3:51 PM, Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > > Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up > > gpio-ranges documentation") deprecated the #gpio-range-cells property. > > Replace its usage with a hardcoded value in the gpio-rcar driver. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Simon please take the whole set into the SH tree. Thanks, will do.
Hi Simon, On Friday 20 September 2013 12:06:14 Simon Horman wrote: > On Fri, Sep 20, 2013 at 08:36:57PM +0200, Linus Walleij wrote: > > On Wed, Sep 11, 2013 at 3:51 PM, Laurent Pinchart > > > > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > > Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up > > > gpio-ranges documentation") deprecated the #gpio-range-cells property. > > > Replace its usage with a hardcoded value in the gpio-rcar driver. > > > > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > Simon please take the whole set into the SH tree. > > Thanks, will do. Just a quick reminder that the two patches are v3.12 fixes. Would you like me to send you a pull request ?
On Fri, Sep 20, 2013 at 09:57:44PM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Friday 20 September 2013 12:06:14 Simon Horman wrote: > > On Fri, Sep 20, 2013 at 08:36:57PM +0200, Linus Walleij wrote: > > > On Wed, Sep 11, 2013 at 3:51 PM, Laurent Pinchart > > > > > > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > > > Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up > > > > gpio-ranges documentation") deprecated the #gpio-range-cells property. > > > > Replace its usage with a hardcoded value in the gpio-rcar driver. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > > > Simon please take the whole set into the SH tree. > > > > Thanks, will do. > > Just a quick reminder that the two patches are v3.12 fixes. Would you like me > to send you a pull request ? Thanks, that would be very helpful.
On Sun, Sep 22, 2013 at 09:04:48PM +0900, Simon Horman wrote: > On Fri, Sep 20, 2013 at 09:57:44PM +0200, Laurent Pinchart wrote: > > Hi Simon, > > > > On Friday 20 September 2013 12:06:14 Simon Horman wrote: > > > On Fri, Sep 20, 2013 at 08:36:57PM +0200, Linus Walleij wrote: > > > > On Wed, Sep 11, 2013 at 3:51 PM, Laurent Pinchart > > > > > > > > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > > > > Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up > > > > > gpio-ranges documentation") deprecated the #gpio-range-cells property. > > > > > Replace its usage with a hardcoded value in the gpio-rcar driver. > > > > > > > > > > Signed-off-by: Laurent Pinchart > > > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > > > > > Simon please take the whole set into the SH tree. > > > > > > Thanks, will do. > > > > Just a quick reminder that the two patches are v3.12 fixes. Would you like me > > to send you a pull request ? > > Thanks, that would be very helpful. Actually, scratch that. I have the patches and I will queue them up.
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index e3745eb..6038966 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -293,10 +293,9 @@ static void gpio_rcar_parse_pdata(struct gpio_rcar_priv *p) if (pdata) { p->config = *pdata; } else if (IS_ENABLED(CONFIG_OF) && np) { - ret = of_parse_phandle_with_args(np, "gpio-ranges", - "#gpio-range-cells", 0, &args); - p->config.number_of_pins = ret == 0 && args.args_count == 3 - ? args.args[2] + ret = of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, + &args); + p->config.number_of_pins = ret == 0 ? args.args[2] : RCAR_MAX_GPIO_PER_BANK; p->config.gpio_base = -1; }
Commit a1bc260bb5f5d95da854be7898202d788e94448d ("gpio: clean up gpio-ranges documentation") deprecated the #gpio-range-cells property. Replace its usage with a hardcoded value in the gpio-rcar driver. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/gpio/gpio-rcar.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)