| Message ID | 20130921120036.5730dbfd@armhf (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Sep 21, 2013 at 12:00:36PM +0200, Jean-Francois Moine wrote: > At probe time, when the clock driver is not yet initialized, the > external clock of the kirkwood sound device will not be usable. > > This patch fixes this problem defering the device probe. Applied, thanks. It won't do anything without a version of patch 1 but there's no build time dependency and it seems like we should get a fix into the core for the unspecified vs unregistered problem.
diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c index 0f3d73d..14f32d9 100644 --- a/sound/soc/kirkwood/kirkwood-i2s.c +++ b/sound/soc/kirkwood/kirkwood-i2s.c @@ -496,7 +496,10 @@ static int kirkwood_i2s_dev_probe(struct platform_device *pdev) return err; priv->extclk = devm_clk_get(&pdev->dev, "extclk"); - if (!IS_ERR(priv->extclk)) { + if (IS_ERR(priv->extclk)) { + if (PTR_ERR(priv->extclk) == -EPROBE_DEFER) + return -EPROBE_DEFER; + } else { if (priv->extclk == priv->clk) { devm_clk_put(&pdev->dev, priv->extclk); priv->extclk = ERR_PTR(-EINVAL);
At probe time, when the clock driver is not yet initialized, the external clock of the kirkwood sound device will not be usable. This patch fixes this problem defering the device probe. Signed-off-by: Jean-Francois Moine <moinejf@free.fr> --- sound/soc/kirkwood/kirkwood-i2s.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)