| Message ID | 87li2mr4dw.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Morimoto-san, Thank you for the patch. On Tuesday 24 September 2013 01:49:19 Kuninori Morimoto wrote: > afa2c9407f8908e2269b243773cbb0997c553804 > (sh: ecovec24: Use MMC/SDHI CD and RO GPIO) > added .tmio_flags = TMIO_MMC_USE_GPIO_CD > on sh_mobile_sdhi_info, but it needs > <linux/mfd/tmio.h> header. > This patch adds it > > Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Simon, Paul, Magnus > > This patch is for SH, but Paul can pick up it ? > Or Simon can ? I'm not sure... > > Laurent > > Can you check this patch ? > > arch/sh/boards/mach-ecovec24/setup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/boards/mach-ecovec24/setup.c > b/arch/sh/boards/mach-ecovec24/setup.c index 1fa8be4..122f737 100644 > --- a/arch/sh/boards/mach-ecovec24/setup.c > +++ b/arch/sh/boards/mach-ecovec24/setup.c > @@ -15,6 +15,7 @@ > #include <linux/mmc/sh_mmcif.h> > #include <linux/mmc/sh_mobile_sdhi.h> > #include <linux/mtd/physmap.h> > +#include <linux/mfd/tmio.h> > #include <linux/gpio.h> > #include <linux/interrupt.h> > #include <linux/io.h>
[ Cc Chris Ball ] On Tue, Sep 24, 2013 at 01:49:19AM -0700, Kuninori Morimoto wrote: > afa2c9407f8908e2269b243773cbb0997c553804 > (sh: ecovec24: Use MMC/SDHI CD and RO GPIO) > added .tmio_flags = TMIO_MMC_USE_GPIO_CD > on sh_mobile_sdhi_info, but it needs > <linux/mfd/tmio.h> header. > This patch adds it > > Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > Simon, Paul, Magnus > > This patch is for SH, but Paul can pick up it ? > Or Simon can ? I'm not sure... I don't believe Paul is actively working on this code at this time. While I am happy to pick this up I don't have an obvious avenue to push it upstream. Chris has previously taken MMCIF/SDHI related patches to this file (and only this file) through his tree. Chris, would you consider taking this one once it has been reviewed? > > Laurent > > Can you check this patch ? > > arch/sh/boards/mach-ecovec24/setup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c > index 1fa8be4..122f737 100644 > --- a/arch/sh/boards/mach-ecovec24/setup.c > +++ b/arch/sh/boards/mach-ecovec24/setup.c > @@ -15,6 +15,7 @@ > #include <linux/mmc/sh_mmcif.h> > #include <linux/mmc/sh_mobile_sdhi.h> > #include <linux/mtd/physmap.h> > +#include <linux/mfd/tmio.h> > #include <linux/gpio.h> > #include <linux/interrupt.h> > #include <linux/io.h> > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Sep 25 2013, Simon Horman wrote: > [ Cc Chris Ball ] > > On Tue, Sep 24, 2013 at 01:49:19AM -0700, Kuninori Morimoto wrote: >> afa2c9407f8908e2269b243773cbb0997c553804 >> (sh: ecovec24: Use MMC/SDHI CD and RO GPIO) >> added .tmio_flags = TMIO_MMC_USE_GPIO_CD >> on sh_mobile_sdhi_info, but it needs >> <linux/mfd/tmio.h> header. >> This patch adds it >> >> Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> --- >> Simon, Paul, Magnus >> >> This patch is for SH, but Paul can pick up it ? >> Or Simon can ? I'm not sure... > > I don't believe Paul is actively working on this code at this time. > While I am happy to pick this up I don't have an obvious > avenue to push it upstream. > > Chris has previously taken MMCIF/SDHI related patches to this file > (and only this file) through his tree. Chris, would you consider > taking this one once it has been reviewed? Looks like I (via mmc-next) am responsible for merging the commit that broke it, so I'm happy to merge the fix with an ACK. Thanks. - Chris.
On Wed, Sep 25, 2013 at 01:59:22AM +0100, Chris Ball wrote: > Hi, > > On Wed, Sep 25 2013, Simon Horman wrote: > > [ Cc Chris Ball ] > > > > On Tue, Sep 24, 2013 at 01:49:19AM -0700, Kuninori Morimoto wrote: > >> afa2c9407f8908e2269b243773cbb0997c553804 > >> (sh: ecovec24: Use MMC/SDHI CD and RO GPIO) > >> added .tmio_flags = TMIO_MMC_USE_GPIO_CD > >> on sh_mobile_sdhi_info, but it needs > >> <linux/mfd/tmio.h> header. > >> This patch adds it > >> > >> Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> --- > >> Simon, Paul, Magnus > >> > >> This patch is for SH, but Paul can pick up it ? > >> Or Simon can ? I'm not sure... > > > > I don't believe Paul is actively working on this code at this time. > > While I am happy to pick this up I don't have an obvious > > avenue to push it upstream. > > > > Chris has previously taken MMCIF/SDHI related patches to this file > > (and only this file) through his tree. Chris, would you consider > > taking this one once it has been reviewed? > > Looks like I (via mmc-next) am responsible for merging the commit > that broke it, so I'm happy to merge the fix with an ACK. Thanks. Thanks. Morimoto-san. Please re-send this patch with Laurent's Ack to Chris with the original recipients Cced. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c index 1fa8be4..122f737 100644 --- a/arch/sh/boards/mach-ecovec24/setup.c +++ b/arch/sh/boards/mach-ecovec24/setup.c @@ -15,6 +15,7 @@ #include <linux/mmc/sh_mmcif.h> #include <linux/mmc/sh_mobile_sdhi.h> #include <linux/mtd/physmap.h> +#include <linux/mfd/tmio.h> #include <linux/gpio.h> #include <linux/interrupt.h> #include <linux/io.h>
afa2c9407f8908e2269b243773cbb0997c553804 (sh: ecovec24: Use MMC/SDHI CD and RO GPIO) added .tmio_flags = TMIO_MMC_USE_GPIO_CD on sh_mobile_sdhi_info, but it needs <linux/mfd/tmio.h> header. This patch adds it Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- Simon, Paul, Magnus This patch is for SH, but Paul can pick up it ? Or Simon can ? I'm not sure... Laurent Can you check this patch ? arch/sh/boards/mach-ecovec24/setup.c | 1 + 1 file changed, 1 insertion(+)