| Message ID | 1380325356-2100-4-git-send-email-santosh.shilimkar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 27, 2013 at 07:42:35PM -0400, Santosh Shilimkar wrote: > DaVinci SPI IP works without EDMA support and thats how it has > been used on Keystone SOCs currently. Hence keep the EDMA select > limited to ARCH_DAVINCI so that Keystone SOCs can use the driver. > Keystone SOC do support EDMA IP as well but the support has > not been added and tested so far. If there's no hard dependency on EDMA then the driver probably ought to be marked as COMPILE_TEST so that it can be build tested on other systems. Is that possible?
On Sunday 29 September 2013 08:31 AM, Mark Brown wrote: > On Fri, Sep 27, 2013 at 07:42:35PM -0400, Santosh Shilimkar wrote: > >> DaVinci SPI IP works without EDMA support and thats how it has >> been used on Keystone SOCs currently. Hence keep the EDMA select >> limited to ARCH_DAVINCI so that Keystone SOCs can use the driver. > >> Keystone SOC do support EDMA IP as well but the support has >> not been added and tested so far. > > If there's no hard dependency on EDMA then the driver probably ought to > be marked as COMPILE_TEST so that it can be build tested on other > systems. Is that possible? > EDMA is already getting tested for DAVINCI builds and there are patches coming AMXXXX SOC support. So probably marking it COMPILE_TEST isn't needed since it has been in use already for other SOCs. Regards, Santosh
On Mon, Sep 30, 2013 at 09:36:23AM -0400, Santosh Shilimkar wrote: > On Sunday 29 September 2013 08:31 AM, Mark Brown wrote: > > If there's no hard dependency on EDMA then the driver probably ought to > > be marked as COMPILE_TEST so that it can be build tested on other > > systems. Is that possible? > EDMA is already getting tested for DAVINCI builds and there are patches > coming AMXXXX SOC support. So probably marking it COMPILE_TEST isn't > needed since it has been in use already for other SOCs. It'd make life easier for general subsystem development if we were able to get build coverage without having to build a specific config, even if it's never actually going to be run.
On Monday 30 September 2013 10:38 AM, Mark Brown wrote: > On Mon, Sep 30, 2013 at 09:36:23AM -0400, Santosh Shilimkar wrote: >> On Sunday 29 September 2013 08:31 AM, Mark Brown wrote: > >>> If there's no hard dependency on EDMA then the driver probably ought to >>> be marked as COMPILE_TEST so that it can be build tested on other >>> systems. Is that possible? > >> EDMA is already getting tested for DAVINCI builds and there are patches >> coming AMXXXX SOC support. So probably marking it COMPILE_TEST isn't >> needed since it has been in use already for other SOCs. > > It'd make life easier for general subsystem development if we were able > to get build coverage without having to build a specific config, even if > it's never actually going to be run. > So after your comments, I actually checked whether the driver works with EDMA enabled but no EDMA node/data information from DT for SPI driver. It seems to work. So I am going to drop this patch and rather allow the EDMA to be built for Keystone SOCs as well. Not sure why I didn't looked at this as an option first place. Thanks for your comments Mark. Regards, Santosh
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b9c53cc..514d883 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -159,7 +159,7 @@ config SPI_DAVINCI tristate "Texas Instruments DaVinci/DA8x/OMAP-L/AM1x SoC SPI controller" depends on ARCH_DAVINCI || ARCH_KEYSTONE select SPI_BITBANG - select TI_EDMA + select TI_EDMA if ARCH_DAVINCI help SPI master controller for DaVinci/DA8x/OMAP-L/AM1x SPI modules.
DaVinci SPI IP works without EDMA support and thats how it has been used on Keystone SOCs currently. Hence keep the EDMA select limited to ARCH_DAVINCI so that Keystone SOCs can use the driver. Keystone SOC do support EDMA IP as well but the support has not been added and tested so far. Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- Mark, If you are ok with this trivial change, I will need your ack to carry the patch via arm-soc tree. Without this patch, enabling SPI throws unmet dependency warnings and last patch in the series enables the SPI support. drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)