| Message ID | 20130930140555.GA3668@calypso.mtr.labs.mlnx (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Hal Rosenstock |
| Headers | show |
On 9/30/2013 10:05 AM, Alex Netes wrote: > osm_req_set parameters order is incorrect. Because of this only block 0 > is incorrectly altered. > > Signed-off-by: Alex Netes <alexne@mellanox.com> Nice catch! Thanks. Applied. -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/opensm/osm_guid_mgr.c b/opensm/osm_guid_mgr.c index d826366..e4d1de7 100644 --- a/opensm/osm_guid_mgr.c +++ b/opensm/osm_guid_mgr.c @@ -73,10 +73,9 @@ static void guidinfo_set(IN osm_sa_t *sa, IN osm_port_t *p_port, status = osm_req_set(sa->sm, osm_physp_get_dr_path_ptr(p_port->p_physp), payload, sizeof(payload), IB_MAD_ATTR_GUID_INFO, - FALSE, + cl_hton32((uint32_t)block_num), FALSE, ib_port_info_get_m_key(&p_port->p_physp->port_info), - cl_hton32((uint32_t)block_num), - CL_DISP_MSGID_NONE, &context); + CL_DISP_MSGID_NONE, &context); if (status != IB_SUCCESS) OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 5109: " "Failure initiating GUIDInfo request (%s)\n",
osm_req_set parameters order is incorrect. Because of this only block 0 is incorrectly altered. Signed-off-by: Alex Netes <alexne@mellanox.com> --- opensm/osm_guid_mgr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)