diff mbox

arm: socfpga: Fix incorrect sdmmc clock name

Message ID 1376322134-17408-1-git-send-email-dinguyen@altera.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dinh Nguyen Aug. 12, 2013, 3:42 p.m. UTC 
From: Dinh Nguyen <dinguyen@altera.com>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Mike Turquette <mturquette@linaro.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Olof Johansson <olof@lixom.net>
Cc: Pavel Machek <pavel@denx.de>
Cc: linux-arm-kernel@lists.infradead.org
---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Olof Johansson Aug. 14, 2013, 5:48 a.m. UTC | #1 
On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Olof Johansson <olof@lixom.net>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: linux-arm-kernel@lists.infradead.org

Hi Dinh,

Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
on what the impact here is? mmc doesn't come up at all, or something more
subtle?


-Olof
Dinh Nguyen Aug. 14, 2013, 2:57 p.m. UTC | #2 
On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> > 
> > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > 
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Olof Johansson <olof@lixom.net>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: linux-arm-kernel@lists.infradead.org
> 
> Hi Dinh,
> 
> Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> on what the impact here is? mmc doesn't come up at all, or something more
> subtle?

Hi Olof,

No, this is go into 3.12 as I am still working on the bindings for
SD/MMC.

The oneliner: "The SD/MMC driver was intermittently not coming up
because it was not able to get the correct clock."

Thanks,
Dinh
> 
> 
> -Olof
>
Mike Turquette Oct. 7, 2013, 8:12 p.m. UTC | #3 
Quoting Dinh Nguyen (2013-08-14 07:57:54)
> On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > > 
> > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > > 
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Mike Turquette <mturquette@linaro.org>
> > > CC: Arnd Bergmann <arnd@arndb.de>
> > > CC: Olof Johansson <olof@lixom.net>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > 
> > Hi Dinh,
> > 
> > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > on what the impact here is? mmc doesn't come up at all, or something more
> > subtle?
> 
> Hi Olof,
> 
> No, this is go into 3.12 as I am still working on the bindings for
> SD/MMC.
> 
> The oneliner: "The SD/MMC driver was intermittently not coming up
> because it was not able to get the correct clock."

Olof, did you take this? If not I'll put it into my next batch of fixes
for 3.12.

Regards,
Mike

> 
> Thanks,
> Dinh
> > 
> > 
> > -Olof
> >
Dinh Nguyen Oct. 7, 2013, 8:37 p.m. UTC | #4 
Hi Mike,

On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> Quoting Dinh Nguyen (2013-08-14 07:57:54)
> > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > 
> > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > > > 
> > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > Cc: Mike Turquette <mturquette@linaro.org>
> > > > CC: Arnd Bergmann <arnd@arndb.de>
> > > > CC: Olof Johansson <olof@lixom.net>
> > > > Cc: Pavel Machek <pavel@denx.de>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > 
> > > Hi Dinh,
> > > 
> > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > > on what the impact here is? mmc doesn't come up at all, or something more
> > > subtle?
> > 
> > Hi Olof,
> > 
> > No, this is go into 3.12 as I am still working on the bindings for
> > SD/MMC.
> > 
> > The oneliner: "The SD/MMC driver was intermittently not coming up
> > because it was not able to get the correct clock."
> 
> Olof, did you take this? If not I'll put it into my next batch of fixes
> for 3.12.

No, Olof did not get a chance to pick this up for 3.12. I resent the
patch with the updated commit message for 3.13:

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks,
Dinh
> 
> Regards,
> Mike
> 
> > 
> > Thanks,
> > Dinh
> > > 
> > > 
> > > -Olof
> > >
>
Mike Turquette Oct. 7, 2013, 11:28 p.m. UTC | #5 
Quoting Dinh Nguyen (2013-10-07 13:37:29)
> Hi Mike,
> 
> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> > > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > > 
> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > > > > 
> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > > Cc: Mike Turquette <mturquette@linaro.org>
> > > > > CC: Arnd Bergmann <arnd@arndb.de>
> > > > > CC: Olof Johansson <olof@lixom.net>
> > > > > Cc: Pavel Machek <pavel@denx.de>
> > > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > 
> > > > Hi Dinh,
> > > > 
> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > > > on what the impact here is? mmc doesn't come up at all, or something more
> > > > subtle?
> > > 
> > > Hi Olof,
> > > 
> > > No, this is go into 3.12 as I am still working on the bindings for
> > > SD/MMC.
> > > 
> > > The oneliner: "The SD/MMC driver was intermittently not coming up
> > > because it was not able to get the correct clock."
> > 
> > Olof, did you take this? If not I'll put it into my next batch of fixes
> > for 3.12.
> 
> No, Olof did not get a chance to pick this up for 3.12. I resent the
> patch with the updated commit message for 3.13:
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks for the link. I've taken that version into clk-fixes for 3.12.

Regards,
Mike

> 
> Thanks,
> Dinh
> > 
> > Regards,
> > Mike
> > 
> > > 
> > > Thanks,
> > > Dinh
> > > > 
> > > > 
> > > > -Olof
> > > >
> >
Olof Johansson Oct. 7, 2013, 11:43 p.m. UTC | #6 
On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
> Quoting Dinh Nguyen (2013-10-07 13:37:29)
>> Hi Mike,
>>
>> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
>> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
>> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
>> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
>> > > > > From: Dinh Nguyen <dinguyen@altera.com>
>> > > > >
>> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>> > > > >
>> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> > > > > Cc: Mike Turquette <mturquette@linaro.org>
>> > > > > CC: Arnd Bergmann <arnd@arndb.de>
>> > > > > CC: Olof Johansson <olof@lixom.net>
>> > > > > Cc: Pavel Machek <pavel@denx.de>
>> > > > > Cc: linux-arm-kernel@lists.infradead.org
>> > > >
>> > > > Hi Dinh,
>> > > >
>> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
>> > > > on what the impact here is? mmc doesn't come up at all, or something more
>> > > > subtle?
>> > >
>> > > Hi Olof,
>> > >
>> > > No, this is go into 3.12 as I am still working on the bindings for
>> > > SD/MMC.
>> > >
>> > > The oneliner: "The SD/MMC driver was intermittently not coming up
>> > > because it was not able to get the correct clock."
>> >
>> > Olof, did you take this? If not I'll put it into my next batch of fixes
>> > for 3.12.
>>
>> No, Olof did not get a chance to pick this up for 3.12. I resent the
>> patch with the updated commit message for 3.13:
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
>
> Thanks for the link. I've taken that version into clk-fixes for 3.12.


Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
to remind me if it happens. A week is the normal grace period. :)


-Olof
Mike Turquette Oct. 8, 2013, 1:39 a.m. UTC | #7 
Quoting Olof Johansson (2013-10-07 16:43:14)
> On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
> > Quoting Dinh Nguyen (2013-10-07 13:37:29)
> >> Hi Mike,
> >>
> >> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> >> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
> >> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> >> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
> >> > > > > From: Dinh Nguyen <dinguyen@altera.com>
> >> > > > >
> >> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> >> > > > >
> >> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> >> > > > > Cc: Mike Turquette <mturquette@linaro.org>
> >> > > > > CC: Arnd Bergmann <arnd@arndb.de>
> >> > > > > CC: Olof Johansson <olof@lixom.net>
> >> > > > > Cc: Pavel Machek <pavel@denx.de>
> >> > > > > Cc: linux-arm-kernel@lists.infradead.org
> >> > > >
> >> > > > Hi Dinh,
> >> > > >
> >> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> >> > > > on what the impact here is? mmc doesn't come up at all, or something more
> >> > > > subtle?
> >> > >
> >> > > Hi Olof,
> >> > >
> >> > > No, this is go into 3.12 as I am still working on the bindings for
> >> > > SD/MMC.
> >> > >
> >> > > The oneliner: "The SD/MMC driver was intermittently not coming up
> >> > > because it was not able to get the correct clock."
> >> >
> >> > Olof, did you take this? If not I'll put it into my next batch of fixes
> >> > for 3.12.
> >>
> >> No, Olof did not get a chance to pick this up for 3.12. I resent the
> >> patch with the updated commit message for 3.13:
> >>
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
> >
> > Thanks for the link. I've taken that version into clk-fixes for 3.12.
> 
> 
> Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
> to remind me if it happens. A week is the normal grace period. :)

No problem ;-)

Dinh,

I changed your $SUBJECT line to:

"clk: socfpga: Fix incorrect sdmmc clock name"

Just a simple s/arm/clk/

Regards,
Mike

> 
> 
> -Olof
Dinh Nguyen Oct. 8, 2013, 2:40 a.m. UTC | #8 
On 10/7/13 8:39 PM, Mike Turquette wrote:
> Quoting Olof Johansson (2013-10-07 16:43:14)
>> On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
>>> Quoting Dinh Nguyen (2013-10-07 13:37:29)
>>>> Hi Mike,
>>>>
>>>> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
>>>>> Quoting Dinh Nguyen (2013-08-14 07:57:54)
>>>>>> On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
>>>>>>> On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen@altera.com wrote:
>>>>>>>> From: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>>
>>>>>>>> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>>>>>>>>
>>>>>>>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>> Cc: Mike Turquette <mturquette@linaro.org>
>>>>>>>> CC: Arnd Bergmann <arnd@arndb.de>
>>>>>>>> CC: Olof Johansson <olof@lixom.net>
>>>>>>>> Cc: Pavel Machek <pavel@denx.de>
>>>>>>>> Cc: linux-arm-kernel@lists.infradead.org
>>>>>>> Hi Dinh,
>>>>>>>
>>>>>>> Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
>>>>>>> on what the impact here is? mmc doesn't come up at all, or something more
>>>>>>> subtle?
>>>>>> Hi Olof,
>>>>>>
>>>>>> No, this is go into 3.12 as I am still working on the bindings for
>>>>>> SD/MMC.
>>>>>>
>>>>>> The oneliner: "The SD/MMC driver was intermittently not coming up
>>>>>> because it was not able to get the correct clock."
>>>>> Olof, did you take this? If not I'll put it into my next batch of fixes
>>>>> for 3.12.
>>>> No, Olof did not get a chance to pick this up for 3.12. I resent the
>>>> patch with the updated commit message for 3.13:
>>>>
>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
>>> Thanks for the link. I've taken that version into clk-fixes for 3.12.
>>
>> Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
>> to remind me if it happens. A week is the normal grace period. :)
No problem Olof! The patches to enable SDMMC is still floating out there 
so there wasn't a huge
hurry for 3.12.

Any chance you might take a look? I'll ping Chris Ball again tomorrow.

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks...
> No problem ;-)
>
> Dinh,
>
> I changed your $SUBJECT line to:
>
> "clk: socfpga: Fix incorrect sdmmc clock name"
>
> Just a simple s/arm/clk/
Thanks Mike!

Dinh
>
> Regards,
> Mike
>
>>
>> -Olof
diff mbox

Patch

diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
index 5bb848c..81dd31a 100644
--- a/drivers/clk/socfpga/clk.c
+++ b/drivers/clk/socfpga/clk.c
@@ -49,7 +49,7 @@ 
 #define SOCFPGA_L4_SP_CLK		"l4_sp_clk"
 #define SOCFPGA_NAND_CLK		"nand_clk"
 #define SOCFPGA_NAND_X_CLK		"nand_x_clk"
-#define SOCFPGA_MMC_CLK			"mmc_clk"
+#define SOCFPGA_MMC_CLK			"sdmmc_clk"
 #define SOCFPGA_DB_CLK			"gpio_db_clk"
 
 #define div_mask(width)	((1 << (width)) - 1)