| Message ID | 1381152493-28055-2-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/07/2013 03:28 PM, Roger Quadros wrote: > The generic PHY framewrok expects different properties than the > old USB PHY framework. Supply those properties. > > Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was > merged in greg/usb-next. [1] Would it be much pain (and do we want this at all) to add a fallback into the kernel or at least a printk pointing out to update the .dts for two releases or so? So the user does not need to spent hours to figure out why it suddenly stopped working. Sebastian
On 10/07/2013 04:40 PM, Sebastian Andrzej Siewior wrote: > On 10/07/2013 03:28 PM, Roger Quadros wrote: >> The generic PHY framewrok expects different properties than the >> old USB PHY framework. Supply those properties. >> >> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was >> merged in greg/usb-next. [1] > > Would it be much pain (and do we want this at all) to add a fallback > into the kernel or at least a printk pointing out to update the .dts > for two releases or so? So the user does not need to spent hours to > figure out why it suddenly stopped working. > I agree with you. Also, figuring out which kernel configs to enable for USB OTG to work on OMAP is a pain in itself to the user. cheers, -roger
On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: > The generic PHY framewrok expects different properties than the > old USB PHY framework. Supply those properties. > > Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was > merged in greg/usb-next. [1] > > [1] - https://lkml.org/lkml/2013/9/27/581 > > Signed-off-by: Roger Quadros <rogerq@ti.com> Acked-by: Felipe Balbi <balbi@ti.com>
Hi Benoit, On 10/10/2013 06:34 PM, Felipe Balbi wrote: > On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: >> The generic PHY framewrok expects different properties than the >> old USB PHY framework. Supply those properties. >> >> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was >> merged in greg/usb-next. [1] >> >> [1] - https://lkml.org/lkml/2013/9/27/581 >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> > > Acked-by: Felipe Balbi <balbi@ti.com> > Could you please pick this one for 3.13? Thanks. I don't see it in your 3.13 take 2 pull request. cheers, -roger
Hi Roger, On 14/10/2013 11:20, Roger Quadros wrote: > Hi Benoit, > > On 10/10/2013 06:34 PM, Felipe Balbi wrote: >> On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: >>> The generic PHY framewrok expects different properties than the >>> old USB PHY framework. Supply those properties. >>> >>> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was >>> merged in greg/usb-next. [1] >>> >>> [1] - https://lkml.org/lkml/2013/9/27/581 >>> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >> >> Acked-by: Felipe Balbi <balbi@ti.com> >> > > Could you please pick this one for 3.13? Thanks. > > I don't see it in your 3.13 take 2 pull request. It was not in it. I've just applied it. Thanks Benoit
diff --git a/arch/arm/boot/dts/omap3-gta04.dts b/arch/arm/boot/dts/omap3-gta04.dts index a84684a..b9b55c9 100644 --- a/arch/arm/boot/dts/omap3-gta04.dts +++ b/arch/arm/boot/dts/omap3-gta04.dts @@ -131,6 +131,8 @@ &usb_otg_hs { interface-type = <0>; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; mode = <3>; power = <50>; }; diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index d64fa04..e13b697 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -87,6 +87,8 @@ &usb_otg_hs { interface-type = <0>; usb-phy = <&usb2_phy>; + phys = <&usb2_phy>; + phy-names = "usb2-phy"; mode = <2>; power = <50>; };
The generic PHY framewrok expects different properties than the old USB PHY framework. Supply those properties. Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was merged in greg/usb-next. [1] [1] - https://lkml.org/lkml/2013/9/27/581 Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/boot/dts/omap3-gta04.dts | 2 ++ arch/arm/boot/dts/omap3-n900.dts | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-)