diff mbox

mountstats: enforce new python syntax

Message ID 1382346241-20637-1-git-send-email-tigran.mkrtchyan@desy.de (mailing list archive)
State New, archived
Headers show

Commit Message

Mkrtchyan, Tigran Oct. 21, 2013, 9:04 a.m. UTC
$ mountstats
  File "/usr/sbin/mountstats", line 272
    (count, ((count * 100) / sends)), end=' ')
                                         ^
SyntaxError: invalid syntax

Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
---
 tools/mountstats/mountstats.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Weston Andros Adamson Oct. 21, 2013, 2:04 p.m. UTC | #1
I posted a similar patch last week.

-dros

On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <tigran.mkrtchyan@desy.de> wrote:

> $ mountstats
>  File "/usr/sbin/mountstats", line 272
>    (count, ((count * 100) / sends)), end=' ')
>                                         ^
> SyntaxError: invalid syntax
> 
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> tools/mountstats/mountstats.py | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 3f5fea5..351145e 100644
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -1,5 +1,6 @@
> #!/usr/bin/env python
> # -*- python-mode -*-
> +from __future__ import print_function
> """Parse /proc/self/mountstats and display it in human readable form
> """
> 
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steve Dickson Oct. 21, 2013, 2:19 p.m. UTC | #2
On 21/10/13 10:04, Weston Andros Adamson wrote:
> I posted a similar patch last week.
Which has been committed!

steved.
> 
> -dros
> 
> On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <tigran.mkrtchyan@desy.de> wrote:
> 
>> $ mountstats
>>  File "/usr/sbin/mountstats", line 272
>>    (count, ((count * 100) / sends)), end=' ')
>>                                         ^
>> SyntaxError: invalid syntax
>>
>> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
>> ---
>> tools/mountstats/mountstats.py | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
>> index 3f5fea5..351145e 100644
>> --- a/tools/mountstats/mountstats.py
>> +++ b/tools/mountstats/mountstats.py
>> @@ -1,5 +1,6 @@
>> #!/usr/bin/env python
>> # -*- python-mode -*-
>> +from __future__ import print_function
>> """Parse /proc/self/mountstats and display it in human readable form
>> """
>>
>> -- 
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mkrtchyan, Tigran Oct. 21, 2013, 2:25 p.m. UTC | #3
----- Original Message -----
> From: "Steve Dickson" <SteveD@redhat.com>
> To: "Weston Andros Adamson" <dros@netapp.com>
> Cc: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>, "<linux-nfs@vger.kernel.org>" <linux-nfs@vger.kernel.org>
> Sent: Monday, October 21, 2013 4:19:31 PM
> Subject: Re: [PATCH] mountstats: enforce new python syntax
> 
> 
> 
> On 21/10/13 10:04, Weston Andros Adamson wrote:
> > I posted a similar patch last week.
> Which has been committed!

Ah, then sorry for the noise!

Tigran.
> 
> steved.
> > 
> > -dros
> > 
> > On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> > wrote:
> > 
> >> $ mountstats
> >>  File "/usr/sbin/mountstats", line 272
> >>    (count, ((count * 100) / sends)), end=' ')
> >>                                         ^
> >> SyntaxError: invalid syntax
> >>
> >> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> >> ---
> >> tools/mountstats/mountstats.py | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/tools/mountstats/mountstats.py
> >> b/tools/mountstats/mountstats.py
> >> index 3f5fea5..351145e 100644
> >> --- a/tools/mountstats/mountstats.py
> >> +++ b/tools/mountstats/mountstats.py
> >> @@ -1,5 +1,6 @@
> >> #!/usr/bin/env python
> >> # -*- python-mode -*-
> >> +from __future__ import print_function
> >> """Parse /proc/self/mountstats and display it in human readable form
> >> """
> >>
> >> --
> >> 1.8.3.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 3f5fea5..351145e 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -1,5 +1,6 @@ 
 #!/usr/bin/env python
 # -*- python-mode -*-
+from __future__ import print_function
 """Parse /proc/self/mountstats and display it in human readable form
 """