| Message ID | 1382380843-15647-1-git-send-email-roland@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 21/10/2013 9:40 PM, Roland Dreier wrote: > From: Yann Droneaud <ydroneaud@opteya.com> > > The create_flow/destroy_flow uverbs and the associated extensions to > the user-kernel verbs ABI are under review and are too experimental to > freeze at this point. > > So userspace is not exposed to experimental features and an uinstable > ABI, temporarily disable this for v3.12 (with a Kconfig option behind > staging to reenable it if desired). > > The feature will be enabled after proper cleanup for v3.13. > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> > Link: http://marc.info/?i=cover.1381351016.git.ydroneaud@opteya.com > Link: http://marc.info/?i=cover.1381177342.git.ydroneaud@opteya.com > > [ Add a Kconfig option to reenable these verbs. - Roland ] > > Signed-off-by: Roland Dreier <roland@purestorage.com> > --- > drivers/infiniband/Kconfig | 11 +++++++++++ > drivers/infiniband/core/uverbs.h | 2 ++ > drivers/infiniband/core/uverbs_cmd.c | 4 ++++ > drivers/infiniband/core/uverbs_main.c | 6 ++++++ > drivers/infiniband/hw/mlx4/main.c | 2 ++ > include/uapi/rdma/ib_user_verbs.h | 6 ++++++ > 6 files changed, 31 insertions(+) > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index 5ceda710f516..b84791f03a27 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -31,6 +31,17 @@ config INFINIBAND_USER_ACCESS > libibverbs, libibcm and a hardware driver library from > <http://www.openfabrics.org/git/>. > > +config INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > + bool "Experimental and unstable ABI for userspace access to flow steering verbs" > + depends on INFINIBAND_USER_ACCESS > + depends on STAGING > + ---help--- > + The final ABI for userspace access to flow steering verbs > + has not been defined. To use the current ABI, *WHICH WILL > + CHANGE IN THE FUTURE*, say Y here. > + > + If unsure, say N. > + > config INFINIBAND_USER_MEM > bool > depends on INFINIBAND_USER_ACCESS != n > diff --git a/drivers/infiniband/core/uverbs.h b/drivers/infiniband/core/uverbs.h > index d040b877475f..d8f9c6c272d7 100644 > --- a/drivers/infiniband/core/uverbs.h > +++ b/drivers/infiniband/core/uverbs.h > @@ -217,7 +217,9 @@ IB_UVERBS_DECLARE_CMD(destroy_srq); > IB_UVERBS_DECLARE_CMD(create_xsrq); > IB_UVERBS_DECLARE_CMD(open_xrcd); > IB_UVERBS_DECLARE_CMD(close_xrcd); > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > IB_UVERBS_DECLARE_CMD(create_flow); > IB_UVERBS_DECLARE_CMD(destroy_flow); > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > > #endif /* UVERBS_H */ > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c > index f2b81b9ee0d6..2f0f01b70e3b 100644 > --- a/drivers/infiniband/core/uverbs_cmd.c > +++ b/drivers/infiniband/core/uverbs_cmd.c > @@ -54,7 +54,9 @@ static struct uverbs_lock_class qp_lock_class = { .name = "QP-uobj" }; > static struct uverbs_lock_class ah_lock_class = { .name = "AH-uobj" }; > static struct uverbs_lock_class srq_lock_class = { .name = "SRQ-uobj" }; > static struct uverbs_lock_class xrcd_lock_class = { .name = "XRCD-uobj" }; > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > static struct uverbs_lock_class rule_lock_class = { .name = "RULE-uobj" }; > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > > #define INIT_UDATA(udata, ibuf, obuf, ilen, olen) \ > do { \ > @@ -2599,6 +2601,7 @@ out_put: > return ret ? ret : in_len; > } > > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > static int kern_spec_to_ib_spec(struct ib_kern_spec *kern_spec, > union ib_flow_spec *ib_spec) > { > @@ -2824,6 +2827,7 @@ ssize_t ib_uverbs_destroy_flow(struct ib_uverbs_file *file, > > return ret ? ret : in_len; > } > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > > static int __uverbs_create_xsrq(struct ib_uverbs_file *file, > struct ib_uverbs_create_xsrq *cmd, > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > index 75ad86c4abf8..2df31f68ea09 100644 > --- a/drivers/infiniband/core/uverbs_main.c > +++ b/drivers/infiniband/core/uverbs_main.c > @@ -115,8 +115,10 @@ static ssize_t (*uverbs_cmd_table[])(struct ib_uverbs_file *file, > [IB_USER_VERBS_CMD_CLOSE_XRCD] = ib_uverbs_close_xrcd, > [IB_USER_VERBS_CMD_CREATE_XSRQ] = ib_uverbs_create_xsrq, > [IB_USER_VERBS_CMD_OPEN_QP] = ib_uverbs_open_qp, > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > [IB_USER_VERBS_CMD_CREATE_FLOW] = ib_uverbs_create_flow, > [IB_USER_VERBS_CMD_DESTROY_FLOW] = ib_uverbs_destroy_flow > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > }; > > static void ib_uverbs_add_one(struct ib_device *device); > @@ -605,6 +607,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, > if (!(file->device->ib_dev->uverbs_cmd_mask & (1ull << hdr.command))) > return -ENOSYS; > > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > if (hdr.command >= IB_USER_VERBS_CMD_THRESHOLD) { > struct ib_uverbs_cmd_hdr_ex hdr_ex; > > @@ -621,6 +624,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, > (hdr_ex.out_words + > hdr_ex.provider_out_words) * 4); > } else { > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > if (hdr.in_words * 4 != count) > return -EINVAL; > > @@ -628,7 +632,9 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, > buf + sizeof(hdr), > hdr.in_words * 4, > hdr.out_words * 4); > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > } > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > } > > static int ib_uverbs_mmap(struct file *filp, struct vm_area_struct *vma) > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c > index d6c5a73becf4..f0612645de99 100644 > --- a/drivers/infiniband/hw/mlx4/main.c > +++ b/drivers/infiniband/hw/mlx4/main.c > @@ -1691,9 +1691,11 @@ static void *mlx4_ib_add(struct mlx4_dev *dev) > ibdev->ib_dev.create_flow = mlx4_ib_create_flow; > ibdev->ib_dev.destroy_flow = mlx4_ib_destroy_flow; > > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > ibdev->ib_dev.uverbs_cmd_mask |= > (1ull << IB_USER_VERBS_CMD_CREATE_FLOW) | > (1ull << IB_USER_VERBS_CMD_DESTROY_FLOW); > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > } > > mlx4_ib_alloc_eqs(dev, ibdev); > diff --git a/include/uapi/rdma/ib_user_verbs.h b/include/uapi/rdma/ib_user_verbs.h > index 0b233c56b0e4..e3ddd86c90a6 100644 > --- a/include/uapi/rdma/ib_user_verbs.h > +++ b/include/uapi/rdma/ib_user_verbs.h > @@ -87,8 +87,10 @@ enum { > IB_USER_VERBS_CMD_CLOSE_XRCD, > IB_USER_VERBS_CMD_CREATE_XSRQ, > IB_USER_VERBS_CMD_OPEN_QP, > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > IB_USER_VERBS_CMD_CREATE_FLOW = IB_USER_VERBS_CMD_THRESHOLD, > IB_USER_VERBS_CMD_DESTROY_FLOW > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > }; > > /* > @@ -126,6 +128,7 @@ struct ib_uverbs_cmd_hdr { > __u16 out_words; > }; > > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > struct ib_uverbs_cmd_hdr_ex { > __u32 command; > __u16 in_words; > @@ -134,6 +137,7 @@ struct ib_uverbs_cmd_hdr_ex { > __u16 provider_out_words; > __u32 cmd_hdr_reserved; > }; > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > > struct ib_uverbs_get_context { > __u64 response; > @@ -696,6 +700,7 @@ struct ib_uverbs_detach_mcast { > __u64 driver_data[0]; > }; > > +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING > struct ib_kern_eth_filter { > __u8 dst_mac[6]; > __u8 src_mac[6]; > @@ -780,6 +785,7 @@ struct ib_uverbs_destroy_flow { > __u32 comp_mask; > __u32 flow_handle; > }; > +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ > > struct ib_uverbs_create_srq { > __u64 response; > Hi, I think that's our best option. Users that would really like to try flow steering will be able to do so, but we make no promises for future kernel ABIs. Regards, Matan -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Le 21.10.2013 20:40, Roland Dreier a écrit : > From: Yann Droneaud <ydroneaud@opteya.com> > > The create_flow/destroy_flow uverbs and the associated extensions to > the user-kernel verbs ABI are under review and are too experimental to > freeze at this point. > > So userspace is not exposed to experimental features and an uinstable > ABI, temporarily disable this for v3.12 (with a Kconfig option behind > staging to reenable it if desired). > > The feature will be enabled after proper cleanup for v3.13. > > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> > Link: http://marc.info/?i=cover.1381351016.git.ydroneaud@opteya.com > Link: http://marc.info/?i=cover.1381177342.git.ydroneaud@opteya.com > > [ Add a Kconfig option to reenable these verbs. - Roland ] > > Signed-off-by: Roland Dreier <roland@purestorage.com> For the record: Acked-by: Yann Droneaud <ydroneaud@opteya.com> Thanks Roland for updating the patch with the Kconfig entry. Regards.
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index 5ceda710f516..b84791f03a27 100644 --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -31,6 +31,17 @@ config INFINIBAND_USER_ACCESS libibverbs, libibcm and a hardware driver library from <http://www.openfabrics.org/git/>. +config INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING + bool "Experimental and unstable ABI for userspace access to flow steering verbs" + depends on INFINIBAND_USER_ACCESS + depends on STAGING + ---help--- + The final ABI for userspace access to flow steering verbs + has not been defined. To use the current ABI, *WHICH WILL + CHANGE IN THE FUTURE*, say Y here. + + If unsure, say N. + config INFINIBAND_USER_MEM bool depends on INFINIBAND_USER_ACCESS != n diff --git a/drivers/infiniband/core/uverbs.h b/drivers/infiniband/core/uverbs.h index d040b877475f..d8f9c6c272d7 100644 --- a/drivers/infiniband/core/uverbs.h +++ b/drivers/infiniband/core/uverbs.h @@ -217,7 +217,9 @@ IB_UVERBS_DECLARE_CMD(destroy_srq); IB_UVERBS_DECLARE_CMD(create_xsrq); IB_UVERBS_DECLARE_CMD(open_xrcd); IB_UVERBS_DECLARE_CMD(close_xrcd); +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING IB_UVERBS_DECLARE_CMD(create_flow); IB_UVERBS_DECLARE_CMD(destroy_flow); +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ #endif /* UVERBS_H */ diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index f2b81b9ee0d6..2f0f01b70e3b 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -54,7 +54,9 @@ static struct uverbs_lock_class qp_lock_class = { .name = "QP-uobj" }; static struct uverbs_lock_class ah_lock_class = { .name = "AH-uobj" }; static struct uverbs_lock_class srq_lock_class = { .name = "SRQ-uobj" }; static struct uverbs_lock_class xrcd_lock_class = { .name = "XRCD-uobj" }; +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING static struct uverbs_lock_class rule_lock_class = { .name = "RULE-uobj" }; +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ #define INIT_UDATA(udata, ibuf, obuf, ilen, olen) \ do { \ @@ -2599,6 +2601,7 @@ out_put: return ret ? ret : in_len; } +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING static int kern_spec_to_ib_spec(struct ib_kern_spec *kern_spec, union ib_flow_spec *ib_spec) { @@ -2824,6 +2827,7 @@ ssize_t ib_uverbs_destroy_flow(struct ib_uverbs_file *file, return ret ? ret : in_len; } +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ static int __uverbs_create_xsrq(struct ib_uverbs_file *file, struct ib_uverbs_create_xsrq *cmd, diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index 75ad86c4abf8..2df31f68ea09 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c @@ -115,8 +115,10 @@ static ssize_t (*uverbs_cmd_table[])(struct ib_uverbs_file *file, [IB_USER_VERBS_CMD_CLOSE_XRCD] = ib_uverbs_close_xrcd, [IB_USER_VERBS_CMD_CREATE_XSRQ] = ib_uverbs_create_xsrq, [IB_USER_VERBS_CMD_OPEN_QP] = ib_uverbs_open_qp, +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING [IB_USER_VERBS_CMD_CREATE_FLOW] = ib_uverbs_create_flow, [IB_USER_VERBS_CMD_DESTROY_FLOW] = ib_uverbs_destroy_flow +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ }; static void ib_uverbs_add_one(struct ib_device *device); @@ -605,6 +607,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, if (!(file->device->ib_dev->uverbs_cmd_mask & (1ull << hdr.command))) return -ENOSYS; +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING if (hdr.command >= IB_USER_VERBS_CMD_THRESHOLD) { struct ib_uverbs_cmd_hdr_ex hdr_ex; @@ -621,6 +624,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, (hdr_ex.out_words + hdr_ex.provider_out_words) * 4); } else { +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ if (hdr.in_words * 4 != count) return -EINVAL; @@ -628,7 +632,9 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, buf + sizeof(hdr), hdr.in_words * 4, hdr.out_words * 4); +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING } +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ } static int ib_uverbs_mmap(struct file *filp, struct vm_area_struct *vma) diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index d6c5a73becf4..f0612645de99 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -1691,9 +1691,11 @@ static void *mlx4_ib_add(struct mlx4_dev *dev) ibdev->ib_dev.create_flow = mlx4_ib_create_flow; ibdev->ib_dev.destroy_flow = mlx4_ib_destroy_flow; +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING ibdev->ib_dev.uverbs_cmd_mask |= (1ull << IB_USER_VERBS_CMD_CREATE_FLOW) | (1ull << IB_USER_VERBS_CMD_DESTROY_FLOW); +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ } mlx4_ib_alloc_eqs(dev, ibdev); diff --git a/include/uapi/rdma/ib_user_verbs.h b/include/uapi/rdma/ib_user_verbs.h index 0b233c56b0e4..e3ddd86c90a6 100644 --- a/include/uapi/rdma/ib_user_verbs.h +++ b/include/uapi/rdma/ib_user_verbs.h @@ -87,8 +87,10 @@ enum { IB_USER_VERBS_CMD_CLOSE_XRCD, IB_USER_VERBS_CMD_CREATE_XSRQ, IB_USER_VERBS_CMD_OPEN_QP, +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING IB_USER_VERBS_CMD_CREATE_FLOW = IB_USER_VERBS_CMD_THRESHOLD, IB_USER_VERBS_CMD_DESTROY_FLOW +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ }; /* @@ -126,6 +128,7 @@ struct ib_uverbs_cmd_hdr { __u16 out_words; }; +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING struct ib_uverbs_cmd_hdr_ex { __u32 command; __u16 in_words; @@ -134,6 +137,7 @@ struct ib_uverbs_cmd_hdr_ex { __u16 provider_out_words; __u32 cmd_hdr_reserved; }; +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ struct ib_uverbs_get_context { __u64 response; @@ -696,6 +700,7 @@ struct ib_uverbs_detach_mcast { __u64 driver_data[0]; }; +#ifdef CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING struct ib_kern_eth_filter { __u8 dst_mac[6]; __u8 src_mac[6]; @@ -780,6 +785,7 @@ struct ib_uverbs_destroy_flow { __u32 comp_mask; __u32 flow_handle; }; +#endif /* CONFIG_INFINIBAND_EXPERIMENTAL_UVERBS_FLOW_STEERING */ struct ib_uverbs_create_srq { __u64 response;