| Message ID | 1382540482-12261-2-git-send-email-sre@debian.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 23, 2013 at 04:01:20PM +0100, Sebastian Reichel wrote: > Add device tree support for twl4030 power button driver. This requires a binding document. As it is it's not possible to review. Mark. > > Signed-off-by: Sebastian Reichel <sre@debian.org> > --- > drivers/input/misc/twl4030-pwrbutton.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > index b9a05fd..a3a0fe3 100644 > --- a/drivers/input/misc/twl4030-pwrbutton.c > +++ b/drivers/input/misc/twl4030-pwrbutton.c > @@ -52,7 +52,7 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr) > return IRQ_HANDLED; > } > > -static int __init twl4030_pwrbutton_probe(struct platform_device *pdev) > +static int twl4030_pwrbutton_probe(struct platform_device *pdev) > { > struct input_dev *pwr; > int irq = platform_get_irq(pdev, 0); > @@ -106,16 +106,24 @@ static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev) > return 0; > } > > +#if IS_ENABLED(CONFIG_OF) > +static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = { > + { .compatible = "ti,twl4030-pwrbutton" }, There's no need to shorten this, "ti,twl4030-power-button" would be far easier to understand. Unless the datasheet refers to it as pwrbutton? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Oct 23, 2013 at 05:09:36PM +0100, Mark Rutland wrote: > On Wed, Oct 23, 2013 at 04:01:20PM +0100, Sebastian Reichel wrote: > > Add device tree support for twl4030 power button driver. > > This requires a binding document. As it is it's not possible to review. Right. I will add it and sent a v3. > > > > Signed-off-by: Sebastian Reichel <sre@debian.org> > > --- > > drivers/input/misc/twl4030-pwrbutton.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c > > index b9a05fd..a3a0fe3 100644 > > --- a/drivers/input/misc/twl4030-pwrbutton.c > > +++ b/drivers/input/misc/twl4030-pwrbutton.c > > @@ -52,7 +52,7 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr) > > return IRQ_HANDLED; > > } > > > > -static int __init twl4030_pwrbutton_probe(struct platform_device *pdev) > > +static int twl4030_pwrbutton_probe(struct platform_device *pdev) > > { > > struct input_dev *pwr; > > int irq = platform_get_irq(pdev, 0); > > @@ -106,16 +106,24 @@ static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev) > > return 0; > > } > > > > +#if IS_ENABLED(CONFIG_OF) > > +static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = { > > + { .compatible = "ti,twl4030-pwrbutton" }, > > There's no need to shorten this, "ti,twl4030-power-button" would be far easier > to understand. Unless the datasheet refers to it as pwrbutton? Yes it's abbreviated in the datasheet. -- Sebastian
diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index b9a05fd..a3a0fe3 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c @@ -52,7 +52,7 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr) return IRQ_HANDLED; } -static int __init twl4030_pwrbutton_probe(struct platform_device *pdev) +static int twl4030_pwrbutton_probe(struct platform_device *pdev) { struct input_dev *pwr; int irq = platform_get_irq(pdev, 0); @@ -106,16 +106,24 @@ static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev) return 0; } +#if IS_ENABLED(CONFIG_OF) +static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = { + { .compatible = "ti,twl4030-pwrbutton" }, + {}, +}; +MODULE_DEVICE_TABLE(of, twl4030_pwrbutton_dt_match_table); +#endif + static struct platform_driver twl4030_pwrbutton_driver = { + .probe = twl4030_pwrbutton_probe, .remove = __exit_p(twl4030_pwrbutton_remove), .driver = { .name = "twl4030_pwrbutton", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(twl4030_pwrbutton_dt_match_table), }, }; - -module_platform_driver_probe(twl4030_pwrbutton_driver, - twl4030_pwrbutton_probe); +module_platform_driver(twl4030_pwrbutton_driver); MODULE_ALIAS("platform:twl4030_pwrbutton"); MODULE_DESCRIPTION("Triton2 Power Button");
Add device tree support for twl4030 power button driver. Signed-off-by: Sebastian Reichel <sre@debian.org> --- drivers/input/misc/twl4030-pwrbutton.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)