| Message ID | 1375452223-30524-7-git-send-email-archit@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Archit, Thank you for the patch. On Friday 02 August 2013 19:33:43 Archit Taneja wrote: > Add a DT node for VPE in dra7.dtsi. This is experimental because we might > need to split the VPE address space a bit more, and also because the IRQ > line described is accessible the IRQ crossbar driver is added for DRA7XX. > > Cc: Rajendra Nayak <rnayak@ti.com> > Cc: Sricharan R <r.sricharan@ti.com> > Signed-off-by: Archit Taneja <archit@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ Documentation is missing :-) As this is an experimental patch you can probably document the bindings later. > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index ce9a0f0..3237972 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -484,6 +484,17 @@ > dmas = <&sdma 70>, <&sdma 71>; > dma-names = "tx0", "rx0"; > }; > + > + vpe { > + compatible = "ti,vpe"; > + ti,hwmods = "vpe"; > + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; > + reg-names = "vpe", "vpdma"; > + interrupts = <0 159 0x4>; > + #address-cells = <1>; > + #size-cells = <0>; Are #address-cells and #size-cells really needed ? > + }; > + > }; > > clocks {
Hi Laurent, Sorry about the late response, I had scrapped the DT patch out of the VPE series since there were dependencies on crossbar drivers and some other baseport stuff. Comments below. On Friday 09 August 2013 03:41 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Friday 02 August 2013 19:33:43 Archit Taneja wrote: >> Add a DT node for VPE in dra7.dtsi. This is experimental because we might >> need to split the VPE address space a bit more, and also because the IRQ >> line described is accessible the IRQ crossbar driver is added for DRA7XX. >> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Sricharan R <r.sricharan@ti.com> >> Signed-off-by: Archit Taneja <archit@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ > > Documentation is missing :-) As this is an experimental patch you can probably > document the bindings later. Yes, I will work on that. > >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index ce9a0f0..3237972 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -484,6 +484,17 @@ >> dmas = <&sdma 70>, <&sdma 71>; >> dma-names = "tx0", "rx0"; >> }; >> + >> + vpe { >> + compatible = "ti,vpe"; >> + ti,hwmods = "vpe"; >> + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; >> + reg-names = "vpe", "vpdma"; >> + interrupts = <0 159 0x4>; >> + #address-cells = <1>; >> + #size-cells = <0>; > > Are #address-cells and #size-cells really needed ? These aren't needed, vpe derives the address info from it's parent(ocp). I didn't know that the child nodes inherit these params from the parent. Archit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Laurent, On Friday 09 August 2013 03:41 AM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Friday 02 August 2013 19:33:43 Archit Taneja wrote: >> Add a DT node for VPE in dra7.dtsi. This is experimental because we might >> need to split the VPE address space a bit more, and also because the IRQ >> line described is accessible the IRQ crossbar driver is added for DRA7XX. >> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Sricharan R <r.sricharan@ti.com> >> Signed-off-by: Archit Taneja <archit@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ > > Documentation is missing :-) As this is an experimental patch you can probably > document the bindings later. Sorry for the late reply, I missed out on reading this message somehow. I'm blocked on adding the DT nodes because of some dependencies on dra7x clocks, and the crossbar framework. I'll make sure to add documentation :) > >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index ce9a0f0..3237972 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -484,6 +484,17 @@ >> dmas = <&sdma 70>, <&sdma 71>; >> dma-names = "tx0", "rx0"; >> }; >> + >> + vpe { >> + compatible = "ti,vpe"; >> + ti,hwmods = "vpe"; >> + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; >> + reg-names = "vpe", "vpdma"; >> + interrupts = <0 159 0x4>; >> + #address-cells = <1>; >> + #size-cells = <0>; > > Are #address-cells and #size-cells really needed ? They aren't needed. The vpe node inherits these params from the parent "ocp" node. Thanks, Archit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index ce9a0f0..3237972 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -484,6 +484,17 @@ dmas = <&sdma 70>, <&sdma 71>; dma-names = "tx0", "rx0"; }; + + vpe { + compatible = "ti,vpe"; + ti,hwmods = "vpe"; + reg = <0x489d0000 0xd000>, <0x489dd000 0x400>; + reg-names = "vpe", "vpdma"; + interrupts = <0 159 0x4>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; clocks {
Add a DT node for VPE in dra7.dtsi. This is experimental because we might need to split the VPE address space a bit more, and also because the IRQ line described is accessible the IRQ crossbar driver is added for DRA7XX. Cc: Rajendra Nayak <rnayak@ti.com> Cc: Sricharan R <r.sricharan@ti.com> Signed-off-by: Archit Taneja <archit@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)