| Message ID | 20090604191813.GA6281@tango.0pointer.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Looks good, we recently fixed the same issue in the gspca driver to, Acked-by: Hans de Goede <hdegoede@redhat.com> On 06/04/2009 09:18 PM, Lennart Poettering wrote: > The current code creates a sysfs device path where the video4linux > device is child of the usb device itself instead of the interface it > belongs to. That is evil and confuses udev. > > This patch does basically the same thing as Kay's similar patch for the > ov511 driver: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d > > (Resent 2nd time, due to missing Signed-off-by) > > Lennart > > Signed-off-by: Lennart Poettering<mzxreary@0pointer.de> > --- > drivers/media/video/pwc/pwc-if.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c > index 7c542ca..92d4177 100644 > --- a/drivers/media/video/pwc/pwc-if.c > +++ b/drivers/media/video/pwc/pwc-if.c > @@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id > return -ENOMEM; > } > memcpy(pdev->vdev,&pwc_template, sizeof(pwc_template)); > - pdev->vdev->parent =&(udev->dev); > + pdev->vdev->parent =&intf->dev; > strcpy(pdev->vdev->name, name); > video_set_drvdata(pdev->vdev, pdev); > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c index 7c542ca..92d4177 100644 --- a/drivers/media/video/pwc/pwc-if.c +++ b/drivers/media/video/pwc/pwc-if.c @@ -1783,7 +1783,7 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id return -ENOMEM; } memcpy(pdev->vdev, &pwc_template, sizeof(pwc_template)); - pdev->vdev->parent = &(udev->dev); + pdev->vdev->parent = &intf->dev; strcpy(pdev->vdev->name, name); video_set_drvdata(pdev->vdev, pdev);
The current code creates a sysfs device path where the video4linux device is child of the usb device itself instead of the interface it belongs to. That is evil and confuses udev. This patch does basically the same thing as Kay's similar patch for the ov511 driver: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ce96d0a44a4f8d1bb3dc12b5e98cb688c1bc730d (Resent 2nd time, due to missing Signed-off-by) Lennart Signed-off-by: Lennart Poettering <mzxreary@0pointer.de> --- drivers/media/video/pwc/pwc-if.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)