| Message ID | 1383247111-26834-4-git-send-email-andrew@lunn.ch (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > The dove-cpufreq driver needs access to the DDR and CPU clock. There > is also an interrupt generated when the DFS hardware completes a > change of frequencey. Add these to the cpu node in DT. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> I need someone with DT bindings knowledge to ACK this for me. Thanks! > --- > arch/arm/boot/dts/dove.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi > index 1fd615d27532..e96d7a6a2fb8 100644 > --- a/arch/arm/boot/dts/dove.dtsi > +++ b/arch/arm/boot/dts/dove.dtsi > @@ -19,6 +19,10 @@ > device_type = "cpu"; > next-level-cache = <&l2>; > reg = <0>; > + clocks = <&core_clk 1>, <&core_clk 3>; > + clock-names = "cpu_clk", "ddrclk"; > + interrupt-parent = <&pmu_intc>; > + interrupts = <0>; > }; > }; > >
On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: >> The dove-cpufreq driver needs access to the DDR and CPU clock. There >> is also an interrupt generated when the DFS hardware completes a >> change of frequencey. Add these to the cpu node in DT. >> >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > I need someone with DT bindings knowledge to ACK this for me. I can do that, but this set has to be rebased over all the latest developments in cpufreq core before getting posted again.. @Andrew: you can add my: Acked-by: Viresh Kumar <viresh.kumar@linaro.org> for this patch.. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 01, 2013 at 05:21:03AM +0530, Viresh Kumar wrote: > On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > >> The dove-cpufreq driver needs access to the DDR and CPU clock. There > >> is also an interrupt generated when the DFS hardware completes a > >> change of frequencey. Add these to the cpu node in DT. > >> > >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> > >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > > I need someone with DT bindings knowledge to ACK this for me. > > I can do that Thanks. , but this set has to be rebased over all the latest developments > in cpufreq core before getting posted again.. I will wait for -rc1 and rebase. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 01, 2013 at 02:16:37PM +0100, Rafael J. Wysocki wrote: > On Friday, November 01, 2013 10:07:37 AM Andrew Lunn wrote: > > On Fri, Nov 01, 2013 at 05:21:03AM +0530, Viresh Kumar wrote: > > > On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > > > >> The dove-cpufreq driver needs access to the DDR and CPU clock. There > > > >> is also an interrupt generated when the DFS hardware completes a > > > >> change of frequencey. Add these to the cpu node in DT. > > > >> > > > >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > > >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > > > > > > I need someone with DT bindings knowledge to ACK this for me. > > > > > > I can do that > > > > Thanks. > > > > , but this set has to be rebased over all the latest developments > > > in cpufreq core before getting posted again.. > > > > I will wait for -rc1 and rebase. > > Actually, it is possible that 3.12-rc8 will be released this weekend. If that > happens, please rebase your patchset on top of the current linux-next and > resubmit it next week. Hi Rafael Just be to sure, since we have had problems with terminology before. Do you mean the The linux-next, or your linux next branch? Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, November 01, 2013 10:07:37 AM Andrew Lunn wrote: > On Fri, Nov 01, 2013 at 05:21:03AM +0530, Viresh Kumar wrote: > > On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > > >> The dove-cpufreq driver needs access to the DDR and CPU clock. There > > >> is also an interrupt generated when the DFS hardware completes a > > >> change of frequencey. Add these to the cpu node in DT. > > >> > > >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > > > > I need someone with DT bindings knowledge to ACK this for me. > > > > I can do that > > Thanks. > > , but this set has to be rebased over all the latest developments > > in cpufreq core before getting posted again.. > > I will wait for -rc1 and rebase. Actually, it is possible that 3.12-rc8 will be released this weekend. If that happens, please rebase your patchset on top of the current linux-next and resubmit it next week. Thanks!
On Friday, November 01, 2013 02:14:52 PM Andrew Lunn wrote: > On Fri, Nov 01, 2013 at 02:16:37PM +0100, Rafael J. Wysocki wrote: > > On Friday, November 01, 2013 10:07:37 AM Andrew Lunn wrote: > > > On Fri, Nov 01, 2013 at 05:21:03AM +0530, Viresh Kumar wrote: > > > > On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > > > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > > > > >> The dove-cpufreq driver needs access to the DDR and CPU clock. There > > > > >> is also an interrupt generated when the DFS hardware completes a > > > > >> change of frequencey. Add these to the cpu node in DT. > > > > >> > > > > >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > > > >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > > > > > > > > I need someone with DT bindings knowledge to ACK this for me. > > > > > > > > I can do that > > > > > > Thanks. > > > > > > , but this set has to be rebased over all the latest developments > > > > in cpufreq core before getting posted again.. > > > > > > I will wait for -rc1 and rebase. > > > > Actually, it is possible that 3.12-rc8 will be released this weekend. If that > > happens, please rebase your patchset on top of the current linux-next and > > resubmit it next week. > > Hi Rafael > > Just be to sure, since we have had problems with terminology before. > Do you mean the The linux-next, or your linux next branch? That shouldn't matter a lot at this point I think. Generally, if I'm supposed to take the patches, it's safer to rebase them against my linux-next branch. Thanks!
On Fri, Nov 01, 2013 at 10:07:37AM +0100, Andrew Lunn wrote: > On Fri, Nov 01, 2013 at 05:21:03AM +0530, Viresh Kumar wrote: > > On 1 November 2013 03:56, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > On Thursday, October 31, 2013 08:18:31 PM Andrew Lunn wrote: > > >> The dove-cpufreq driver needs access to the DDR and CPU clock. There > > >> is also an interrupt generated when the DFS hardware completes a > > >> change of frequencey. Add these to the cpu node in DT. > > >> > > >> Signed-off-by: Andrew Lunn <andrew@lunn.ch> > > >> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > > > > > > I need someone with DT bindings knowledge to ACK this for me. > > > > I can do that > > Thanks. > > > , but this set has to be rebased over all the latest developments > > in cpufreq core before getting posted again.. > > I will wait for -rc1 and rebase. ping. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi index 1fd615d27532..e96d7a6a2fb8 100644 --- a/arch/arm/boot/dts/dove.dtsi +++ b/arch/arm/boot/dts/dove.dtsi @@ -19,6 +19,10 @@ device_type = "cpu"; next-level-cache = <&l2>; reg = <0>; + clocks = <&core_clk 1>, <&core_clk 3>; + clock-names = "cpu_clk", "ddrclk"; + interrupt-parent = <&pmu_intc>; + interrupts = <0>; }; };