| Message ID | 1383571658-7440-1-git-send-email-mail@aldo.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > Fixed three coding style issues. Replaced spaces with tabs. > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > --- > fs/btrfs/dev-replace.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > index 9efb94e..b2fe609 100644 > --- a/fs/btrfs/dev-replace.c > +++ b/fs/btrfs/dev-replace.c > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > printk_in_rcu(KERN_INFO > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > src_device->missing ? "<missing disk>" : > - rcu_str_deref(src_device->name), > + rcu_str_deref(src_device->name), What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more boring, namely in case where the code looks exactly the same before and after the patch. The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > Fixed three coding style issues. Replaced spaces with tabs. > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > --- > fs/btrfs/dev-replace.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > index 9efb94e..b2fe609 100644 > --- a/fs/btrfs/dev-replace.c > +++ b/fs/btrfs/dev-replace.c > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > printk_in_rcu(KERN_INFO > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > src_device->missing ? "<missing disk>" : > - rcu_str_deref(src_device->name), > + rcu_str_deref(src_device->name), What's the change here? I don't think we need to fix whitespace, this makes searching in patch history more tedious, namely in case where the code looks exactly the same before and after the patch. The style issues should be best fixed when the patch is about to be merged, doing it later like this is kind of not welcome, speaking for myself. There are lots of opportunities to do real code cleanups. Whitespace changes are just noise, we don't need them at this point of development phase of btrfs. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba wrote: > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > Fixed three coding style issues. Replaced spaces with tabs. > > > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > > --- > > fs/btrfs/dev-replace.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > index 9efb94e..b2fe609 100644 > > --- a/fs/btrfs/dev-replace.c > > +++ b/fs/btrfs/dev-replace.c > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > printk_in_rcu(KERN_INFO > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > > src_device->missing ? "<missing disk>" : > > - rcu_str_deref(src_device->name), > > + rcu_str_deref(src_device->name), > > What's the change here? I don't think we need to fix whitespace, this makes > searching in patch history more tedious, namely in case where the code looks > exactly the same before and after the patch. > > The style issues should be best fixed when the patch is about to be > merged, doing it later like this is kind of not welcome, speaking for > myself. There are lots of opportunities to do real code cleanups. > > Whitespace changes are just noise, we don't need them at this point of > development phase of btrfs. > > > david I replaced the spaces with tabs, as the kernel coding style suggests.
On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote: > David Sterba wrote: > > > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > > Fixed three coding style issues. Replaced spaces with tabs. > > > > > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > > > --- > > > fs/btrfs/dev-replace.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > > index 9efb94e..b2fe609 100644 > > > --- a/fs/btrfs/dev-replace.c > > > +++ b/fs/btrfs/dev-replace.c > > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > > printk_in_rcu(KERN_INFO > > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > > > src_device->missing ? "<missing disk>" : > > > - rcu_str_deref(src_device->name), > > > + rcu_str_deref(src_device->name), > > > > What's the change here? I don't think we need to fix whitespace, this makes > > searching in patch history more tedious, namely in case where the code looks > > exactly the same before and after the patch. > > > > The style issues should be best fixed when the patch is about to be > > merged, doing it later like this is kind of not welcome, speaking for > > myself. There are lots of opportunities to do real code cleanups. > > > > Whitespace changes are just noise, we don't need them at this point of > > development phase of btrfs. > > > > > > david > > I replaced the spaces with tabs, as the kernel coding style suggests. I repeat: Whitespace changes are just noise, we don't need them at this point of development phase of btrfs. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba wrote: > On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote: > > David Sterba wrote: > > > > > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > > > Fixed three coding style issues. Replaced spaces with tabs. > > > > > > > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > > > > --- > > > > fs/btrfs/dev-replace.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > > > index 9efb94e..b2fe609 100644 > > > > --- a/fs/btrfs/dev-replace.c > > > > +++ b/fs/btrfs/dev-replace.c > > > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > > > printk_in_rcu(KERN_INFO > > > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > > > > src_device->missing ? "<missing disk>" : > > > > - rcu_str_deref(src_device->name), > > > > + rcu_str_deref(src_device->name), > > > > > > What's the change here? I don't think we need to fix whitespace, this makes > > > searching in patch history more tedious, namely in case where the code looks > > > exactly the same before and after the patch. > > > > > > The style issues should be best fixed when the patch is about to be > > > merged, doing it later like this is kind of not welcome, speaking for > > > myself. There are lots of opportunities to do real code cleanups. > > > > > > Whitespace changes are just noise, we don't need them at this point of > > > development phase of btrfs. > > > > > > > > > david > > > > I replaced the spaces with tabs, as the kernel coding style suggests. > > I repeat: > > Whitespace changes are just noise, we don't need them at this point of > development phase of btrfs. > > david Okay then ignore the patch.
On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote: > > > I replaced the spaces with tabs, as the kernel coding style suggests. > > > > I repeat: > > > > Whitespace changes are just noise, we don't need them at this point of > > development phase of btrfs. > > > > david > > Okay then ignore the patch. Well, this also applies to patches with subject 'BTRFS: fixed coding style issues' -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba wrote: > On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote: > > > > I replaced the spaces with tabs, as the kernel coding style suggests. > > > > > > I repeat: > > > > > > Whitespace changes are just noise, we don't need them at this point of > > > development phase of btrfs. > > > > > > david > > > > Okay then ignore the patch. > > Well, this also applies to patches with subject 'BTRFS: fixed coding style issues' Okay then.
David Sterba wrote: > On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: > > Fixed three coding style issues. Replaced spaces with tabs. > > > > Signed-off-by: Aldo Iljazi <mail@aldo.io> > > --- > > fs/btrfs/dev-replace.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c > > index 9efb94e..b2fe609 100644 > > --- a/fs/btrfs/dev-replace.c > > +++ b/fs/btrfs/dev-replace.c > > @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, > > printk_in_rcu(KERN_INFO > > "btrfs: dev_replace from %s (devid %llu) to %s) started\n", > > src_device->missing ? "<missing disk>" : > > - rcu_str_deref(src_device->name), > > + rcu_str_deref(src_device->name), > > What's the change here? I don't think we need to fix whitespace, this > makes searching in patch history more boring, namely in case where the > code looks exactly the same before and after the patch. > > The style issues should be best fixed when the patch is about to be > merged, doing it later like this is kind of not welcome, speaking for > myself. There are lots of opportunities to do real code cleanups. > > > david Okay thanks.
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index 9efb94e..b2fe609 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c @@ -377,7 +377,7 @@ int btrfs_dev_replace_start(struct btrfs_root *root, printk_in_rcu(KERN_INFO "btrfs: dev_replace from %s (devid %llu) to %s) started\n", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); @@ -500,7 +500,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, printk_in_rcu(KERN_ERR "btrfs: btrfs_scrub_dev(%s, %llu, %s) failed %d\n", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name), scrub_ret); btrfs_dev_replace_unlock(dev_replace); @@ -515,7 +515,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, printk_in_rcu(KERN_INFO "btrfs: dev_replace from %s (devid %llu) to %s) finished\n", src_device->missing ? "<missing disk>" : - rcu_str_deref(src_device->name), + rcu_str_deref(src_device->name), src_device->devid, rcu_str_deref(tgt_device->name)); tgt_device->is_tgtdev_for_dev_replace = 0;
Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi <mail@aldo.io> --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)