| Message ID | 1244462603-12793-1-git-send-email-tero.kristo@nokia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kevin Hilman |
| Headers | show |
Hi Tero, You should also ensure that the CKE signals mux settings are correct cf. an example for Overo at http://patchwork.kernel.org/patch/28598/. Note: the config option CONFIG_OMAP_MUX must be set for the omap_cfg* functions to have any effect. Regards, Jean On Monday 08 June 2009 14:03:23 Tero Kristo wrote: > From: Tero Kristo <tero.kristo@nokia.com> > > Applies on top of PM branch. > > Signed-off-by: Tero Kristo <tero.kristo@nokia.com> > --- > arch/arm/mach-omap2/board-rx51.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-rx51.c > b/arch/arm/mach-omap2/board-rx51.c index 3e4b7f8..7ab8a74 100644 > --- a/arch/arm/mach-omap2/board-rx51.c > +++ b/arch/arm/mach-omap2/board-rx51.c > @@ -61,7 +61,11 @@ static struct omap_bluetooth_config rx51_bt_config = { > > static void __init rx51_init_irq(void) > { > - omap2_init_common_hw(rx51_get_sdram_timings(), NULL, > + struct omap_sdrc_params *sdrc_params; > + > + sdrc_params = rx51_get_sdram_timings(); > + > + omap2_init_common_hw(sdrc_params, sdrc_params, > omap3_mpu_rate_table, > omap3_dsp_rate_table, > omap3_l3_rate_table); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>-----Original Message----- >From: ext Jean Pihet [mailto:jpihet@mvista.com] >Sent: 08 June, 2009 16:06 >To: Kristo Tero (Nokia-D/Tampere) >Cc: linux-omap@vger.kernel.org >Subject: Re: [PATCH] RX51: Add support for SDRAM chip select 1 > >Hi Tero, > >You should also ensure that the CKE signals mux settings are >correct cf. an example for Overo at >http://patchwork.kernel.org/patch/28598/. Our bootloader configures the pads, I just double checked that it also changes CKE pads to proper config. The patch looks good otherwise? I tested this on RX51 HW and it works ok. -Tero > >Note: the config option CONFIG_OMAP_MUX must be set for the >omap_cfg* functions to have any effect. > >Regards, >Jean > >On Monday 08 June 2009 14:03:23 Tero Kristo wrote: >> From: Tero Kristo <tero.kristo@nokia.com> >> >> Applies on top of PM branch. >> >> Signed-off-by: Tero Kristo <tero.kristo@nokia.com> >> --- >> arch/arm/mach-omap2/board-rx51.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/board-rx51.c >> b/arch/arm/mach-omap2/board-rx51.c index 3e4b7f8..7ab8a74 100644 >> --- a/arch/arm/mach-omap2/board-rx51.c >> +++ b/arch/arm/mach-omap2/board-rx51.c >> @@ -61,7 +61,11 @@ static struct omap_bluetooth_config >rx51_bt_config >> = { >> >> static void __init rx51_init_irq(void) { >> - omap2_init_common_hw(rx51_get_sdram_timings(), NULL, >> + struct omap_sdrc_params *sdrc_params; >> + >> + sdrc_params = rx51_get_sdram_timings(); >> + >> + omap2_init_common_hw(sdrc_params, sdrc_params, >> omap3_mpu_rate_table, >> omap3_dsp_rate_table, >> omap3_l3_rate_table); > > >-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c index 3e4b7f8..7ab8a74 100644 --- a/arch/arm/mach-omap2/board-rx51.c +++ b/arch/arm/mach-omap2/board-rx51.c @@ -61,7 +61,11 @@ static struct omap_bluetooth_config rx51_bt_config = { static void __init rx51_init_irq(void) { - omap2_init_common_hw(rx51_get_sdram_timings(), NULL, + struct omap_sdrc_params *sdrc_params; + + sdrc_params = rx51_get_sdram_timings(); + + omap2_init_common_hw(sdrc_params, sdrc_params, omap3_mpu_rate_table, omap3_dsp_rate_table, omap3_l3_rate_table);