| Message ID | 20131106211352.GA24006@www.outflux.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 6, 2013 at 1:13 PM, Kees Cook <keescook@chromium.org> wrote: > Given recent discussions about the lack of OABI in the wild, switch > CONFIG_OABI_COMPAT to off-by-default to encourage more system builders > to avoid it. > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > arch/arm/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 1ad6fb6c094d..4ace7f33e8a1 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1728,7 +1728,7 @@ config AEABI > config OABI_COMPAT > bool "Allow old ABI binaries to run with this kernel (EXPERIMENTAL)" > depends on AEABI && !THUMB2_KERNEL > - default y > + default n Nit: "default n" is the default default. So you can just delete the line instead. -Olof
On Wed, 6 Nov 2013, Kees Cook wrote: > Given recent discussions about the lack of OABI in the wild, switch > CONFIG_OABI_COMPAT to off-by-default to encourage more system builders > to avoid it. > > Signed-off-by: Kees Cook <keescook@chromium.org> Acked-by: Nicolas Pitre <nico@linaro.org> > --- > arch/arm/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 1ad6fb6c094d..4ace7f33e8a1 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1728,7 +1728,7 @@ config AEABI > config OABI_COMPAT > bool "Allow old ABI binaries to run with this kernel (EXPERIMENTAL)" > depends on AEABI && !THUMB2_KERNEL > - default y > + default n > help > This option preserves the old syscall interface along with the > new (ARM EABI) one. It also provides a compatibility layer to > @@ -1740,7 +1740,7 @@ config OABI_COMPAT > can say N here. If this option is not selected and you attempt > to execute a legacy ABI binary then the result will be > UNPREDICTABLE (in fact it can be predicted that it won't work > - at all). If in doubt say Y. > + at all). If in doubt say N. > > config ARCH_HAS_HOLES_MEMORYMODEL > bool > -- > 1.7.9.5 > > > -- > Kees Cook > Chrome OS Security > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
On Fri, Nov 8, 2013 at 3:13 PM, Nicolas Pitre <nico@fluxnic.net> wrote: > On Wed, 6 Nov 2013, Kees Cook wrote: > >> Given recent discussions about the lack of OABI in the wild, switch >> CONFIG_OABI_COMPAT to off-by-default to encourage more system builders >> to avoid it. >> >> Signed-off-by: Kees Cook <keescook@chromium.org> > > Acked-by: Nicolas Pitre <nico@linaro.org> Yeah, sorry for the delay: Acked-by: Olof Johansson <olof@lixom.net (send to the patch tracker :) -Olof
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1ad6fb6c094d..4ace7f33e8a1 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1728,7 +1728,7 @@ config AEABI config OABI_COMPAT bool "Allow old ABI binaries to run with this kernel (EXPERIMENTAL)" depends on AEABI && !THUMB2_KERNEL - default y + default n help This option preserves the old syscall interface along with the new (ARM EABI) one. It also provides a compatibility layer to @@ -1740,7 +1740,7 @@ config OABI_COMPAT can say N here. If this option is not selected and you attempt to execute a legacy ABI binary then the result will be UNPREDICTABLE (in fact it can be predicted that it won't work - at all). If in doubt say Y. + at all). If in doubt say N. config ARCH_HAS_HOLES_MEMORYMODEL bool
Given recent discussions about the lack of OABI in the wild, switch CONFIG_OABI_COMPAT to off-by-default to encourage more system builders to avoid it. Signed-off-by: Kees Cook <keescook@chromium.org> --- arch/arm/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)