| Message ID | 1383999839-3339-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Nov 09, 2013 at 01:23:59PM +0100, Laurent Pinchart wrote: > The device is configured to generate an active-low interrupt signal that > needs to be acknowledged by the host. Configure the IRQ to trigger on > low level. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks, I have queued this up.
On Sat, Nov 09, 2013 at 01:23:59PM +0100, Laurent Pinchart wrote: > The device is configured to generate an active-low interrupt signal that > needs to be acknowledged by the host. Configure the IRQ to trigger on > low level. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index aef425f..04e9d49 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -95,7 +95,7 @@ > compatible = "sitronix,st1232"; > reg = <0x55>; > interrupt-parent = <&irqpin1>; > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ > + interrupts = <2 IRQ_TYPE_LOW_LEVEL>; I believe this should be IRQ_TYPE_LEVEL_LOW. I have dequeued this patch for now. > pinctrl-0 = <&st1232_pins>; > pinctrl-names = "default"; > gpios = <&pfc 166 GPIO_ACTIVE_LOW>; > -- > 1.8.1.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Hi Simon, On Tuesday 19 November 2013 11:56:29 Simon Horman wrote: > On Sat, Nov 09, 2013 at 01:23:59PM +0100, Laurent Pinchart wrote: > > The device is configured to generate an active-low interrupt signal that > > needs to be acknowledged by the host. Configure the IRQ to trigger on > > low level. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index > > aef425f..04e9d49 100644 > > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > @@ -95,7 +95,7 @@ > > compatible = "sitronix,st1232"; > > reg = <0x55>; > > interrupt-parent = <&irqpin1>; > > - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ > > + interrupts = <2 IRQ_TYPE_LOW_LEVEL>; > > I believe this should be IRQ_TYPE_LEVEL_LOW. > > I have dequeued this patch for now. My bad, I've tested level low trigger first, then falling edge trigger, and switched back to low level without recompiling the patch. Sorry about that, I'll resend now. > > pinctrl-0 = <&st1232_pins>; > > pinctrl-names = "default"; > > gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index aef425f..04e9d49 100644 --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts @@ -95,7 +95,7 @@ compatible = "sitronix,st1232"; reg = <0x55>; interrupt-parent = <&irqpin1>; - interrupts = <2 IRQ_TYPE_NONE>; /* IRQ10: hwirq 2 on irqpin1 */ + interrupts = <2 IRQ_TYPE_LOW_LEVEL>; pinctrl-0 = <&st1232_pins>; pinctrl-names = "default"; gpios = <&pfc 166 GPIO_ACTIVE_LOW>;
The device is configured to generate an active-low interrupt signal that needs to be acknowledged by the host. Configure the IRQ to trigger on low level. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)