[1/6] radio-mr800.c: missing mutex include

Commit Message

Andrew Morton June 10, 2009, 7:44 p.m. UTC

From: Alessio Igor Bogani <[e-mail]>

radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
pulled in indirectly by one of the headers it already includes, the right
thing is to include it directly.

Signed-off-by: Alessio Igor Bogani <[e-mail]>
Cc: Mauro Carvalho Chehab <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 drivers/media/radio/radio-mr800.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Alexey Klimov June 10, 2009, 11:21 p.m. UTC | #1

On Wed, Jun 10, 2009 at 11:44 PM, <[e-mail]> wrote:
> From: Alessio Igor Bogani <[e-mail]>
>
> radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> pulled in indirectly by one of the headers it already includes, the right
> thing is to include it directly.

It was already applied to v4l-dvb tree (and probably to v4l git tree).
Thanks,

Andrew Morton June 10, 2009, 11:23 p.m. UTC | #2

On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <[e-mail]> wrote:

> On Wed, Jun 10, 2009 at 11:44 PM, <[e-mail]> wrote:
> > From: Alessio Igor Bogani <[e-mail]>
> >
> > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > pulled in indirectly by one of the headers it already includes, the right
> > thing is to include it directly.
> 
> It was already applied to v4l-dvb tree (and probably to v4l git tree).

It isn't in today's linux-next.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mauro Carvalho Chehab June 11, 2009, 12:36 a.m. UTC | #3

Em Wed, 10 Jun 2009 16:23:44 -0700
Andrew Morton <[e-mail]> escreveu:

> On Thu, 11 Jun 2009 03:21:36 +0400 Alexey Klimov <[e-mail]> wrote:
> 
> > On Wed, Jun 10, 2009 at 11:44 PM, <[e-mail]> wrote:
> > > From: Alessio Igor Bogani <[e-mail]>
> > >
> > > radio-mr800.c uses struct mutex, so while <linux/mutex.h> seems to be
> > > pulled in indirectly by one of the headers it already includes, the right
> > > thing is to include it directly.
> > 
> > It was already applied to v4l-dvb tree (and probably to v4l git tree).
> 
> It isn't in today's linux-next.

Hi Andrew,

Thanks for remind us about those 6 patches. I'll double check if those are
already on my staging tree. If they aren't I'll apply or comment.

Since I'm currently in the proccess updating my trees, I should be adding 
several pending patches on my -git tree, probably in time for tomorrow's
linux-next tree.



Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -puN drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include drivers/media/radio/radio-mr800.c
--- a/drivers/media/radio/radio-mr800.c~radio-mr800c-missing-mutex-include
+++ a/drivers/media/radio/radio-mr800.c
@@ -64,6 +64,7 @@ 
 #include <media/v4l2-ioctl.h>
 #include <linux/usb.h>
 #include <linux/version.h>	/* for KERNEL_VERSION MACRO */
+#include <linux/mutex.h>
 
 /* driver and module definitions */
 #define DRIVER_AUTHOR "Alexey Klimov <[e-mail]>"