| Message ID | 527BB695.9040209@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 7 Nov 2013, Benjamin Tissoires wrote: > Ok, thanks for the report. Could you please test the following patch > which should solve your problem (hopefully)? James, do you happen to have testing results please? > > Cheers, > Benjamin > > -- > > >From 54b332b992da1666abe7180b6cecd313c864e0b7 Mon Sep 17 00:00:00 2001 > From: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Date: Thu, 7 Nov 2013 10:46:48 -0500 > Subject: [PATCH] HID: appleir: force input to be set > > Some weird remotes are not correctly creating the input device. Their > report descriptor starts with: > 0x06, 0x00, 0xff, // Usage Page (Vendor Defined Page 1) 0 > 0xa1, 0x01, // Collection (Application) 3 > > whereas others (which are correctly handled) start with: > 0x05, 0x0c, // Usage Page (Consumer Devices) 0 > 0x09, 0x01, // Usage (Consumer Control) 2 > 0xa1, 0x01, // Collection (Application) 4 > > The rest of the report descriptor is the same. > > Adding the quirk HID_QUIRK_HIDINPUT_FORCE forces hid-input to allocate > the inputs, and everything should be ok. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > --- > drivers/hid/hid-appleir.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c > index a42e6a3..0e6a42d 100644 > --- a/drivers/hid/hid-appleir.c > +++ b/drivers/hid/hid-appleir.c > @@ -297,6 +297,9 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id) > > appleir->hid = hid; > > + /* force input as some remotes bypass the input registration */ > + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; > + > spin_lock_init(&appleir->lock); > setup_timer(&appleir->key_up_timer, > key_up_tick, (unsigned long) appleir); >
On Thu, 7 Nov 2013, Benjamin Tissoires wrote: > >> [ adding some more CCs ] > >> > >> Okay, so apparently we didn't register with input, but only hiddev / > >> hidraw. > >> > >> appleir 0003:05AC:8240.0005: hiddev0,hidraw4: USB HID v1.11 Device [Apple Computer, Inc. IR Receiver] on usb-0000:00:1d.3-2/input0 > >> > >> Therefore ->input_configured() callback has never been called, and thus we > >> oops due to appleir->input_dev being NULL when the first raw event is > >> reported. > >> > >> Could you please provide report descriptor of the device? > >> > >> The driver apparently relies on it being registered with hid-input, but > >> for some reason that doesn't happen. > > > > Here is the relevant lsusb output that I think contains what you're > > asking for (I had to unbind usbhid for it to include the descriptor): > > > > Bus 005 Device 003: ID 05ac:8240 Apple, Inc. Built-in IR Receiver > > Device Descriptor: > > bLength 18 > > bDescriptorType 1 > > bcdUSB 2.00 > > ... > > Ok, thanks for the report. Could you please test the following patch > which should solve your problem (hopefully)? James, any reults from testing Benjamin's patch, please?
On Tue, Nov 19, 2013 at 10:33 PM, Jiri Kosina <jkosina@suse.cz> wrote: > On Thu, 7 Nov 2013, Benjamin Tissoires wrote: > >> >> [ adding some more CCs ] >> >> >> >> Okay, so apparently we didn't register with input, but only hiddev / >> >> hidraw. >> >> >> >> appleir 0003:05AC:8240.0005: hiddev0,hidraw4: USB HID v1.11 Device [Apple Computer, Inc. IR Receiver] on usb-0000:00:1d.3-2/input0 >> >> >> >> Therefore ->input_configured() callback has never been called, and thus we >> >> oops due to appleir->input_dev being NULL when the first raw event is >> >> reported. >> >> >> >> Could you please provide report descriptor of the device? >> >> >> >> The driver apparently relies on it being registered with hid-input, but >> >> for some reason that doesn't happen. >> > >> > Here is the relevant lsusb output that I think contains what you're >> > asking for (I had to unbind usbhid for it to include the descriptor): >> > >> > Bus 005 Device 003: ID 05ac:8240 Apple, Inc. Built-in IR Receiver >> > Device Descriptor: >> > bLength 18 >> > bDescriptorType 1 >> > bcdUSB 2.00 >> > ... >> >> Ok, thanks for the report. Could you please test the following patch >> which should solve your problem (hopefully)? > > James, > > any reults from testing Benjamin's patch, please? Sorry for the delays in testing out the patch. I have tried a kernel with the patch applied, and can no longer reproduce the oops. The hid-appleir driver appears to be working correctly, generating key press events in response to the remote, and LIRC functions correctly via hiddev. Thanks for the everyone's help with this. James. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 21 Nov 2013, James Henstridge wrote: > Sorry for the delays in testing out the patch. I have tried a kernel > with the patch applied, and can no longer reproduce the oops. The > hid-appleir driver appears to be working correctly, generating key > press events in response to the remote, and LIRC functions correctly > via hiddev. > > Thanks for the everyone's help with this. Applied, thanks.
On Thu, Nov 21, 2013 at 09:59:27AM +0100, Jiri Kosina wrote: > On Thu, 21 Nov 2013, James Henstridge wrote: > > > Sorry for the delays in testing out the patch. I have tried a kernel > > with the patch applied, and can no longer reproduce the oops. The > > hid-appleir driver appears to be working correctly, generating key > > press events in response to the remote, and LIRC functions correctly > > via hiddev. > > > > Thanks for the everyone's help with this. > > Applied, thanks. Hi Jiri, Since this fixes an issue in a 3.11 kernel, could you please tag this commit for stable>=3.11? If its too late, I can send the request to stable@ once this patch is merged. Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 21 Nov 2013, Luis Henriques wrote: > > > Sorry for the delays in testing out the patch. I have tried a kernel > > > with the patch applied, and can no longer reproduce the oops. The > > > hid-appleir driver appears to be working correctly, generating key > > > press events in response to the remote, and LIRC functions correctly > > > via hiddev. > > > > > > Thanks for the everyone's help with this. > > > > Applied, thanks. > > Hi Jiri, > > Since this fixes an issue in a 3.11 kernel, could you please tag this > commit for stable>=3.11? If its too late, I can send the request to > stable@ once this patch is merged. Thanks for noticing. It's too late to add the tag, so if you submit it to -stable once it's in Linus' tree, I'll appreciate it; otherwise I'll try to remember to do that myself.
On Fri, Nov 22, 2013 at 01:39:47PM +0100, Jiri Kosina wrote: > On Thu, 21 Nov 2013, Luis Henriques wrote: > > > > > Sorry for the delays in testing out the patch. I have tried a kernel > > > > with the patch applied, and can no longer reproduce the oops. The > > > > hid-appleir driver appears to be working correctly, generating key > > > > press events in response to the remote, and LIRC functions correctly > > > > via hiddev. > > > > > > > > Thanks for the everyone's help with this. > > > > > > Applied, thanks. > > > > Hi Jiri, > > > > Since this fixes an issue in a 3.11 kernel, could you please tag this > > commit for stable>=3.11? If its too late, I can send the request to > > stable@ once this patch is merged. > > Thanks for noticing. It's too late to add the tag, so if you submit it to > -stable once it's in Linus' tree, I'll appreciate it; otherwise I'll try > to remember to do that myself. Sure, no problem. I'll keep an eye on this. Cheers, -- Luis -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c index a42e6a3..0e6a42d 100644 --- a/drivers/hid/hid-appleir.c +++ b/drivers/hid/hid-appleir.c @@ -297,6 +297,9 @@ static int appleir_probe(struct hid_device *hid, const struct hid_device_id *id) appleir->hid = hid; + /* force input as some remotes bypass the input registration */ + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; + spin_lock_init(&appleir->lock); setup_timer(&appleir->key_up_timer, key_up_tick, (unsigned long) appleir);