diff mbox

soc_camera: Fix debug output of supported formats count

Message ID 77e3600851e692cb4ee9.1238662505@SCT-Book (mailing list archive)
State RFC
Headers show

Commit Message

Stefan Herbrechtsmeier April 2, 2009, 8:55 a.m. UTC 
The supported formats count must be set to 0 after debug output
right before the second pass.

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Guennadi Liakhovetski June 11, 2009, 10:59 a.m. UTC | #1 
On Thu, 2 Apr 2009, Stefan Herbrechtsmeier wrote:

> The supported formats count must be set to 0 after debug output
> right before the second pass.
> 

Hi Stefan, could you please resend with your Sob?

Thanks
Guennadi

> diff --git a/linux/drivers/media/video/soc_camera.c b/linux/drivers/media/video/soc_camera.c
> --- a/linux/drivers/media/video/soc_camera.c
> +++ b/linux/drivers/media/video/soc_camera.c
> @@ -236,11 +236,11 @@ static int soc_camera_init_user_formats(
>  		return -ENOMEM;
>  
>  	icd->num_user_formats = fmts;
> -	fmts = 0;
>  
>  	dev_dbg(&icd->dev, "Found %d supported formats.\n", fmts);
>  
>  	/* Second pass - actually fill data formats */
> +	fmts = 0;
>  	for (i = 0; i < icd->num_formats; i++)
>  		if (!ici->ops->get_formats) {
>  			icd->user_formats[i].host_fmt = icd->formats + i;
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/linux/drivers/media/video/soc_camera.c b/linux/drivers/media/video/soc_camera.c
--- a/linux/drivers/media/video/soc_camera.c
+++ b/linux/drivers/media/video/soc_camera.c
@@ -236,11 +236,11 @@  static int soc_camera_init_user_formats(
 		return -ENOMEM;
 
 	icd->num_user_formats = fmts;
-	fmts = 0;
 
 	dev_dbg(&icd->dev, "Found %d supported formats.\n", fmts);
 
 	/* Second pass - actually fill data formats */
+	fmts = 0;
 	for (i = 0; i < icd->num_formats; i++)
 		if (!ici->ops->get_formats) {
 			icd->user_formats[i].host_fmt = icd->formats + i;