diff mbox

[11/15] pwm: pwm-renesas-tpu: Enable driver compilation with COMPILE_TEST

Message ID 1385515117-23664-12-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laurent Pinchart Nov. 27, 2013, 1:18 a.m. UTC
This helps increasing build testing coverage.

Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Simon Horman <horms@verge.net.au>
---
 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thierry Reding Nov. 29, 2013, 10:53 a.m. UTC | #1
On Wed, Nov 27, 2013 at 02:18:33AM +0100, Laurent Pinchart wrote:
> This helps increasing build testing coverage.
> 
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Simon Horman <horms@verge.net.au>
> ---
>  drivers/pwm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I'm not sure if this has been answered in any of the various subthreads
before. I've tried to read through them, but I may have missed some. It
was mentioned that iowrite16() wasn't supported on all architectures;
won't this possibly cause randconfig autobuilders to break?

Thierry
Laurent Pinchart Nov. 29, 2013, 1:51 p.m. UTC | #2
Hi Thierry,

On Friday 29 November 2013 11:53:54 Thierry Reding wrote:
> On Wed, Nov 27, 2013 at 02:18:33AM +0100, Laurent Pinchart wrote:
> > This helps increasing build testing coverage.
> > 
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: linux-pwm@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > Acked-by: Simon Horman <horms@verge.net.au>
> > ---
> > 
> >  drivers/pwm/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I'm not sure if this has been answered in any of the various subthreads
> before. I've tried to read through them, but I may have missed some. It
> was mentioned that iowrite16() wasn't supported on all architectures;
> won't this possibly cause randconfig autobuilders to break?

That's possible (although it has been reported to me that the situation got 
fixed on arch/cris in v3.12), but the only way to find out is to try it. That 
would be a bug in the architecture, and it should then get fixed.
Laurent Pinchart Dec. 11, 2013, 12:49 p.m. UTC | #3
Hi Thierry,

On Friday 29 November 2013 14:51:25 Laurent Pinchart wrote:
> On Friday 29 November 2013 11:53:54 Thierry Reding wrote:
> > On Wed, Nov 27, 2013 at 02:18:33AM +0100, Laurent Pinchart wrote:
> > > This helps increasing build testing coverage.
> > > 
> > > Cc: Thierry Reding <thierry.reding@gmail.com>
> > > Cc: linux-pwm@vger.kernel.org
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > Acked-by: Simon Horman <horms@verge.net.au>
> > > ---
> > > 
> > >  drivers/pwm/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I'm not sure if this has been answered in any of the various subthreads
> > before. I've tried to read through them, but I may have missed some. It
> > was mentioned that iowrite16() wasn't supported on all architectures;
> > won't this possibly cause randconfig autobuilders to break?
> 
> That's possible (although it has been reported to me that the situation got
> fixed on arch/cris in v3.12), but the only way to find out is to try it.
> That would be a bug in the architecture, and it should then get fixed.

Would you consider picking this patch up for v3.14 ?
Thierry Reding Dec. 12, 2013, 12:37 p.m. UTC | #4
On Wed, Nov 27, 2013 at 02:18:33AM +0100, Laurent Pinchart wrote:
> This helps increasing build testing coverage.
> 
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Simon Horman <horms@verge.net.au>
> ---
>  drivers/pwm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry
diff mbox

Patch

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index eece329..5de6fcf 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -139,7 +139,7 @@  config PWM_PXA
 
 config PWM_RENESAS_TPU
 	tristate "Renesas TPU PWM support"
-	depends on ARCH_SHMOBILE
+	depends on ARCH_SHMOBILE || COMPILE_TEST
 	help
 	  This driver exposes the Timer Pulse Unit (TPU) PWM controller found
 	  in Renesas chips through the PWM API.