diff mbox

[2/4] ARM: tegra: enable I2C controllers on Venice2

Message ID 1386196016-25128-2-git-send-email-swarren@wwwdotorg.org (mailing list archive)
State New, archived
Headers show

Commit Message

Stephen Warren Dec. 4, 2013, 10:26 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

Enable all the I2C controllers that are wired up on Venice2. I don't
know the correct I2C bus clock rates, so set them all to a conservative
100KHz for now.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/boot/dts/tegra124-venice2.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Thierry Reding Dec. 6, 2013, 3:20 p.m. UTC | #1 
On Wed, Dec 04, 2013 at 03:26:54PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Enable all the I2C controllers that are wired up on Venice2. I don't
> know the correct I2C bus clock rates, so set them all to a conservative
> 100KHz for now.

Perhaps we should only enable those that we really need? I currently
use these in my local tree:

	i2c@7000c400: for the trackpad
	i2c@7000c700: for HDMI DDC
	i2c@7000d000: for the PMIC

Thierry
Stephen Warren Dec. 6, 2013, 5:42 p.m. UTC | #2 
On 12/06/2013 08:20 AM, Thierry Reding wrote:
> On Wed, Dec 04, 2013 at 03:26:54PM -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>> 
>> Enable all the I2C controllers that are wired up on Venice2. I
>> don't know the correct I2C bus clock rates, so set them all to a
>> conservative 100KHz for now.
> 
> Perhaps we should only enable those that we really need? I
> currently use these in my local tree:
> 
> i2c@7000c400: for the trackpad i2c@7000c700: for HDMI DDC 
> i2c@7000d000: for the PMIC

All of these I2C buses are used for something. Missing from your list
are e.g.:

i2c@7000c000 Audio CODEC, temperature sensor
i2c@7000c500 TPM
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
index 098d0b2081bf..7aa711b7b4e3 100644
--- a/arch/arm/boot/dts/tegra124-venice2.dts
+++ b/arch/arm/boot/dts/tegra124-venice2.dts
@@ -14,6 +14,31 @@ 
 		status = "okay";
 	};
 
+	i2c@7000c000 {
+		status = "okay";
+		clock-frequency = <100000>;
+	};
+
+	i2c@7000c400 {
+		status = "okay";
+		clock-frequency = <100000>;
+	};
+
+	i2c@7000c500 {
+		status = "okay";
+		clock-frequency = <100000>;
+	};
+
+	i2c@7000c700 {
+		status = "okay";
+		clock-frequency = <100000>;
+	};
+
+	i2c@7000d000 {
+		status = "okay";
+		clock-frequency = <100000>;
+	};
+
 	pmc@7000e400 {
 		nvidia,invert-interrupt;
 		nvidia,suspend-mode = <1>;