| Message ID | 1387198338-10556-2-git-send-email-k.debski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 16 December 2013 06:22 PM, Kamil Debski wrote: > Adding devm_of_phy_get will allow to get phys by supplying the > device_node instead of by name. > > Signed-off-by: Kamil Debski <k.debski@samsung.com> > --- > drivers/phy/phy-core.c | 31 +++++++++++++++++++++++++++++++ > include/linux/phy/phy.h | 2 ++ > 2 files changed, 33 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 0107f71..d45ad87 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -450,6 +450,37 @@ struct phy *devm_phy_get(struct device *dev, const char *string) > EXPORT_SYMBOL_GPL(devm_phy_get); > > /** > + * devm_of_phy_get() - lookup and obtain a reference to a phy. > + * @dev: device that requests this phy > + * @np: node containing the phy > + * @con_id: name of the phy from device's point of view > + * > + * Gets the phy using phy_get(), and associates a device with it using %s/phy_get/of_phy_get > + * devres. On driver detach, release function is invoked on the devres data, > + * then, devres data is freed. > + */ > +struct phy *devm_of_phy_get(struct device *dev, struct device_node *np, > + const char *con_id) > +{ > + struct phy **ptr, *phy; > + > + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) > + return ERR_PTR(-ENOMEM); > + > + phy = of_phy_get(np, con_id); > + if (!IS_ERR(phy)) { > + *ptr = phy; > + devres_add(dev, ptr); > + } else { > + devres_free(ptr); > + } > + > + return phy; > +} > +EXPORT_SYMBOL_GPL(devm_of_phy_get); > + > +/** > * phy_create() - create a new phy > * @dev: device that is creating the new phy > * @ops: function pointers for performing phy operations > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index bcb6274..864914c 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -129,6 +129,8 @@ int phy_power_on(struct phy *phy); > int phy_power_off(struct phy *phy); > struct phy *phy_get(struct device *dev, const char *string); > struct phy *devm_phy_get(struct device *dev, const char *string); > +struct phy *devm_of_phy_get(struct device *dev, struct device_node *np, > + const char *con_id); > void phy_put(struct phy *phy); > void devm_phy_put(struct device *dev, struct phy *phy); > struct phy *of_phy_get(struct device_node *np, const char *con_id); Apart from that one minor comment, this patch series can go in. Thanks Kishon > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 0107f71..d45ad87 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -450,6 +450,37 @@ struct phy *devm_phy_get(struct device *dev, const char *string) EXPORT_SYMBOL_GPL(devm_phy_get); /** + * devm_of_phy_get() - lookup and obtain a reference to a phy. + * @dev: device that requests this phy + * @np: node containing the phy + * @con_id: name of the phy from device's point of view + * + * Gets the phy using phy_get(), and associates a device with it using + * devres. On driver detach, release function is invoked on the devres data, + * then, devres data is freed. + */ +struct phy *devm_of_phy_get(struct device *dev, struct device_node *np, + const char *con_id) +{ + struct phy **ptr, *phy; + + ptr = devres_alloc(devm_phy_release, sizeof(*ptr), GFP_KERNEL); + if (!ptr) + return ERR_PTR(-ENOMEM); + + phy = of_phy_get(np, con_id); + if (!IS_ERR(phy)) { + *ptr = phy; + devres_add(dev, ptr); + } else { + devres_free(ptr); + } + + return phy; +} +EXPORT_SYMBOL_GPL(devm_of_phy_get); + +/** * phy_create() - create a new phy * @dev: device that is creating the new phy * @ops: function pointers for performing phy operations diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index bcb6274..864914c 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -129,6 +129,8 @@ int phy_power_on(struct phy *phy); int phy_power_off(struct phy *phy); struct phy *phy_get(struct device *dev, const char *string); struct phy *devm_phy_get(struct device *dev, const char *string); +struct phy *devm_of_phy_get(struct device *dev, struct device_node *np, + const char *con_id); void phy_put(struct phy *phy); void devm_phy_put(struct device *dev, struct phy *phy); struct phy *of_phy_get(struct device_node *np, const char *con_id);
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski <k.debski@samsung.com> --- drivers/phy/phy-core.c | 31 +++++++++++++++++++++++++++++++ include/linux/phy/phy.h | 2 ++ 2 files changed, 33 insertions(+)