| Message ID | 1387258597-21866-3-git-send-email-wenyou.yang@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 17, 2013 at 01:36:36PM +0800, Wenyou Yang wrote: > +Required properties: > +- compatible: "active-semi,act8865" > +- reg: I2C slave address This needs to also document the regulators property, for example all the regulator names.
Hi Mark, > -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Tuesday, December 17, 2013 8:48 PM > To: Yang, Wenyou > Cc: lgirdwood@gmail.com; linux-kernel@vger.kernel.org; > grant.likely@linaro.org; rob.herring@calxeda.com; linux- > doc@vger.kernel.org; vpalatin@chromium.org; Ferre, Nicolas; > plagnioj@jcrosoft.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH 2/3 v2] regulator: act8865: add device tree binding > doc > > On Tue, Dec 17, 2013 at 01:36:36PM +0800, Wenyou Yang wrote: > > > +Required properties: > > +- compatible: "active-semi,act8865" > > +- reg: I2C slave address > > This needs to also document the regulators property, for example all the > regulator names. Add all the regulator name: The valid names for regulators are: DCDC_REG1, DCDC_REG2, DCDC_REG3, LDO_REG1, LDO_REG2, LDO_REG3, LDO_REG4. Best Regards, Wenyou Yang
diff --git a/Documentation/devicetree/bindings/regulator/act8865-regulator.txt b/Documentation/devicetree/bindings/regulator/act8865-regulator.txt new file mode 100644 index 0000000..04fc911 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/act8865-regulator.txt @@ -0,0 +1,56 @@ +ACT8865 regulator +------------------- + +Required properties: +- compatible: "active-semi,act8865" +- reg: I2C slave address + +Example: +-------- + + i2c1: i2c@f0018000 { + status = "okay"; + + pmic: act8865@5b { + compatible = "active-semi,act8865"; + reg = <0x5b>; + + regulators { + vcc_1v8_reg: DCDC_REG1 { + regulator-name = "DCDC_REG1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vcc_1v2_reg: DCDC_REG2 { + regulator-name = "DCDC_REG2"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1300000>; + regulator-suspend-mem-microvolt = <1150000>; + regulator-suspend-standby-microvolt = <1150000>; + regulator-always-on; + }; + + vcc_3v3_reg: DCDC_REG3 { + regulator-name = "DCDC_REG3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vddfuse_reg: LDO_REG4 { + regulator-name = "LDO_REG4"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + + vddana_reg: LDO_REG5 { + regulator-name = "LDO_REG5"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + }; + }; + };
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- .../bindings/regulator/act8865-regulator.txt | 56 ++++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/act8865-regulator.txt