| Message ID | 1387258597-21866-4-git-send-email-wenyou.yang@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 17, 2013 at 01:36:37PM +0800, Wenyou Yang wrote: > + vcc_1v8_reg: DCDC_REG1 { > + regulator-name = "DCDC_REG1"; The whole point of naming the regulators is to help users read kernel diagnostic output so the should normally be named after the supply in the schematic. If you're using the name of the supply on the PMIC you can just omit it since that's the default anyway and it's not adding extra information. Use something like VCC_1V8.
Hi Mark, > -----Original Message----- > From: Mark Brown [mailto:broonie@kernel.org] > Sent: Tuesday, December 17, 2013 8:38 PM > To: Yang, Wenyou > Cc: lgirdwood@gmail.com; linux-kernel@vger.kernel.org; > grant.likely@linaro.org; rob.herring@calxeda.com; linux- > doc@vger.kernel.org; vpalatin@chromium.org; Ferre, Nicolas; > plagnioj@jcrosoft.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH 3/3 v2] ARM: dts: sama5d3xcm: add the regulator > device node > > On Tue, Dec 17, 2013 at 01:36:37PM +0800, Wenyou Yang wrote: > > > + vcc_1v8_reg: DCDC_REG1 { > > + regulator-name = "DCDC_REG1"; > > The whole point of naming the regulators is to help users read kernel > diagnostic output so the should normally be named after the supply in > the schematic. If you're using the name of the supply on the PMIC you > can just omit it since that's the default anyway and it's not adding > extra information. Use something like VCC_1V8. Thanks a lot. Change regulator-name with VCC_1V8, VCC_1V2 ... which named after the supply in the schematic. Best Regards, Wenyou Yang
diff --git a/arch/arm/boot/dts/sama5d3xcm.dtsi b/arch/arm/boot/dts/sama5d3xcm.dtsi index 726a0f3..634adf5 100644 --- a/arch/arm/boot/dts/sama5d3xcm.dtsi +++ b/arch/arm/boot/dts/sama5d3xcm.dtsi @@ -38,6 +38,52 @@ macb0: ethernet@f0028000 { phy-mode = "rgmii"; }; + + i2c1: i2c@f0018000 { + pmic: act8865@5b { + compatible = "active-semi,act8865"; + reg = <0x5b>; + status = "disabled"; + + regulators { + vcc_1v8_reg: DCDC_REG1 { + regulator-name = "DCDC_REG1"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + + vcc_1v2_reg: DCDC_REG2 { + regulator-name = "DCDC_REG2"; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1300000>; + regulator-suspend-mem-microvolt = <1150000>; + regulator-suspend-standby-microvolt = <1150000>; + regulator-always-on; + }; + + vcc_3v3_reg: DCDC_REG3 { + regulator-name = "DCDC_REG3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vddfuse_reg: LDO_REG4 { + regulator-name = "LDO_REG4"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vddana_reg: LDO_REG5 { + regulator-name = "LDO_REG5"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + }; + }; + }; + }; }; nand0: nand@60000000 {
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> --- arch/arm/boot/dts/sama5d3xcm.dtsi | 46 +++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+)