| Message ID | 1387831563-13535-5-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote: > +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) > +{ > + *val = 0; > + return ssbi_read(context, reg, (u8 *)val, 1); > +} > +EXPORT_SYMBOL_GPL(ssbi_reg_read); > + > +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) > +{ > + return ssbi_write(context, reg, (u8 *)&val, 1); > +} > +EXPORT_SYMBOL_GPL(ssbi_reg_write); Not a big deal but could these just be inlined in the headers? -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/24, Mark Brown wrote: > On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote: > > > +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) > > +{ > > + *val = 0; > > + return ssbi_read(context, reg, (u8 *)val, 1); > > +} > > +EXPORT_SYMBOL_GPL(ssbi_reg_read); > > + > > +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) > > +{ > > + return ssbi_write(context, reg, (u8 *)&val, 1); > > +} > > +EXPORT_SYMBOL_GPL(ssbi_reg_write); > > Not a big deal but could these just be inlined in the headers? Sure, I can do that if I need to resend? The only benefit I see is two less symbols exported.
On Thu, Dec 26, 2013 at 11:41:33AM -0800, Stephen Boyd wrote: > On 12/24, Mark Brown wrote: > > Not a big deal but could these just be inlined in the headers? > Sure, I can do that if I need to resend? The only benefit I see > is two less symbols exported. It also means that everything will be marginally faster since there will be one less level of function call but yeah, there's little practical benefit - it's a stylistic thing rather than a practical one.
On Thu, 26 Dec 2013, Stephen Boyd wrote: > On 12/24, Mark Brown wrote: > > On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote: > > > > > +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) > > > +{ > > > + *val = 0; > > > + return ssbi_read(context, reg, (u8 *)val, 1); > > > +} > > > +EXPORT_SYMBOL_GPL(ssbi_reg_read); > > > + > > > +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) > > > +{ > > > + return ssbi_write(context, reg, (u8 *)&val, 1); > > > +} > > > +EXPORT_SYMBOL_GPL(ssbi_reg_write); > > > > Not a big deal but could these just be inlined in the headers? > > Sure, I can do that if I need to resend? The only benefit I see > is two less symbols exported. Yes please. After this review.
On 01/06/14 03:50, Lee Jones wrote: > On Thu, 26 Dec 2013, Stephen Boyd wrote: > >> On 12/24, Mark Brown wrote: >>> On Mon, Dec 23, 2013 at 12:46:00PM -0800, Stephen Boyd wrote: >>> >>>> +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) >>>> +{ >>>> + *val = 0; >>>> + return ssbi_read(context, reg, (u8 *)val, 1); >>>> +} >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_read); >>>> + >>>> +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) >>>> +{ >>>> + return ssbi_write(context, reg, (u8 *)&val, 1); >>>> +} >>>> +EXPORT_SYMBOL_GPL(ssbi_reg_write); >>> Not a big deal but could these just be inlined in the headers? >> Sure, I can do that if I need to resend? The only benefit I see >> is two less symbols exported. > Yes please. After this review. > Ok done. Just waiting for you to reply on patch 3 until I resend.
diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c index b78942e..c5d270f 100644 --- a/drivers/mfd/ssbi.c +++ b/drivers/mfd/ssbi.c @@ -269,6 +269,19 @@ int ssbi_write(struct device *dev, u16 addr, const u8 *buf, int len) } EXPORT_SYMBOL_GPL(ssbi_write); +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val) +{ + *val = 0; + return ssbi_read(context, reg, (u8 *)val, 1); +} +EXPORT_SYMBOL_GPL(ssbi_reg_read); + +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val) +{ + return ssbi_write(context, reg, (u8 *)&val, 1); +} +EXPORT_SYMBOL_GPL(ssbi_reg_write); + static int ssbi_probe(struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; diff --git a/include/linux/ssbi.h b/include/linux/ssbi.h index bcbb642..b862f3d 100644 --- a/include/linux/ssbi.h +++ b/include/linux/ssbi.h @@ -20,4 +20,7 @@ int ssbi_write(struct device *dev, u16 addr, const u8 *buf, int len); int ssbi_read(struct device *dev, u16 addr, u8 *buf, int len); +int ssbi_reg_read(void *context, unsigned int reg, unsigned int *val); +int ssbi_reg_write(void *context, unsigned int reg, unsigned int val); + #endif
Add read and write helper functions that the pm8921-core driver can use to read and write ssbi regsiters via a "no-bus" regmap. Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/mfd/ssbi.c | 13 +++++++++++++ include/linux/ssbi.h | 3 +++ 2 files changed, 16 insertions(+)