diff mbox

[1/9] ARM: SAMSUNG: Remove platform dependency from samsung.S

Message ID 1388397640-720-2-git-send-email-tushar.behera@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Tushar Behera Dec. 30, 2013, 10 a.m. UTC
From: Sachin Kamat <sachin.kamat@linaro.org>

regs-serial.h only includes linux/serial_s3c.h. Include this
header directly in samsung.S to remove unnecessary platform
dependency.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/include/debug/samsung.S |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Dec. 31, 2013, 3:38 p.m. UTC | #1
On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote:
> From: Sachin Kamat <sachin.kamat@linaro.org>
> 
> regs-serial.h only includes linux/serial_s3c.h. Include this
> header directly in samsung.S to remove unnecessary platform
> dependency.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---

If you're forwarding on a patch from someone else you need to add your
Signed-off-by to it - that's important for the whole goal of tracking
licensing.
Tushar Behera Jan. 2, 2014, 2:55 a.m. UTC | #2
On 31 December 2013 21:08, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote:
>> From: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> regs-serial.h only includes linux/serial_s3c.h. Include this
>> header directly in samsung.S to remove unnecessary platform
>> dependency.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>
> If you're forwarding on a patch from someone else you need to add your
> Signed-off-by to it - that's important for the whole goal of tracking
> licensing.

Yeah, true. I forgot about that.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>

Kukjin,

While applying this series, can you please add my Signed-off-by?
kgene@kernel.org Jan. 4, 2014, 2:35 a.m. UTC | #3
Tushar Behera wrote:
> 
> On 31 December 2013 21:08, Mark Brown <broonie@kernel.org> wrote:
> > On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote:
> >> From: Sachin Kamat <sachin.kamat@linaro.org>
> >>
> >> regs-serial.h only includes linux/serial_s3c.h. Include this
> >> header directly in samsung.S to remove unnecessary platform
> >> dependency.
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> >> ---
> >
> > If you're forwarding on a patch from someone else you need to add your
> > Signed-off-by to it - that's important for the whole goal of tracking
> > licensing.
> 
> Yeah, true. I forgot about that.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> 
> Kukjin,
> 
> While applying this series, can you please add my Signed-off-by?
> 
Tushar, The 'Signed-off-by' is different with others ack, review or whatever. In my understanding it's a legal issue so you need to repost.

BTW, I think this series looks good to me but we don't need separated #1 to #8 patches because it's samething, so please squash them.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tushar Behera Jan. 6, 2014, 3:07 a.m. UTC | #4
On 4 January 2014 08:05,  <kgene@kernel.org> wrote:
> Tushar Behera wrote:
>>
>> On 31 December 2013 21:08, Mark Brown <broonie@kernel.org> wrote:
>> > On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote:
>> >> From: Sachin Kamat <sachin.kamat@linaro.org>
>> >>
>> >> regs-serial.h only includes linux/serial_s3c.h. Include this
>> >> header directly in samsung.S to remove unnecessary platform
>> >> dependency.
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >> ---
>> >
>> > If you're forwarding on a patch from someone else you need to add your
>> > Signed-off-by to it - that's important for the whole goal of tracking
>> > licensing.
>>
>> Yeah, true. I forgot about that.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>
>> Kukjin,
>>
>> While applying this series, can you please add my Signed-off-by?
>>
> Tushar, The 'Signed-off-by' is different with others ack, review or whatever. In my understanding it's a legal issue so you need to repost.
>
> BTW, I think this series looks good to me but we don't need separated #1 to #8 patches because it's samething, so please squash them.
>
> Thanks,
> Kukjin
>

Kukjin,

I will repost the series after updating the sob and squashing the
patches #2 to #9. I prefer to keep patch #1 separate as I would like
to retain Sachin's authorship for that patch.
diff mbox

Patch

diff --git a/arch/arm/include/debug/samsung.S b/arch/arm/include/debug/samsung.S
index f3a9cff..8d8d922 100644
--- a/arch/arm/include/debug/samsung.S
+++ b/arch/arm/include/debug/samsung.S
@@ -9,7 +9,7 @@ 
  * published by the Free Software Foundation.
 */
 
-#include <plat/regs-serial.h>
+#include <linux/serial_s3c.h>
 
 /* The S5PV210/S5PC110 implementations are as belows. */