| Message ID | 20140107154054.77daf1c5@hwh-ubuntu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 7, 2014 at 7:40 AM, Hyungwon Hwang <human.hwang@samsung.com> wrote: > tests/kmstest: support exynos > > Add exynos to list of kmstest supported modules. > > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > --- > libkms/internal.h | 2 ++ > libkms/linux.c | 4 ++++ > tests/kmstest/main.c | 1 + > 3 files changed, 7 insertions(+) Reviewed-by: Jakob Bornecrantz <jakob@vmware.com> Do you need somebody to push this to the drm repo? Cheers, Jakob.
2014? 1? 7? ???? Jakob Bornecrantz<wallbraker@gmail.com>?? ??: > On Tue, Jan 7, 2014 at 7:40 AM, Hyungwon Hwang <human.hwang@samsung.com> wrote: >> tests/kmstest: support exynos >> >> Add exynos to list of kmstest supported modules. >> >> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >> --- >> libkms/internal.h | 2 ++ >> libkms/linux.c | 4 ++++ >> tests/kmstest/main.c | 1 + >> 3 files changed, 7 insertions(+) > > Reviewed-by: Jakob Bornecrantz <jakob@vmware.com> > Hi Rob, Could you merge this patch? Signed-off-by: Inki dae <inki.samsung.com> Thanks. > Do you need somebody to push this to the drm repo? > > Cheers, Jakob. > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
2014? 1? 8? ???? Inki Dae<inki.dae@samsung.com>?? ??: > 2014? 1? 7? ???? Jakob Bornecrantz<wallbraker@gmail.com>?? ??: >> On Tue, Jan 7, 2014 at 7:40 AM, Hyungwon Hwang <human.hwang@samsung.com> wrote: >>> tests/kmstest: support exynos >>> > >>> Add exynos to list of kmstest supported modules. >>> >>> Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> >>> --- >>> libkms/internal.h | 2 ++ >>> libkms/linux.c | 4 ++++ >>> tests/kmstest/main.c | 1 + >>> 3 files changed, 7 insertions(+) >> >> Reviewed-by: Jakob Bornecrantz <jakob@vmware.com> >> > > Hi Rob, > > Could you merge this patch? > > Signed-off-by: Inki dae <inki.samsung.com> Oops, sorry for typo. :) signed-off-by: Inki Dae <inki.dae@samsung.com> Thanks. > > Thanks. > > >> Do you need somebody to push this to the drm repo? >> >> Cheers, Jakob. >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel >> >
On Tue, Jan 7, 2014 at 1:40 AM, Hyungwon Hwang <human.hwang@samsung.com> wrote: > tests/kmstest: support exynos > > Add exynos to list of kmstest supported modules. > > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > --- > libkms/internal.h | 2 ++ > libkms/linux.c | 4 ++++ > tests/kmstest/main.c | 1 + > 3 files changed, 7 insertions(+) > > diff --git a/libkms/internal.h b/libkms/internal.h > index 5e2501e..f831b57 100644 > --- a/libkms/internal.h > +++ b/libkms/internal.h > @@ -74,4 +74,6 @@ int nouveau_create(int fd, struct kms_driver **out); > > int radeon_create(int fd, struct kms_driver **out); > > +int exynos_create(int fd, struct kms_driver **out); > + exynos_create() does not seem to be defined anywhere.. am I missing a patch, or perhaps did you forget to 'git add' a file? BR, -R > #endif > diff --git a/libkms/linux.c b/libkms/linux.c > index fc4f205..2de0145 100644 > --- a/libkms/linux.c > +++ b/libkms/linux.c > @@ -115,6 +115,10 @@ linux_from_sysfs(int fd, struct kms_driver **out) > else if (!strcmp(name, "radeon")) > ret = radeon_create(fd, out); > #endif > +#ifdef HAVE_EXYNOS > + else if (!strcmp(name, "exynos")) > + ret = exynos_create(fd, out); > +#endif > else > ret = -ENOSYS; > > diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c > index 5df0a38..449d75f 100644 > --- a/tests/kmstest/main.c > +++ b/tests/kmstest/main.c > @@ -61,6 +61,7 @@ char *drivers[] = { > "radeon", > "nouveau", > "vmwgfx", > + "exynos", > NULL > }; > > -- > 1.7.9.5 > > --- > Hyungwon Hwang > Samsung SWC S/W Platform Team > Smasung Electronics > human.hwang@samsung.com > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hello Rob, On Wed, 08 Jan 2014 11:28:19 -0500 Rob Clark <robdclark@gmail.com> wrote: > On Tue, Jan 7, 2014 at 1:40 AM, Hyungwon Hwang > <human.hwang@samsung.com> wrote: > > tests/kmstest: support exynos > > > > Add exynos to list of kmstest supported modules. > > > > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > > --- > > libkms/internal.h | 2 ++ > > libkms/linux.c | 4 ++++ > > tests/kmstest/main.c | 1 + > > 3 files changed, 7 insertions(+) > > > > diff --git a/libkms/internal.h b/libkms/internal.h > > index 5e2501e..f831b57 100644 > > --- a/libkms/internal.h > > +++ b/libkms/internal.h > > @@ -74,4 +74,6 @@ int nouveau_create(int fd, struct kms_driver > > **out); > > > > int radeon_create(int fd, struct kms_driver **out); > > > > +int exynos_create(int fd, struct kms_driver **out); > > + > > exynos_create() does not seem to be defined anywhere.. am I missing a > patch, or perhaps did you forget to 'git add' a file? Sorry. It was my mistake. I forgot to include exynos implementation for KMS. I'll resend again. > > BR, > -R > > > > #endif > > diff --git a/libkms/linux.c b/libkms/linux.c > > index fc4f205..2de0145 100644 > > --- a/libkms/linux.c > > +++ b/libkms/linux.c > > @@ -115,6 +115,10 @@ linux_from_sysfs(int fd, struct kms_driver > > **out) else if (!strcmp(name, "radeon")) > > ret = radeon_create(fd, out); > > #endif > > +#ifdef HAVE_EXYNOS > > + else if (!strcmp(name, "exynos")) > > + ret = exynos_create(fd, out); > > +#endif > > else > > ret = -ENOSYS; > > > > diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c > > index 5df0a38..449d75f 100644 > > --- a/tests/kmstest/main.c > > +++ b/tests/kmstest/main.c > > @@ -61,6 +61,7 @@ char *drivers[] = { > > "radeon", > > "nouveau", > > "vmwgfx", > > + "exynos", > > NULL > > }; > > > > -- > > 1.7.9.5 > > > > --- > > Hyungwon Hwang > > Samsung SWC S/W Platform Team > > Smasung Electronics > > human.hwang@samsung.com > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel Thanks, Hyungwon Hwang --- Hyungwon Hwang Samsung SWC S/W Platform Team Smasung Electronics human.hwang@samsung.com
diff --git a/libkms/internal.h b/libkms/internal.h index 5e2501e..f831b57 100644 --- a/libkms/internal.h +++ b/libkms/internal.h @@ -74,4 +74,6 @@ int nouveau_create(int fd, struct kms_driver **out); int radeon_create(int fd, struct kms_driver **out); +int exynos_create(int fd, struct kms_driver **out); + #endif diff --git a/libkms/linux.c b/libkms/linux.c index fc4f205..2de0145 100644 --- a/libkms/linux.c +++ b/libkms/linux.c @@ -115,6 +115,10 @@ linux_from_sysfs(int fd, struct kms_driver **out) else if (!strcmp(name, "radeon")) ret = radeon_create(fd, out); #endif +#ifdef HAVE_EXYNOS + else if (!strcmp(name, "exynos")) + ret = exynos_create(fd, out); +#endif else ret = -ENOSYS; diff --git a/tests/kmstest/main.c b/tests/kmstest/main.c index 5df0a38..449d75f 100644 --- a/tests/kmstest/main.c +++ b/tests/kmstest/main.c @@ -61,6 +61,7 @@ char *drivers[] = { "radeon", "nouveau", "vmwgfx", + "exynos", NULL };
tests/kmstest: support exynos Add exynos to list of kmstest supported modules. Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> --- libkms/internal.h | 2 ++ libkms/linux.c | 4 ++++ tests/kmstest/main.c | 1 + 3 files changed, 7 insertions(+)