| Message ID | 1389714323-20130-15-git-send-email-eli@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Le mardi 14 janvier 2014 à 17:45 +0200, Eli Cohen a écrit : > Align to firmware specification. > Is it subject to change between various firmware revision ? If yes, it could of user interest to specify the base/current version of the applicable firmware. > Signed-off-by: Eli Cohen <eli@mellanox.com> > --- > include/linux/mlx5/device.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/device.h > index 1d05909..817a6fa 100644 > --- a/include/linux/mlx5/device.h > +++ b/include/linux/mlx5/device.h > @@ -849,8 +849,8 @@ struct mlx5_create_mkey_mbox_in { > struct mlx5_mkey_seg seg; > u8 rsvd1[16]; > __be32 xlat_oct_act_size; > - __be32 bsf_coto_act_size; > - u8 rsvd2[168]; > + __be32 rsvd2; For a reserved field, I think we don't care of it being be or le. > + u8 rsvd3[168]; > __be64 pas[0]; > }; > Regards.
On Tue, Jan 14, 2014 at 05:37:17PM +0100, Yann Droneaud wrote: > > Is it subject to change between various firmware revision ? > > If yes, it could of user interest to specify the base/current > version of the applicable firmware. The sizes never changed and this field was never used so I just redefined it as reserved. > > > @@ -849,8 +849,8 @@ struct mlx5_create_mkey_mbox_in { > > struct mlx5_mkey_seg seg; > > u8 rsvd1[16]; > > __be32 xlat_oct_act_size; > > - __be32 bsf_coto_act_size; > > - u8 rsvd2[168]; > > + __be32 rsvd2; > > For a reserved field, I think we don't care of it being be or le. > Right, so be is just as good as le. The "be" is a sort of reminder that driver/firmware interface is always big endian. > > + u8 rsvd3[168]; > > __be64 pas[0]; > > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/device.h index 1d05909..817a6fa 100644 --- a/include/linux/mlx5/device.h +++ b/include/linux/mlx5/device.h @@ -849,8 +849,8 @@ struct mlx5_create_mkey_mbox_in { struct mlx5_mkey_seg seg; u8 rsvd1[16]; __be32 xlat_oct_act_size; - __be32 bsf_coto_act_size; - u8 rsvd2[168]; + __be32 rsvd2; + u8 rsvd3[168]; __be64 pas[0]; };
Align to firmware specification. Signed-off-by: Eli Cohen <eli@mellanox.com> --- include/linux/mlx5/device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)