| Message ID | 2236505237-3336-1-git-send-email-shuah.kh@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wednesday, November 14, 2040 8:27 PM, Shuah Khan wrote: > > Convert drivers/video/backlight/class to use dev_pm_ops for power > management and remove Legacy PM ops hooks. With this change, rtc class There is still the typo. Please fix it. rtc class -> backlight class > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of > Legacy class->suspend/resume. When __device_suspend() runs call-backs, > it will find class->pm ops for the backlight class. > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com> > Cc: Shuah Khan <shuahkhan@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 14, 2040 at 04:27:17AM -0700, Shuah Khan wrote:
> ...
The clock on your computer might be running just a wee bit ahead.
Either that, or we're getting patches from the future.
David
On 08/09/2013 03:28 PM, David Brown wrote: > On Wed, Nov 14, 2040 at 04:27:17AM -0700, Shuah Khan wrote: >> ... > > The clock on your computer might be running just a wee bit ahead. > > Either that, or we're getting patches from the future. > > David > David, I know what happened. I was testing suspend to disk with pm_trace enabled and forgot to set the correct time after the running the test. Generated the patch without realizing the time is incorrect. Would like me to re-generate it. -- Shuah Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658 -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote: > Convert drivers/video/backlight/class to use dev_pm_ops for power > management and remove Legacy PM ops hooks. With this change, rtc class > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of > Legacy class->suspend/resume. When __device_suspend() runs call-backs, > it will find class->pm ops for the backlight class. > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com> > Cc: Shuah Khan <shuahkhan@gmail.com> Can you please resend the patches that nobody took with CCs to linux-pm@vger.kernel.org? If the original maintainers don't care, I'll be able to pick those patches up then (if they look good). Thanks! > --- > > v2: Updated changelog to correct device class. > > drivers/video/backlight/backlight.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index c74e7aa..0ffb251 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, > > static struct class *backlight_class; > > -static int backlight_suspend(struct device *dev, pm_message_t state) > +static int backlight_suspend(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > > @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) > return 0; > } > > +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, > + backlight_resume); > + > static void bl_device_release(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) > } > > backlight_class->dev_attrs = bl_device_attributes; > - backlight_class->suspend = backlight_suspend; > - backlight_class->resume = backlight_resume; > + backlight_class->pm = &backlight_class_dev_pm_ops; > return 0; > } > >
On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote: > On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote: > > Convert drivers/video/backlight/class to use dev_pm_ops for power > > management and remove Legacy PM ops hooks. With this change, rtc class > > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of > > Legacy class->suspend/resume. When __device_suspend() runs call-backs, > > it will find class->pm ops for the backlight class. > > > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com> > > Cc: Shuah Khan <shuahkhan@gmail.com> > > Can you please resend the patches that nobody took with CCs to > linux-pm@vger.kernel.org? If the original maintainers don't care, I'll be > able to pick those patches up then (if they look good). I already gave the comment, and am waiting v3 patch. However, Shuah Khan did not send the v3 patch yet. Currently, backlight subsystem patches go through mm-tree With my acked-by. Shuah Khan, Will you send the v3 patch? As I said, there is the typo in commit message. Please fix it. s/rtc class/backlight class Best regards, Jingoo Han > > --- > > > > v2: Updated changelog to correct device class. > > > > drivers/video/backlight/backlight.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > > index c74e7aa..0ffb251 100644 > > --- a/drivers/video/backlight/backlight.c > > +++ b/drivers/video/backlight/backlight.c > > @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, > > > > static struct class *backlight_class; > > > > -static int backlight_suspend(struct device *dev, pm_message_t state) > > +static int backlight_suspend(struct device *dev) > > { > > struct backlight_device *bd = to_backlight_device(dev); > > > > @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) > > return 0; > > } > > > > +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, > > + backlight_resume); > > + > > static void bl_device_release(struct device *dev) > > { > > struct backlight_device *bd = to_backlight_device(dev); > > @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) > > } > > > > backlight_class->dev_attrs = bl_device_attributes; > > - backlight_class->suspend = backlight_suspend; > > - backlight_class->resume = backlight_resume; > > + backlight_class->pm = &backlight_class_dev_pm_ops; > > return 0; > > } > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/19/2014 06:34 PM, Jingoo Han wrote: > On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote: >> On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote: >>> Convert drivers/video/backlight/class to use dev_pm_ops for power >>> management and remove Legacy PM ops hooks. With this change, rtc class >>> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of >>> Legacy class->suspend/resume. When __device_suspend() runs call-backs, >>> it will find class->pm ops for the backlight class. >>> >>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com> >>> Cc: Shuah Khan <shuahkhan@gmail.com> >> >> Can you please resend the patches that nobody took with CCs to >> linux-pm@vger.kernel.org? If the original maintainers don't care, I'll be >> able to pick those patches up then (if they look good). > > I already gave the comment, and am waiting v3 patch. > However, Shuah Khan did not send the v3 patch yet. > > Currently, backlight subsystem patches go through mm-tree > With my acked-by. > > Shuah Khan, > Will you send the v3 patch? As I said, there is the typo in > commit message. Please fix it. > s/rtc class/backlight class > Rafael/Jingoo Han, I did send the v3 patch with the typo fixed. Here is the link: http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html This is a while back. I will rebase and res-test and send it. thanks, -- Shuah
On 01/19/2014 08:37 AM, Rafael J. Wysocki wrote: > On Wednesday, November 14, 2040 04:27:17 AM Shuah Khan wrote: >> Convert drivers/video/backlight/class to use dev_pm_ops for power >> management and remove Legacy PM ops hooks. With this change, rtc class >> registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of >> Legacy class->suspend/resume. When __device_suspend() runs call-backs, >> it will find class->pm ops for the backlight class. >> >> Signed-off-by: Shuah Khan <shuah.kh@samsung.com> >> Cc: Shuah Khan <shuahkhan@gmail.com> > > Can you please resend the patches that nobody took with CCs to > linux-pm@vger.kernel.org? If the original maintainers don't care, I'll be > able to pick those patches up then (if they look good). > Rafael, Thanks. I have a few legacy pm patches that didn't get pulled into trees. I will rebase to the latest and resend. -- Shuah
On 01/20/2014 08:27 AM, Shuah Khan wrote: > On 01/19/2014 06:34 PM, Jingoo Han wrote: >> On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote: > Rafael/Jingoo Han, > > I did send the v3 patch with the typo fixed. Here is the link: > > http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html > > This is a while back. I will rebase and res-test and send it. > Checked 3.14-rc1 and patch v3 is in there. commit 3601792e7b68150420ea8dc129e26e167c0484d8 -- Shuah
On Wednesday, February 05, 2014 2:55 AM, Shuah Khan wrote: > On 01/20/2014 08:27 AM, Shuah Khan wrote: > > On 01/19/2014 06:34 PM, Jingoo Han wrote: > >> On Monday, January 20, 2014 12:37 AM, Rafael J. Wysocki wrote: > > > Rafael/Jingoo Han, > > > > I did send the v3 patch with the typo fixed. Here is the link: > > > > http://lkml.indiana.edu/hypermail/linux/kernel/1306.0/00219.html > > > > This is a while back. I will rebase and res-test and send it. > > > > Checked 3.14-rc1 and patch v3 is in there. > > commit 3601792e7b68150420ea8dc129e26e167c0484d8 OK, I see. I checked that it was already merged to mainline kernel. Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Shuah Khan <shuah.kh@samsung.com> wrote: > Convert drivers/video/backlight/class to use dev_pm_ops for power > management and remove Legacy PM ops hooks. With this change, rtc class > registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of > Legacy class->suspend/resume. When __device_suspend() runs call-backs, > it will find class->pm ops for the backlight class. > > Signed-off-by: Shuah Khan <shuah.kh@samsung.com> > Cc: Shuah Khan <shuahkhan@gmail.com> > > --- > v2: Updated changelog to correct device class. > > drivers/video/backlight/backlight.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > index c74e7aa..0ffb251 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, > > static struct class *backlight_class; > > -static int backlight_suspend(struct device *dev, pm_message_t state) > +static int backlight_suspend(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > > @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) > return 0; > } > > +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, > + backlight_resume); > + > static void bl_device_release(struct device *dev) > { > struct backlight_device *bd = to_backlight_device(dev); > @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) > } > > backlight_class->dev_attrs = bl_device_attributes; > - backlight_class->suspend = backlight_suspend; > - backlight_class->resume = backlight_resume; > + backlight_class->pm = &backlight_class_dev_pm_ops; > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index c74e7aa..0ffb251 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -208,7 +208,7 @@ static ssize_t backlight_show_actual_brightness(struct device *dev, static struct class *backlight_class; -static int backlight_suspend(struct device *dev, pm_message_t state) +static int backlight_suspend(struct device *dev) { struct backlight_device *bd = to_backlight_device(dev); @@ -236,6 +236,9 @@ static int backlight_resume(struct device *dev) return 0; } +static SIMPLE_DEV_PM_OPS(backlight_class_dev_pm_ops, backlight_suspend, + backlight_resume); + static void bl_device_release(struct device *dev) { struct backlight_device *bd = to_backlight_device(dev); @@ -414,8 +417,7 @@ static int __init backlight_class_init(void) } backlight_class->dev_attrs = bl_device_attributes; - backlight_class->suspend = backlight_suspend; - backlight_class->resume = backlight_resume; + backlight_class->pm = &backlight_class_dev_pm_ops; return 0; }
Convert drivers/video/backlight/class to use dev_pm_ops for power management and remove Legacy PM ops hooks. With this change, rtc class registers suspend/resume callbacks via class->pm (dev_pm_ops) instead of Legacy class->suspend/resume. When __device_suspend() runs call-backs, it will find class->pm ops for the backlight class. Signed-off-by: Shuah Khan <shuah.kh@samsung.com> Cc: Shuah Khan <shuahkhan@gmail.com> --- v2: Updated changelog to correct device class. drivers/video/backlight/backlight.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)