| Message ID | 1390217712-13332-1-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Ben, Thank you for the patch. On Monday 20 January 2014 11:35:12 Ben Dooks wrote: > The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock > refrences that mstp3_clks clock node, With the typo fixed, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > however these clocks are in the mstp9_clks node. > > The error was introducted in 72197ca7a1cb1cea5 ("ARM: shmobile: r8a7790: > Reference clocks") which is in Simon's current development tree. > > This patch fixes the following error: > > of_clk_src_onecell_get: invalid clock index 31 > i2c-rcar e6508000.i2c: cannot get clock > i2c-rcar: probe of e6508000.i2c failed with error -2 > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: horms+renesas@verge.net.au > Cc: laurent.pinchart+renesas@ideasonboard.com > Cc: linux-sh@vger.kernel.org > --- > arch/arm/boot/dts/r8a7790.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index 3cc834b..15e2a97 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -198,7 +198,7 @@ > reg = <0 0xe6508000 0 0x40>; > interrupt-parent = <&gic>; > interrupts = <0 287 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp3_clks R8A7790_CLK_I2C0>; > + clocks = <&mstp9_clks R8A7790_CLK_I2C0>; > status = "disabled"; > }; > > @@ -209,7 +209,7 @@ > reg = <0 0xe6518000 0 0x40>; > interrupt-parent = <&gic>; > interrupts = <0 288 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp3_clks R8A7790_CLK_I2C1>; > + clocks = <&mstp9_clks R8A7790_CLK_I2C1>; > status = "disabled"; > }; > > @@ -220,7 +220,7 @@ > reg = <0 0xe6530000 0 0x40>; > interrupt-parent = <&gic>; > interrupts = <0 286 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp3_clks R8A7790_CLK_I2C2>; > + clocks = <&mstp9_clks R8A7790_CLK_I2C2>; > status = "disabled"; > }; > > @@ -231,7 +231,7 @@ > reg = <0 0xe6540000 0 0x40>; > interrupt-parent = <&gic>; > interrupts = <0 290 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp3_clks R8A7790_CLK_I2C3>; > + clocks = <&mstp9_clks R8A7790_CLK_I2C3>; > status = "disabled"; > };
On 20/01/14 11:42, Laurent Pinchart wrote: > Hi Ben, > > Thank you for the patch. > > On Monday 20 January 2014 11:35:12 Ben Dooks wrote: >> The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock >> refrences that mstp3_clks clock node, > > With the typo fixed, > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I've re-sent with that fixed.
Hello. On 20-01-2014 15:42, Ben Dooks wrote: >> On Monday 20 January 2014 11:35:12 Ben Dooks wrote: >>> The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock >>> refrences that mstp3_clks clock node, >> With the typo fixed, >> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > I've re-sent with that fixed. But the patch subject still have the typo "ficx". :-) WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20/01/14 13:01, Sergei Shtylyov wrote: > Hello. > > On 20-01-2014 15:42, Ben Dooks wrote: > >>> On Monday 20 January 2014 11:35:12 Ben Dooks wrote: >>>> The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock >>>> refrences that mstp3_clks clock node, > >>> With the typo fixed, > >>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> I've re-sent with that fixed. > > But the patch subject still have the typo "ficx". :-) > > WBR, Sergei Argh. Do I really need to send v5?
Hello. On 01/20/2014 05:50 PM, Ben Dooks wrote: >>>>> The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock >>>>> refrences that mstp3_clks clock node, >>>> With the typo fixed, >>>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> I've re-sent with that fixed. >> But the patch subject still have the typo "ficx". :-) >> WBR, Sergei > Argh. Do I really need to send v5? That's up to Simon, I guess... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 3cc834b..15e2a97 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -198,7 +198,7 @@ reg = <0 0xe6508000 0 0x40>; interrupt-parent = <&gic>; interrupts = <0 287 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp3_clks R8A7790_CLK_I2C0>; + clocks = <&mstp9_clks R8A7790_CLK_I2C0>; status = "disabled"; }; @@ -209,7 +209,7 @@ reg = <0 0xe6518000 0 0x40>; interrupt-parent = <&gic>; interrupts = <0 288 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp3_clks R8A7790_CLK_I2C1>; + clocks = <&mstp9_clks R8A7790_CLK_I2C1>; status = "disabled"; }; @@ -220,7 +220,7 @@ reg = <0 0xe6530000 0 0x40>; interrupt-parent = <&gic>; interrupts = <0 286 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp3_clks R8A7790_CLK_I2C2>; + clocks = <&mstp9_clks R8A7790_CLK_I2C2>; status = "disabled"; }; @@ -231,7 +231,7 @@ reg = <0 0xe6540000 0 0x40>; interrupt-parent = <&gic>; interrupts = <0 290 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp3_clks R8A7790_CLK_I2C3>; + clocks = <&mstp9_clks R8A7790_CLK_I2C3>; status = "disabled"; };
The R8A7790's dtsi file i2c0, i2c1, i2c2, and i2c3 nodes have clock refrences that mstp3_clks clock node, however these clocks are in the mstp9_clks node. The error was introducted in 72197ca7a1cb1cea5 ("ARM: shmobile: r8a7790: Reference clocks") which is in Simon's current development tree. This patch fixes the following error: of_clk_src_onecell_get: invalid clock index 31 i2c-rcar e6508000.i2c: cannot get clock i2c-rcar: probe of e6508000.i2c failed with error -2 Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: horms+renesas@verge.net.au Cc: laurent.pinchart+renesas@ideasonboard.com Cc: linux-sh@vger.kernel.org --- arch/arm/boot/dts/r8a7790.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)