Message ID | 1390419184-4450-5-git-send-email-ville.syrjala@linux.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Jan 22, 2014 at 5:32 PM, <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 6c0a10a..0e724c9 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4939,8 +4939,9 @@ static void valleyview_init_clock_gating(struct drm_device *dev) > I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1, > GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC); > > - /* WaApplyL3ControlAndL3ChickenMode:vlv */ > + /* WaDisableL3CacheAging:vlv */ this is right. > I915_WRITE(GEN7_L3CNTLREG1, I915_READ(GEN7_L3CNTLREG1) | GEN7_L3AGDIS); > + /* WaApplyL3ControlAndL3ChickenMode:vlv */ On wa_database I only see this name with ivb... nothing from vlv with this wa name. > I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE); > > /* WaForceL3Serialization:vlv */ > -- > 1.8.3.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Jan 23, 2014 at 06:25:26PM -0200, Rodrigo Vivi wrote: > On Wed, Jan 22, 2014 at 5:32 PM, <ville.syrjala@linux.intel.com> wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/intel_pm.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 6c0a10a..0e724c9 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -4939,8 +4939,9 @@ static void valleyview_init_clock_gating(struct drm_device *dev) > > I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1, > > GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC); > > > > - /* WaApplyL3ControlAndL3ChickenMode:vlv */ > > + /* WaDisableL3CacheAging:vlv */ > > this is right. > > > I915_WRITE(GEN7_L3CNTLREG1, I915_READ(GEN7_L3CNTLREG1) | GEN7_L3AGDIS); > > + /* WaApplyL3ControlAndL3ChickenMode:vlv */ > > On wa_database I only see this name with ivb... nothing from vlv with > this wa name. Let me refer you to patch 16 in the series... > > > I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE); > > > > /* WaForceL3Serialization:vlv */ > > -- > > 1.8.3.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Rodrigo Vivi > Blog: http://blog.vivi.eng.br
On Thu, Jan 23, 2014 at 6:32 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > On Thu, Jan 23, 2014 at 06:25:26PM -0200, Rodrigo Vivi wrote: >> On Wed, Jan 22, 2014 at 5:32 PM, <ville.syrjala@linux.intel.com> wrote: >> > From: Ville Syrjälä <ville.syrjala@linux.intel.com> >> > >> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >> > --- >> > drivers/gpu/drm/i915/intel_pm.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> > index 6c0a10a..0e724c9 100644 >> > --- a/drivers/gpu/drm/i915/intel_pm.c >> > +++ b/drivers/gpu/drm/i915/intel_pm.c >> > @@ -4939,8 +4939,9 @@ static void valleyview_init_clock_gating(struct drm_device *dev) >> > I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1, >> > GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC); >> > >> > - /* WaApplyL3ControlAndL3ChickenMode:vlv */ >> > + /* WaDisableL3CacheAging:vlv */ >> >> this is right. >> >> > I915_WRITE(GEN7_L3CNTLREG1, I915_READ(GEN7_L3CNTLREG1) | GEN7_L3AGDIS); >> > + /* WaApplyL3ControlAndL3ChickenMode:vlv */ >> >> On wa_database I only see this name with ivb... nothing from vlv with >> this wa name. > > Let me refer you to patch 16 in the series... Cool thanks. Sorry for not check that... I'm going on blocks of 4 ;) Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com> for this one as well. > >> >> > I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE); >> > >> > /* WaForceL3Serialization:vlv */ >> > -- >> > 1.8.3.2 >> > >> > _______________________________________________ >> > Intel-gfx mailing list >> > Intel-gfx@lists.freedesktop.org >> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >> >> >> >> -- >> Rodrigo Vivi >> Blog: http://blog.vivi.eng.br > > -- > Ville Syrjälä > Intel OTC
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 6c0a10a..0e724c9 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -4939,8 +4939,9 @@ static void valleyview_init_clock_gating(struct drm_device *dev) I915_WRITE(GEN7_COMMON_SLICE_CHICKEN1, GEN7_CSC1_RHWO_OPT_DISABLE_IN_RCC); - /* WaApplyL3ControlAndL3ChickenMode:vlv */ + /* WaDisableL3CacheAging:vlv */ I915_WRITE(GEN7_L3CNTLREG1, I915_READ(GEN7_L3CNTLREG1) | GEN7_L3AGDIS); + /* WaApplyL3ControlAndL3ChickenMode:vlv */ I915_WRITE(GEN7_L3_CHICKEN_MODE_REGISTER, GEN7_WA_L3_CHICKEN_MODE); /* WaForceL3Serialization:vlv */