| Message ID | 1390902468-7753-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 28/01/14 16:11, Sergei Shtylyov wrote: > Hello. > > On 01/28/2014 12:47 PM, Ben Dooks wrote: > >> The current code does not check the return from platform_get_irq() >> so add an error check and return if this call does fail. > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: Valentine Barshak <valentine.barshak@cogentembedded.com> >> Cc: Simon Horman <horms@verge.net.au> >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Cc: linux-pci@vger.kernel.org >> Cc: linux-sh@vger.kernel.org >> --- >> drivers/pci/host/pci-rcar-gen2.c | 5 +++++ >> 1 file changed, 5 insertions(+) > >> diff --git a/drivers/pci/host/pci-rcar-gen2.c >> b/drivers/pci/host/pci-rcar-gen2.c >> index ea65bac..674f7fe 100644 >> --- a/drivers/pci/host/pci-rcar-gen2.c >> +++ b/drivers/pci/host/pci-rcar-gen2.c >> @@ -308,6 +308,11 @@ static int __init rcar_pci_probe(struct >> platform_device *pdev) >> priv->reg = reg; >> priv->dev = &pdev->dev; >> >> + if (priv->irq < 0) { > > <= actually, as IRQ0 has been declared invalid by Linus. > >> + dev_err(&pdev->dev, "no valid irq found\n"); >> + return priv->irq; >> + } >> + IIRC, 0 is /no irq/ not an error.
Hello. On 01/28/2014 12:47 PM, Ben Dooks wrote: > The current code does not check the return from platform_get_irq() > so add an error check and return if this call does fail. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Valentine Barshak <valentine.barshak@cogentembedded.com> > Cc: Simon Horman <horms@verge.net.au> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > --- > drivers/pci/host/pci-rcar-gen2.c | 5 +++++ > 1 file changed, 5 insertions(+) > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c > index ea65bac..674f7fe 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -308,6 +308,11 @@ static int __init rcar_pci_probe(struct platform_device *pdev) > priv->reg = reg; > priv->dev = &pdev->dev; > > + if (priv->irq < 0) { <= actually, as IRQ0 has been declared invalid by Linus. > + dev_err(&pdev->dev, "no valid irq found\n"); > + return priv->irq; > + } > + WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index ea65bac..674f7fe 100644 --- a/drivers/pci/host/pci-rcar-gen2.c +++ b/drivers/pci/host/pci-rcar-gen2.c @@ -308,6 +308,11 @@ static int __init rcar_pci_probe(struct platform_device *pdev) priv->reg = reg; priv->dev = &pdev->dev; + if (priv->irq < 0) { + dev_err(&pdev->dev, "no valid irq found\n"); + return priv->irq; + } + return rcar_pci_add_controller(priv); }
The current code does not check the return from platform_get_irq() so add an error check and return if this call does fail. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Valentine Barshak <valentine.barshak@cogentembedded.com> Cc: Simon Horman <horms@verge.net.au> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org Cc: linux-sh@vger.kernel.org --- drivers/pci/host/pci-rcar-gen2.c | 5 +++++ 1 file changed, 5 insertions(+)