| Message ID | 1390754945-28142-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello. On 26-01-2014 20:48, Ben Dooks wrote: > Add OF match table for pci-rcar-gen2 driver for device tree support. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Simon Horman <horms@verge.net.au> > Cc: linux-pci@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c > index ceec147..ea65bac 100644 > --- a/drivers/pci/host/pci-rcar-gen2.c > +++ b/drivers/pci/host/pci-rcar-gen2.c > @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct platform_device *pdev) > return rcar_pci_add_controller(priv); > } > > +static struct of_device_id rcar_pci_of_match[] = { > + { .compatible = "renesas,pci-r8a7790", }, Why only H2 SoC, if the driver is for both Gen2 SoCs? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27/01/14 12:48, Sergei Shtylyov wrote: > Hello. > > On 26-01-2014 20:48, Ben Dooks wrote: > >> Add OF match table for pci-rcar-gen2 driver for device tree support. > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: Bjorn Helgaas <bhelgaas@google.com> >> Cc: Simon Horman <horms@verge.net.au> >> Cc: linux-pci@vger.kernel.org >> Cc: linux-sh@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> --- >> drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > >> diff --git a/drivers/pci/host/pci-rcar-gen2.c >> b/drivers/pci/host/pci-rcar-gen2.c >> index ceec147..ea65bac 100644 >> --- a/drivers/pci/host/pci-rcar-gen2.c >> +++ b/drivers/pci/host/pci-rcar-gen2.c >> @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct >> platform_device *pdev) >> return rcar_pci_add_controller(priv); >> } >> >> +static struct of_device_id rcar_pci_of_match[] = { >> + { .compatible = "renesas,pci-r8a7790", }, > > Why only H2 SoC, if the driver is for both Gen2 SoCs? I can add a "renesas,pci-rcar-gen2" as a fallback match however I've not got anything other than an r8a7790 to test on. Also the compatible properties are preferably named after the soc.
On Mon, Jan 27, 2014 at 01:27:09PM +0000, Ben Dooks wrote: > On 27/01/14 12:48, Sergei Shtylyov wrote: > >Hello. > > > >On 26-01-2014 20:48, Ben Dooks wrote: > > > >>Add OF match table for pci-rcar-gen2 driver for device tree support. > > > >>Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > >>--- > >>Cc: Bjorn Helgaas <bhelgaas@google.com> > >>Cc: Simon Horman <horms@verge.net.au> > >>Cc: linux-pci@vger.kernel.org > >>Cc: linux-sh@vger.kernel.org > >>Cc: devicetree@vger.kernel.org > >>--- > >> drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > > > >>diff --git a/drivers/pci/host/pci-rcar-gen2.c > >>b/drivers/pci/host/pci-rcar-gen2.c > >>index ceec147..ea65bac 100644 > >>--- a/drivers/pci/host/pci-rcar-gen2.c > >>+++ b/drivers/pci/host/pci-rcar-gen2.c > >>@@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct > >>platform_device *pdev) > >> return rcar_pci_add_controller(priv); > >> } > >> > >>+static struct of_device_id rcar_pci_of_match[] = { > >>+ { .compatible = "renesas,pci-r8a7790", }, > > > > Why only H2 SoC, if the driver is for both Gen2 SoCs? > > I can add a "renesas,pci-rcar-gen2" as a fallback match however > I've not got anything other than an r8a7790 to test on. Also the > compatible properties are preferably named after the soc. I'm not sure what the "best practice" is here but I propose that you add both "renesas,pci-rcar-gen2" and "renesas,pci-r8a7790" now. And that "renesas,pci-r8a7791" can be added once the code has been integrated and tested on that platform. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 29, 2014 at 7:17 AM, Simon Horman <horms@verge.net.au> wrote: >> >>+static struct of_device_id rcar_pci_of_match[] = { >> >>+ { .compatible = "renesas,pci-r8a7790", }, >> > >> > Why only H2 SoC, if the driver is for both Gen2 SoCs? >> >> I can add a "renesas,pci-rcar-gen2" as a fallback match however >> I've not got anything other than an r8a7790 to test on. Also the >> compatible properties are preferably named after the soc. > > I'm not sure what the "best practice" is here but I propose that > you add both "renesas,pci-rcar-gen2" and "renesas,pci-r8a7790" now. To the driver or to the '90 DTS? If the DTS says compatible = "renesas,pci-r8a7790", "renesas,pci-rcar-gen2" then the driver can just live with "renesas,pci-rcar-gen2" for now. > And that "renesas,pci-r8a7791" can be added once the code has been > integrated and tested on that platform. And later we can add compatible = "renesas,pci-r8a7791", "renesas,pci-rcar-gen2" to the '91 DTS if it turns out to be compatible. If the '91 turns out to be incompatible, or partially compatible, the driver can be updated later to handle both "renesas,pci-r8a7790" and "renesas,pci-r8a7791" and differentiate between them. (That's what I was instructed to do with SPI ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 29, 2014 at 11:06:42AM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 29, 2014 at 7:17 AM, Simon Horman <horms@verge.net.au> wrote: > >> >>+static struct of_device_id rcar_pci_of_match[] = { > >> >>+ { .compatible = "renesas,pci-r8a7790", }, > >> > > >> > Why only H2 SoC, if the driver is for both Gen2 SoCs? > >> > >> I can add a "renesas,pci-rcar-gen2" as a fallback match however > >> I've not got anything other than an r8a7790 to test on. Also the > >> compatible properties are preferably named after the soc. > > > > I'm not sure what the "best practice" is here but I propose that > > you add both "renesas,pci-rcar-gen2" and "renesas,pci-r8a7790" now. > > To the driver or to the '90 DTS? > > If the DTS says > > compatible = "renesas,pci-r8a7790", "renesas,pci-rcar-gen2" > > then the driver can just live with "renesas,pci-rcar-gen2" for now. > > > And that "renesas,pci-r8a7791" can be added once the code has been > > integrated and tested on that platform. > > And later we can add > > compatible = "renesas,pci-r8a7791", "renesas,pci-rcar-gen2" > > to the '91 DTS if it turns out to be compatible. > > If the '91 turns out to be incompatible, or partially compatible, the driver > can be updated later to handle both "renesas,pci-r8a7790" and > "renesas,pci-r8a7791" and differentiate between them. > > (That's what I was instructed to do with SPI ;-) Thanks, that is more or less how I thought things work :) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index ceec147..ea65bac 100644 --- a/drivers/pci/host/pci-rcar-gen2.c +++ b/drivers/pci/host/pci-rcar-gen2.c @@ -311,9 +311,17 @@ static int __init rcar_pci_probe(struct platform_device *pdev) return rcar_pci_add_controller(priv); } +static struct of_device_id rcar_pci_of_match[] = { + { .compatible = "renesas,pci-r8a7790", }, + { }, +}; + +MODULE_DEVICE_TABLE(of, rcar_pci_of_match); + static struct platform_driver rcar_pci_driver = { .driver = { .name = "pci-rcar-gen2", + .of_match_table = rcar_pci_of_match, }, };
Add OF match table for pci-rcar-gen2 driver for device tree support. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Simon Horman <horms@verge.net.au> Cc: linux-pci@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: devicetree@vger.kernel.org --- drivers/pci/host/pci-rcar-gen2.c | 8 ++++++++ 1 file changed, 8 insertions(+)