| Message ID | 1391957777.25424.15.camel@x220 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/09/2014 03:56 PM, Paul Bolle wrote: > Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio > directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for > Si4713") both added a "select SI4713". But there's no Kconfig symbol > SI4713, so these selects are nops. It's not clear why they were added > but it's safe to remove them anyway. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select should be I2C_SI4713. If you can post a patch fixing that, then I'll pick it up for 3.14. With the addition of the USB si4713 driver things moved around and were renamed, and these selects were missed. Regards, Hans > --- > Untested! > > drivers/media/radio/si4713/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig > index a7c3ba8..ed51ed0 100644 > --- a/drivers/media/radio/si4713/Kconfig > +++ b/drivers/media/radio/si4713/Kconfig > @@ -1,7 +1,6 @@ > config USB_SI4713 > tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB" > depends on USB && RADIO_SI4713 > - select SI4713 > ---help--- > This is a driver for USB devices with the Silicon Labs SI4713 > chip. Currently these devices are known to work. > @@ -16,7 +15,6 @@ config USB_SI4713 > config PLATFORM_SI4713 > tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C" > depends on I2C && RADIO_SI4713 > - select SI4713 > ---help--- > This is a driver for I2C devices with the Silicon Labs SI4713 > chip. > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hans, On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote: > USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select > should be I2C_SI4713. Are you sure? I've actually scanned si4713.c before submitting this patch and I couldn't find anything in it that these other two modules require. Have I overlooked anything? > If you can post a patch fixing that, then I'll pick > it up for 3.14. > > With the addition of the USB si4713 driver things moved around and were > renamed, and these selects were missed. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/09/2014 04:27 PM, Paul Bolle wrote: > Hans, > > On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote: >> USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select >> should be I2C_SI4713. > > Are you sure? I've actually scanned si4713.c before submitting this > patch and I couldn't find anything in it that these other two modules > require. Have I overlooked anything? The i2c module is loaded by v4l2_i2c_new_subdev_board(). Regards, Hans > >> If you can post a patch fixing that, then I'll pick >> it up for 3.14. >> >> With the addition of the USB si4713 driver things moved around and were >> renamed, and these selects were missed. > > Thanks, > > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2014-02-09 at 18:04 +0100, Hans Verkuil wrote:
> The i2c module is loaded by v4l2_i2c_new_subdev_board().
I see. Thanks.
But now I wonder: is I2C_SI4713 useful on itself? Would anyone use
si4713.ko without using either radio-usb-si4713.ko or
radio-platform-si4713.ko? Because it seems that if what people actually
use is radio-usb-si4713.ko or radio-platform-si4713.ko than I2C_SI4713
could be made a 'select only' Kconfig symbol (that won't show up in
menuconfig), couldn't it?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/09/2014 06:37 PM, Paul Bolle wrote: > On Sun, 2014-02-09 at 18:04 +0100, Hans Verkuil wrote: >> The i2c module is loaded by v4l2_i2c_new_subdev_board(). > > I see. Thanks. > > But now I wonder: is I2C_SI4713 useful on itself? Would anyone use > si4713.ko without using either radio-usb-si4713.ko or > radio-platform-si4713.ko? Because it seems that if what people actually > use is radio-usb-si4713.ko or radio-platform-si4713.ko than I2C_SI4713 > could be made a 'select only' Kconfig symbol (that won't show up in > menuconfig), couldn't it? It's possible to create an out-of-tree driver that uses the i2c si4713 driver. So yes, it should be possible to just select the i2c driver without any of the others. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig index a7c3ba8..ed51ed0 100644 --- a/drivers/media/radio/si4713/Kconfig +++ b/drivers/media/radio/si4713/Kconfig @@ -1,7 +1,6 @@ config USB_SI4713 tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB" depends on USB && RADIO_SI4713 - select SI4713 ---help--- This is a driver for USB devices with the Silicon Labs SI4713 chip. Currently these devices are known to work. @@ -16,7 +15,6 @@ config USB_SI4713 config PLATFORM_SI4713 tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C" depends on I2C && RADIO_SI4713 - select SI4713 ---help--- This is a driver for I2C devices with the Silicon Labs SI4713 chip.
Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for Si4713") both added a "select SI4713". But there's no Kconfig symbol SI4713, so these selects are nops. It's not clear why they were added but it's safe to remove them anyway. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested! drivers/media/radio/si4713/Kconfig | 2 -- 1 file changed, 2 deletions(-)