| Message ID | 52FAE504.8020001@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: > The ACPI table on ASUS UX302LA has more than 8 output devices under the > graphics controller device node. The problem is, the real active output > device, the LCD panel, is listed the last. The result is, the LCD's > device id doesn't get recorded in the active device list CADL array and > when the _DCS control method for the LCD device is executed, it returns > 0x1d, meaning it is not active. This affects the hotkey delivery ASL > code that will not deliver a notification if the output device is not > active on backlight hotkey press. > > I don't see a clean way to solve this problem since the operation region > spec doesn't allow more than 8 output devices so we have no way of > storing all these output devices. The fact that output devices that have > _BCM control method usually means they have a higher possibility of being > used than those who don't made me choose a simple way to work around > the buggy firmware by replacing the last entry in CADL array with the one > that has _BCM control method. There is no specific reason why the last > entry is picked instead of others. Another possibility is that the connector list is in rough priority order so might be useful for sorting the CADL array. Since the CADL should only be a list of currently active devices, we could just bite the bullet and repopulate it correctly after every setcrtc. -Chris
On Wed, 12 Feb 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote: > On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: >> The ACPI table on ASUS UX302LA has more than 8 output devices under the >> graphics controller device node. The problem is, the real active output >> device, the LCD panel, is listed the last. The result is, the LCD's >> device id doesn't get recorded in the active device list CADL array and >> when the _DCS control method for the LCD device is executed, it returns >> 0x1d, meaning it is not active. This affects the hotkey delivery ASL >> code that will not deliver a notification if the output device is not >> active on backlight hotkey press. >> >> I don't see a clean way to solve this problem since the operation region >> spec doesn't allow more than 8 output devices so we have no way of >> storing all these output devices. The fact that output devices that have >> _BCM control method usually means they have a higher possibility of being >> used than those who don't made me choose a simple way to work around >> the buggy firmware by replacing the last entry in CADL array with the one >> that has _BCM control method. There is no specific reason why the last >> entry is picked instead of others. > > Another possibility is that the connector list is in rough priority > order so might be useful for sorting the CADL array. > > Since the CADL should only be a list of currently active devices, we > could just bite the bullet and repopulate it correctly after every > setcrtc. Agreed. Per spec, DIDL: Writes - Graphics driver writes to this field once during its initialization after determining platform supported connectors. CPDL: Writes - Graphics driver writes to this field on every monitor detection process. CADL: Writes - Graphics driver writes to this field on every mode set process and during boot. And for all of the above: Writes - System BIOS POST or ASL code should not write to these fields. BR, Jani.
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index 4e960ec7419f..fc4348284f41 100644 --- a/drivers/gpu/drm/i915/intel_opregion.c +++ b/drivers/gpu/drm/i915/intel_opregion.c @@ -613,6 +613,7 @@ static void intel_didl_outputs(struct drm_device *dev) acpi_status status; u32 temp; int i = 0; + bool done; handle = ACPI_HANDLE(&dev->pdev->dev); if (!handle || acpi_bus_get_device(handle, &acpi_dev)) @@ -634,11 +635,20 @@ static void intel_didl_outputs(struct drm_device *dev) return; } + done = false; list_for_each_entry(acpi_cdev, &acpi_video_bus->children, node) { if (i >= 8) { dev_dbg(&dev->pdev->dev, - "More than 8 outputs detected via ACPI\n"); - return; + "More than 8 outputs detected via ACPI, %s\n", + acpi_device_bid(acpi_cdev)); + if (acpi_has_method(acpi_cdev->handle, "_BCM")) { + dev_dbg(&dev->pdev->dev, + "%s has _BCM, replacing 8th entry\n", + acpi_device_bid(acpi_cdev)); + i = 7; + done = true; + } else + continue; } status = acpi_evaluate_integer(acpi_cdev->handle, "_ADR", @@ -650,6 +660,9 @@ static void intel_didl_outputs(struct drm_device *dev) &opregion->acpi->didl[i]); i++; } + + if (done) + return; } end:
The ACPI table on ASUS UX302LA has more than 8 output devices under the graphics controller device node. The problem is, the real active output device, the LCD panel, is listed the last. The result is, the LCD's device id doesn't get recorded in the active device list CADL array and when the _DCS control method for the LCD device is executed, it returns 0x1d, meaning it is not active. This affects the hotkey delivery ASL code that will not deliver a notification if the output device is not active on backlight hotkey press. I don't see a clean way to solve this problem since the operation region spec doesn't allow more than 8 output devices so we have no way of storing all these output devices. The fact that output devices that have _BCM control method usually means they have a higher possibility of being used than those who don't made me choose a simple way to work around the buggy firmware by replacing the last entry in CADL array with the one that has _BCM control method. There is no specific reason why the last entry is picked instead of others. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=70241 Signed-off-by: Aaron Lu <aaron.lu@intel.com> Reported-and-tested-by: Oleksij Rempel <linux@rempel-privat.de> --- drivers/gpu/drm/i915/intel_opregion.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)