| Message ID | 1383086274-11049-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote: > Renesas ARM platforms are transitioning from single-platform to > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with > COMPILE_TEST. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-serial@vger.kernel.org > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index febd45c..9a5a8ef 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE > > config SERIAL_SH_SCI > tristate "SuperH SCI(F) serial port support" > - depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE) > + depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST) > select SERIAL_CORE This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc since v3.13-rc1. I wonder if depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST) isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187 ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile configs.) Or do you plan to deprecate ARCH_SHMOBILE? Best regards Uwe
Hi Uwe, On Wednesday 19 February 2014 21:54:46 Uwe Kleine-König wrote: > On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote: > > Renesas ARM platforms are transitioning from single-platform to > > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the > > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE > > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with > > COMPILE_TEST. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: linux-serial@vger.kernel.org > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > drivers/tty/serial/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > > index febd45c..9a5a8ef 100644 > > --- a/drivers/tty/serial/Kconfig > > +++ b/drivers/tty/serial/Kconfig > > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE > > > > config SERIAL_SH_SCI > > > > tristate "SuperH SCI(F) serial port support" > > > > - depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE) > > + depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST) > > > > select SERIAL_CORE > > This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc > since v3.13-rc1. I wonder if > > depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST) > > isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187 > ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile > configs.) Or do you plan to deprecate ARCH_SHMOBILE? We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] serial: sh-sci: Restrict non-COMPILE_TEST compilation").
On Wed, Feb 19, 2014 at 11:24:38PM +0100, Laurent Pinchart wrote: > Hi Uwe, > > On Wednesday 19 February 2014 21:54:46 Uwe Kleine-König wrote: > > On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote: > > > Renesas ARM platforms are transitioning from single-platform to > > > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the > > > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE > > > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with > > > COMPILE_TEST. > > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > Cc: linux-serial@vger.kernel.org > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > --- > > > > > > drivers/tty/serial/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > > > index febd45c..9a5a8ef 100644 > > > --- a/drivers/tty/serial/Kconfig > > > +++ b/drivers/tty/serial/Kconfig > > > @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE > > > > > > config SERIAL_SH_SCI > > > > > > tristate "SuperH SCI(F) serial port support" > > > > > > - depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE) > > > + depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST) > > > > > > select SERIAL_CORE > > > > This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc > > since v3.13-rc1. I wonder if > > > > depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST) > > > > isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187 > > ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile > > configs.) Or do you plan to deprecate ARCH_SHMOBILE? > > We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, > please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] > serial: sh-sci: Restrict non-COMPILE_TEST compilation"). Ah, this is equivalent. So you can consider my suggestion as an Ack. Best regards Uwe
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index febd45c..9a5a8ef 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE config SERIAL_SH_SCI tristate "SuperH SCI(F) serial port support" - depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE) + depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST) select SERIAL_CORE config SERIAL_SH_SCI_NR_UARTS
Renesas ARM platforms are transitioning from single-platform to multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the driver available on all ARM platforms to enable it on both ARCH_SHMOBILE and ARCH_SHMOBILE_MULTI, and increase build testing coverage with COMPILE_TEST. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-serial@vger.kernel.org Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)