diff mbox

[RFC,v6,2/3] controls.xml : add addtional Flash fault bits

Message ID 1393398251-5383-3-git-send-email-gshark.jeong@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Jeong Feb. 26, 2014, 7:04 a.m. UTC
Descriptions for flash faluts.
 V4L2_FLASH_FAULT_UNDER_VOLTAGE,
 V4L2_FLASH_FAULT_INPUT_VOLTAGE,
 and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE

Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
---
 Documentation/DocBook/media/v4l/controls.xml |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Sakari Ailus Feb. 26, 2014, 12:33 p.m. UTC | #1
Hi Daniel,

Thanks for the update. Just one comment below.

On Wed, Feb 26, 2014 at 04:04:10PM +0900, Daniel Jeong wrote:
> Descriptions for flash faluts.
>  V4L2_FLASH_FAULT_UNDER_VOLTAGE,
>  V4L2_FLASH_FAULT_INPUT_VOLTAGE,
>  and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE
> 
> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
> ---
>  Documentation/DocBook/media/v4l/controls.xml |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
> index a5a3188..16f8af3 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
>      		  <entry>The flash controller has detected a short or open
>      		  circuit condition on the indicator LED.</entry>
>      		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
> +    		  <entry>Flash controller voltage to the flash LED
> +    		  has been below the minimum limit specific to the flash
> +    		  controller.</entry>
> +    		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
> +    		  <entry>The flash current can't reach to the target current
> +    		  because the input voltage is dropped below lower limit. 
> +    		  and Flash controller have adjusted the flash current
> +    		  not to occur under voltage event.</entry>

How about this:

"The input voltage of the flash controller is below the limit under which
strobing the flash at full current will not be possible. The condition
persists until this flag is no longer set."

> +    		</row>
> +    		<row>
> +    		  <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
> +    		  <entry>The temperature of the LED has exceeded its
> +    		  allowed upper limit.</entry>
> +    		</row>
>      	      </tbody>
>      	    </entrytbl>
>      	  </row>
diff mbox

Patch

diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
index a5a3188..16f8af3 100644
--- a/Documentation/DocBook/media/v4l/controls.xml
+++ b/Documentation/DocBook/media/v4l/controls.xml
@@ -4370,6 +4370,24 @@  interface and may change in the future.</para>
     		  <entry>The flash controller has detected a short or open
     		  circuit condition on the indicator LED.</entry>
     		</row>
+    		<row>
+    		  <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
+    		  <entry>Flash controller voltage to the flash LED
+    		  has been below the minimum limit specific to the flash
+    		  controller.</entry>
+    		</row>
+    		<row>
+    		  <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
+    		  <entry>The flash current can't reach to the target current
+    		  because the input voltage is dropped below lower limit. 
+    		  and Flash controller have adjusted the flash current
+    		  not to occur under voltage event.</entry>
+    		</row>
+    		<row>
+    		  <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
+    		  <entry>The temperature of the LED has exceeded its
+    		  allowed upper limit.</entry>
+    		</row>
     	      </tbody>
     	    </entrytbl>
     	  </row>