diff mbox

ARM: XEN depends on having a MMU

Message ID 1393425046-23317-1-git-send-email-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Uwe Kleine-König Feb. 26, 2014, 2:30 p.m. UTC
arch/arm/xen/enlighten.c (and maybe others) use MMU-specific functions
like pte_mkspecial which are only available on MMU builds. So let XEN
depend on MMU.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Stabellini Feb. 26, 2014, 2:45 p.m. UTC | #1
On Wed, 26 Feb 2014, Uwe Kleine-König wrote:
> arch/arm/xen/enlighten.c (and maybe others) use MMU-specific functions
> like pte_mkspecial which are only available on MMU builds. So let XEN
> depend on MMU.
> 
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>


>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e25419817791..1eb3a250210a 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1903,6 +1903,7 @@ config XEN
>  	depends on ARM && AEABI && OF
>  	depends on CPU_V7 && !CPU_V6
>  	depends on !GENERIC_ATOMIC64
> +	depends on MMU
>  	select ARM_PSCI
>  	select SWIOTLB_XEN
>  	select ARCH_DMA_ADDR_T_64BIT
> -- 
> 1.8.5.3
>
Uwe Kleine-König Feb. 26, 2014, 4:04 p.m. UTC | #2
Hello Stefano,

On Wed, Feb 26, 2014 at 02:45:19PM +0000, Stefano Stabellini wrote:
> On Wed, 26 Feb 2014, Uwe Kleine-König wrote:
> > arch/arm/xen/enlighten.c (and maybe others) use MMU-specific functions
> > like pte_mkspecial which are only available on MMU builds. So let XEN
> > depend on MMU.
> > 
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Who will apply this patch? I expected that you pick it up.

Best regards
Uwe
Stefano Stabellini Feb. 26, 2014, 4:31 p.m. UTC | #3
On Wed, 26 Feb 2014, Uwe Kleine-König wrote:
> Hello Stefano,
> 
> On Wed, Feb 26, 2014 at 02:45:19PM +0000, Stefano Stabellini wrote:
> > On Wed, 26 Feb 2014, Uwe Kleine-König wrote:
> > > arch/arm/xen/enlighten.c (and maybe others) use MMU-specific functions
> > > like pte_mkspecial which are only available on MMU builds. So let XEN
> > > depend on MMU.
> > > 
> > > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Who will apply this patch? I expected that you pick it up.

OK, that's fine, I'll add it to the xentip tree.
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e25419817791..1eb3a250210a 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1903,6 +1903,7 @@  config XEN
 	depends on ARM && AEABI && OF
 	depends on CPU_V7 && !CPU_V6
 	depends on !GENERIC_ATOMIC64
+	depends on MMU
 	select ARM_PSCI
 	select SWIOTLB_XEN
 	select ARCH_DMA_ADDR_T_64BIT