| Message ID | 1393525604-21471-1-git-send-email-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 27 February 2014 19:26, Philipp Zabel <p.zabel@pengutronix.de> wrote: > If devices don't provide latency data, this warning can be quite noisy until > the pm domain was enabled and disabled a few times. Turn this warning into > a debug message. Just curious, why is the latency not interesting for you? > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 6d47498..93ca31f 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -46,7 +46,7 @@ > struct gpd_timing_data *__td = &dev_gpd_data(dev)->td; \ > if (!__retval && __elapsed > __td->field) { \ > __td->field = __elapsed; \ > - dev_warn(dev, name " latency exceeded, new value %lld ns\n", \ > + dev_dbg(dev, name " latency exceeded, new value %lld ns\n", \ > __elapsed); \ > genpd->max_off_time_changed = true; \ > __td->constraint_changed = true; \ > -- > 1.8.5.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 2014-02-27 19:26:44, Philipp Zabel wrote: > If devices don't provide latency data, this warning can be quite noisy until > the pm domain was enabled and disabled a few times. Turn this warning into > a debug message. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Acked-by: Pavel Machek <pavel@ucw.cz>
Hi Ulf, Am Donnerstag, den 27.02.2014, 23:43 +0100 schrieb Ulf Hansson: > On 27 February 2014 19:26, Philipp Zabel <p.zabel@pengutronix.de> wrote: > > If devices don't provide latency data, this warning can be quite noisy until > > the pm domain was enabled and disabled a few times. Turn this warning into > > a debug message. > > Just curious, why is the latency not interesting for you? at least it is not always interesting. root@BDSL:~ v4l2-ctl -D -d /dev/video5 coda 2040000.vpu: start latency exceeded, new value 743 ns coda 2040000.vpu: state restore latency exceeded, new value 4828363 ns Driver Info (not using libv4l2):coda 2040000.vpu: stop latency exceeded, new value 1561 ns Driver name : coda Card type : CODA960 [...] That's a bit too verbose for my taste if I'm not currently working on either latency or the pm domain handling itself. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 6d47498..93ca31f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -46,7 +46,7 @@ struct gpd_timing_data *__td = &dev_gpd_data(dev)->td; \ if (!__retval && __elapsed > __td->field) { \ __td->field = __elapsed; \ - dev_warn(dev, name " latency exceeded, new value %lld ns\n", \ + dev_dbg(dev, name " latency exceeded, new value %lld ns\n", \ __elapsed); \ genpd->max_off_time_changed = true; \ __td->constraint_changed = true; \
If devices don't provide latency data, this warning can be quite noisy until the pm domain was enabled and disabled a few times. Turn this warning into a debug message. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)