| Message ID | 1393678004-17427-1-git-send-email-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 48b5e1fb883c8c72b50ee1ccd3ee51e4f53f632f |
| Headers | show |
On Sat, Mar 01, 2014 at 01:46:44PM +0100, Lars-Peter Clausen wrote: > The wm8763 driver uses regmap for IO which means that codec->cache_sync is not > used. The line was added in commit d3398ff ('ASoC: Convert WM8753 to direct > regmap API usage'). Presumably this was meant to be regcache_mark_dirty(), but > since we already call regcache_mark_dirty() in the core when suspending the > CODEC it is safe to just remove the line. > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Thanks, Charles
On Sat, Mar 01, 2014 at 01:46:44PM +0100, Lars-Peter Clausen wrote: > The wm8763 driver uses regmap for IO which means that codec->cache_sync is not > used. The line was added in commit d3398ff ('ASoC: Convert WM8753 to direct > regmap API usage'). Presumably this was meant to be regcache_mark_dirty(), but > since we already call regcache_mark_dirty() in the core when suspending the > CODEC it is safe to just remove the line. Applied, thanks.
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index be85da9..a02e76c 100644 --- a/sound/soc/codecs/wm8753.c +++ b/sound/soc/codecs/wm8753.c @@ -1440,7 +1440,6 @@ static void wm8753_work(struct work_struct *work) static int wm8753_suspend(struct snd_soc_codec *codec) { wm8753_set_bias_level(codec, SND_SOC_BIAS_OFF); - codec->cache_sync = 1; return 0; }
The wm8763 driver uses regmap for IO which means that codec->cache_sync is not used. The line was added in commit d3398ff ('ASoC: Convert WM8753 to direct regmap API usage'). Presumably this was meant to be regcache_mark_dirty(), but since we already call regcache_mark_dirty() in the core when suspending the CODEC it is safe to just remove the line. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- sound/soc/codecs/wm8753.c | 1 - 1 file changed, 1 deletion(-)